You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Xiaoqing Gao (Code Review)" <ge...@cloudera.org> on 2022/10/26 09:48:47 UTC
[Impala-ASF-CR] test create like
Xiaoqing Gao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19169
Change subject: test create like
......................................................................
test create like
Change-Id: I8dfd6068220968745309d35b81de211d4c185fc1
---
M fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java
M fe/src/main/java/org/apache/impala/analysis/KuduPartitionParam.java
M fe/src/main/java/org/apache/impala/analysis/RangePartition.java
M fe/src/main/java/org/apache/impala/catalog/FeKuduTable.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/util/KuduUtil.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
M testdata/datasets/functional/functional_schema_template.sql
A testdata/workloads/functional-query/queries/QueryTest/kudu_create_table_like_table.test
M tests/custom_cluster/test_kudu.py
M tests/query_test/test_kudu.py
11 files changed, 281 insertions(+), 17 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/69/19169/1
--
To view, visit http://gerrit.cloudera.org:8080/19169
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8dfd6068220968745309d35b81de211d4c185fc1
Gerrit-Change-Number: 19169
Gerrit-PatchSet: 1
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
[Impala-ASF-CR] test create like
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19169 )
Change subject: test create like
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/11711/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/19169
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8dfd6068220968745309d35b81de211d4c185fc1
Gerrit-Change-Number: 19169
Gerrit-PatchSet: 1
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 26 Oct 2022 10:07:34 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] test create like
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19169 )
Change subject: test create like
......................................................................
Patch Set 1:
(7 comments)
http://gerrit.cloudera.org:8080/#/c/19169/1/fe/src/main/java/org/apache/impala/catalog/FeKuduTable.java
File fe/src/main/java/org/apache/impala/catalog/FeKuduTable.java:
http://gerrit.cloudera.org:8080/#/c/19169/1/fe/src/main/java/org/apache/impala/catalog/FeKuduTable.java@136
PS1, Line 136: public static List<RangePartition> getTablePartition(KuduTable table) throws ImpalaRuntimeException {
line too long (105 > 90)
http://gerrit.cloudera.org:8080/#/c/19169/1/fe/src/main/java/org/apache/impala/catalog/FeKuduTable.java@150
PS1, Line 150:
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/19169/1/fe/src/main/java/org/apache/impala/catalog/FeKuduTable.java@160
PS1, Line 160:
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/19169/1/fe/src/main/java/org/apache/impala/catalog/FeKuduTable.java@161
PS1, Line 161: RangePartition rangePartition = RangePartition.createFromRange(new Pair<List<Expr>, Boolean>(startLiterals, true), new Pair<List<Expr>, Boolean>(endLiterals, false), null);
line too long (182 > 90)
http://gerrit.cloudera.org:8080/#/c/19169/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java:
http://gerrit.cloudera.org:8080/#/c/19169/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@3928
PS1, Line 3928: kuduPartitionParam.setRangeParitions(FeKuduTable.Utils.getTablePartition(kuduTable));
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/19169/1/fe/src/main/java/org/apache/impala/util/KuduUtil.java
File fe/src/main/java/org/apache/impala/util/KuduUtil.java:
http://gerrit.cloudera.org:8080/#/c/19169/1/fe/src/main/java/org/apache/impala/util/KuduUtil.java@486
PS1, Line 486: return NumericLiteral.create(int64Value, Type.BIGINT);
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/19169/1/fe/src/main/java/org/apache/impala/util/KuduUtil.java@505
PS1, Line 505: }
line has trailing whitespace
--
To view, visit http://gerrit.cloudera.org:8080/19169
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8dfd6068220968745309d35b81de211d4c185fc1
Gerrit-Change-Number: 19169
Gerrit-PatchSet: 1
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 26 Oct 2022 09:49:46 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] test create like
Posted by "Xiaoqing Gao (Code Review)" <ge...@cloudera.org>.
Xiaoqing Gao has abandoned this change. ( http://gerrit.cloudera.org:8080/19169 )
Change subject: test create like
......................................................................
Abandoned
--
To view, visit http://gerrit.cloudera.org:8080/19169
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I8dfd6068220968745309d35b81de211d4c185fc1
Gerrit-Change-Number: 19169
Gerrit-PatchSet: 1
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>