You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/03/30 03:24:48 UTC
[GitHub] [skywalking] dmsolr opened a new pull request #4589: [BugFix]Escape
'/' on InfluxDB query
dmsolr opened a new pull request #4589: [BugFix]Escape '/' on InfluxDB query
URL: https://github.com/apache/skywalking/pull/4589
Please answer these questions before submitting pull request
- Why submit this pull request?
- [x] Bug fix
- [ ] New feature provided
- [ ] Improve performance
- Related issues
___
### Bug fix
- Bug description.
'/' is a specific symbol on InfluxDB query, so need to escape by '\/'.
- How to fix?
___
### New feature or improvement
- Describe the details and related test reports.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] kezhenxu94 commented on issue #4589: [BugFix]Escape
'/' on InfluxDB query
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on issue #4589: [BugFix]Escape '/' on InfluxDB query
URL: https://github.com/apache/skywalking/pull/4589#issuecomment-605879144
Reminds me of the `%` in MySQL and H2, `%` is a similar in MySQL/H2 to `/` in InfluxDB, and is valid as part of the URL, right @wu-sheng ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4589: [BugFix]Escape '/'
on InfluxDB query
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4589: [BugFix]Escape '/' on InfluxDB query
URL: https://github.com/apache/skywalking/pull/4589#issuecomment-605880959
What is the context? I am guessing you are talking about mismatch?
1. `/` could be a part of the URI/endpoint for sure and common, so, when we are using the influxdb, it could be an issue.
2. `%` could be a part of the URI, but not common, as we are not using encodedURI. So, the impact of MySQL would be less, but still there, yes.
This should be discussed on the mail list, I think. Far away from this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng merged pull request #4589: [BugFix]Escape '/'
on InfluxDB query
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #4589: [BugFix]Escape '/' on InfluxDB query
URL: https://github.com/apache/skywalking/pull/4589
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] kezhenxu94 edited a comment on issue #4589:
[BugFix]Escape '/' on InfluxDB query
Posted by GitBox <gi...@apache.org>.
kezhenxu94 edited a comment on issue #4589: [BugFix]Escape '/' on InfluxDB query
URL: https://github.com/apache/skywalking/pull/4589#issuecomment-605879144
Reminds me of the `%` in MySQL and H2, `%` is similar in MySQL/H2 to `/` in InfluxDB, and is valid as part of the URL, right @wu-sheng ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services