You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/07/17 11:31:28 UTC
[GitHub] [flink] godfreyhe opened a new pull request #12923: [FLINK-18621][sql-client] Simplify the methods of Executor interface in sql client
godfreyhe opened a new pull request #12923:
URL: https://github.com/apache/flink/pull/12923
## What is the purpose of the change
*After TableEnvironment#executeSql is introduced, many methods of Executor interface in sql client can be replaced with TableEnvironment#executeSql. Those methods include:
listCatalogs, listDatabases, createTable, dropTable, listTables, listFunctions, useCatalog, useDatabase, getTableSchema (use DESCRIBE xx)*
## Brief change log
- *remove the methods which can be replaced with executeSql method in Executor interface, and update the related logic*
## Verifying this change
Update the existing tests, such as `LocalExecutorITCase`
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / **not documented**)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12923: [FLINK-18621][sql-client] Simplify the methods of Executor interface in sql client
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12923:
URL: https://github.com/apache/flink/pull/12923#issuecomment-660060951
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "048bf30dcd335ee5f66e62e3e81291ef00d03c8c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "048bf30dcd335ee5f66e62e3e81291ef00d03c8c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 048bf30dcd335ee5f66e62e3e81291ef00d03c8c UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12923: [FLINK-18621][sql-client] Simplify the methods of Executor interface in sql client
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12923:
URL: https://github.com/apache/flink/pull/12923#issuecomment-660060951
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "048bf30dcd335ee5f66e62e3e81291ef00d03c8c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4593",
"triggerID" : "048bf30dcd335ee5f66e62e3e81291ef00d03c8c",
"triggerType" : "PUSH"
}, {
"hash" : "39a2a0174464899202b5432ac002f5deb8895be3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4632",
"triggerID" : "39a2a0174464899202b5432ac002f5deb8895be3",
"triggerType" : "PUSH"
}, {
"hash" : "63cb77304f929aecf4ec45f3be7baac23bebbccd",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4643",
"triggerID" : "63cb77304f929aecf4ec45f3be7baac23bebbccd",
"triggerType" : "PUSH"
}, {
"hash" : "81bfbff96af91c7543ab8222cfe6aadb551d3d15",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "81bfbff96af91c7543ab8222cfe6aadb551d3d15",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 63cb77304f929aecf4ec45f3be7baac23bebbccd Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4643)
* 81bfbff96af91c7543ab8222cfe6aadb551d3d15 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12923: [FLINK-18621][sql-client] Simplify the methods of Executor interface in sql client
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12923:
URL: https://github.com/apache/flink/pull/12923#issuecomment-660060951
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "048bf30dcd335ee5f66e62e3e81291ef00d03c8c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4593",
"triggerID" : "048bf30dcd335ee5f66e62e3e81291ef00d03c8c",
"triggerType" : "PUSH"
}, {
"hash" : "39a2a0174464899202b5432ac002f5deb8895be3",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4632",
"triggerID" : "39a2a0174464899202b5432ac002f5deb8895be3",
"triggerType" : "PUSH"
}, {
"hash" : "63cb77304f929aecf4ec45f3be7baac23bebbccd",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "63cb77304f929aecf4ec45f3be7baac23bebbccd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 39a2a0174464899202b5432ac002f5deb8895be3 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4632)
* 63cb77304f929aecf4ec45f3be7baac23bebbccd UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12923: [FLINK-18621][sql-client] Simplify the methods of Executor interface in sql client
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12923:
URL: https://github.com/apache/flink/pull/12923#issuecomment-660060951
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "048bf30dcd335ee5f66e62e3e81291ef00d03c8c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4593",
"triggerID" : "048bf30dcd335ee5f66e62e3e81291ef00d03c8c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 048bf30dcd335ee5f66e62e3e81291ef00d03c8c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4593)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12923: [FLINK-18621][sql-client] Simplify the methods of Executor interface in sql client
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12923:
URL: https://github.com/apache/flink/pull/12923#issuecomment-660060951
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "048bf30dcd335ee5f66e62e3e81291ef00d03c8c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4593",
"triggerID" : "048bf30dcd335ee5f66e62e3e81291ef00d03c8c",
"triggerType" : "PUSH"
}, {
"hash" : "39a2a0174464899202b5432ac002f5deb8895be3",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4632",
"triggerID" : "39a2a0174464899202b5432ac002f5deb8895be3",
"triggerType" : "PUSH"
}, {
"hash" : "63cb77304f929aecf4ec45f3be7baac23bebbccd",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4643",
"triggerID" : "63cb77304f929aecf4ec45f3be7baac23bebbccd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 39a2a0174464899202b5432ac002f5deb8895be3 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4632)
* 63cb77304f929aecf4ec45f3be7baac23bebbccd Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4643)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12923: [FLINK-18621][sql-client] Simplify the methods of Executor interface in sql client
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12923:
URL: https://github.com/apache/flink/pull/12923#issuecomment-660060951
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "048bf30dcd335ee5f66e62e3e81291ef00d03c8c",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4593",
"triggerID" : "048bf30dcd335ee5f66e62e3e81291ef00d03c8c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 048bf30dcd335ee5f66e62e3e81291ef00d03c8c Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4593)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] JingsongLi commented on pull request #12923: [FLINK-18621][sql-client] Simplify the methods of Executor interface in sql client
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on pull request #12923:
URL: https://github.com/apache/flink/pull/12923#issuecomment-662778272
Can rebase master for triggering testing?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12923: [FLINK-18621][sql-client] Simplify the methods of Executor interface in sql client
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12923:
URL: https://github.com/apache/flink/pull/12923#issuecomment-660060951
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "048bf30dcd335ee5f66e62e3e81291ef00d03c8c",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4593",
"triggerID" : "048bf30dcd335ee5f66e62e3e81291ef00d03c8c",
"triggerType" : "PUSH"
}, {
"hash" : "39a2a0174464899202b5432ac002f5deb8895be3",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4632",
"triggerID" : "39a2a0174464899202b5432ac002f5deb8895be3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 048bf30dcd335ee5f66e62e3e81291ef00d03c8c Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4593)
* 39a2a0174464899202b5432ac002f5deb8895be3 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4632)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12923: [FLINK-18621][sql-client] Simplify the methods of Executor interface in sql client
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12923:
URL: https://github.com/apache/flink/pull/12923#issuecomment-660057893
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 048bf30dcd335ee5f66e62e3e81291ef00d03c8c (Fri Jul 17 11:33:49 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-18621).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12923: [FLINK-18621][sql-client] Simplify the methods of Executor interface in sql client
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12923:
URL: https://github.com/apache/flink/pull/12923#issuecomment-660060951
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "048bf30dcd335ee5f66e62e3e81291ef00d03c8c",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4593",
"triggerID" : "048bf30dcd335ee5f66e62e3e81291ef00d03c8c",
"triggerType" : "PUSH"
}, {
"hash" : "39a2a0174464899202b5432ac002f5deb8895be3",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "39a2a0174464899202b5432ac002f5deb8895be3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 048bf30dcd335ee5f66e62e3e81291ef00d03c8c Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4593)
* 39a2a0174464899202b5432ac002f5deb8895be3 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] godfreyhe commented on a change in pull request #12923: [FLINK-18621][sql-client] Simplify the methods of Executor interface in sql client
Posted by GitBox <gi...@apache.org>.
godfreyhe commented on a change in pull request #12923:
URL: https://github.com/apache/flink/pull/12923#discussion_r458686380
##########
File path: flink-core/src/main/java/org/apache/flink/util/CollectionUtil.java
##########
@@ -99,4 +100,18 @@ public static boolean isNullOrEmpty(Map<?, ?> map) {
iterable.iterator().forEachRemaining(list::add);
return list;
}
+
+ /**
+ * Collects the elements in the Iterator in a List. If the iterator argument is null,
+ * this method returns an empty list.
+ */
+ public static <E> List<E> iteratorToList(@Nullable Iterator<E> iterator) {
Review comment:
keep the same implementation of `CollectionUtil#iterableToList`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] JingsongLi merged pull request #12923: [FLINK-18621][sql-client] Simplify the methods of Executor interface in sql client
Posted by GitBox <gi...@apache.org>.
JingsongLi merged pull request #12923:
URL: https://github.com/apache/flink/pull/12923
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12923: [FLINK-18621][sql-client] Simplify the methods of Executor interface in sql client
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12923:
URL: https://github.com/apache/flink/pull/12923#issuecomment-660060951
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "048bf30dcd335ee5f66e62e3e81291ef00d03c8c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4593",
"triggerID" : "048bf30dcd335ee5f66e62e3e81291ef00d03c8c",
"triggerType" : "PUSH"
}, {
"hash" : "39a2a0174464899202b5432ac002f5deb8895be3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4632",
"triggerID" : "39a2a0174464899202b5432ac002f5deb8895be3",
"triggerType" : "PUSH"
}, {
"hash" : "63cb77304f929aecf4ec45f3be7baac23bebbccd",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4643",
"triggerID" : "63cb77304f929aecf4ec45f3be7baac23bebbccd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 63cb77304f929aecf4ec45f3be7baac23bebbccd Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4643)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] godfreyhe commented on pull request #12923: [FLINK-18621][sql-client] Simplify the methods of Executor interface in sql client
Posted by GitBox <gi...@apache.org>.
godfreyhe commented on pull request #12923:
URL: https://github.com/apache/flink/pull/12923#issuecomment-660986402
cc @JingsongLi @fsk119
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] godfreyhe commented on pull request #12923: [FLINK-18621][sql-client] Simplify the methods of Executor interface in sql client
Posted by GitBox <gi...@apache.org>.
godfreyhe commented on pull request #12923:
URL: https://github.com/apache/flink/pull/12923#issuecomment-662779443
> Can rebase master for triggering testing?
sure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12923: [FLINK-18621][sql-client] Simplify the methods of Executor interface in sql client
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12923:
URL: https://github.com/apache/flink/pull/12923#issuecomment-660060951
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "048bf30dcd335ee5f66e62e3e81291ef00d03c8c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4593",
"triggerID" : "048bf30dcd335ee5f66e62e3e81291ef00d03c8c",
"triggerType" : "PUSH"
}, {
"hash" : "39a2a0174464899202b5432ac002f5deb8895be3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4632",
"triggerID" : "39a2a0174464899202b5432ac002f5deb8895be3",
"triggerType" : "PUSH"
}, {
"hash" : "63cb77304f929aecf4ec45f3be7baac23bebbccd",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4643",
"triggerID" : "63cb77304f929aecf4ec45f3be7baac23bebbccd",
"triggerType" : "PUSH"
}, {
"hash" : "81bfbff96af91c7543ab8222cfe6aadb551d3d15",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4745",
"triggerID" : "81bfbff96af91c7543ab8222cfe6aadb551d3d15",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 63cb77304f929aecf4ec45f3be7baac23bebbccd Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4643)
* 81bfbff96af91c7543ab8222cfe6aadb551d3d15 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4745)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12923: [FLINK-18621][sql-client] Simplify the methods of Executor interface in sql client
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12923:
URL: https://github.com/apache/flink/pull/12923#issuecomment-660060951
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "048bf30dcd335ee5f66e62e3e81291ef00d03c8c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4593",
"triggerID" : "048bf30dcd335ee5f66e62e3e81291ef00d03c8c",
"triggerType" : "PUSH"
}, {
"hash" : "39a2a0174464899202b5432ac002f5deb8895be3",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4632",
"triggerID" : "39a2a0174464899202b5432ac002f5deb8895be3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 39a2a0174464899202b5432ac002f5deb8895be3 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4632)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] JingsongLi commented on a change in pull request #12923: [FLINK-18621][sql-client] Simplify the methods of Executor interface in sql client
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on a change in pull request #12923:
URL: https://github.com/apache/flink/pull/12923#discussion_r458505381
##########
File path: flink-core/src/main/java/org/apache/flink/util/CollectionUtil.java
##########
@@ -99,4 +100,18 @@ public static boolean isNullOrEmpty(Map<?, ?> map) {
iterable.iterator().forEachRemaining(list::add);
return list;
}
+
+ /**
+ * Collects the elements in the Iterator in a List. If the iterator argument is null,
+ * this method returns an empty list.
+ */
+ public static <E> List<E> iteratorToList(@Nullable Iterator<E> iterator) {
Review comment:
According to `IteratorUtils.toList`, if iterator is null, should throw NPE. I think it is good to be consistent with commons-collections.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org