You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2022/08/08 09:32:43 UTC

[GitHub] [fineract] vidakovic commented on a diff in pull request #2481: [FINERACT-1678] configuration validation for COBs

vidakovic commented on code in PR #2481:
URL: https://github.com/apache/fineract/pull/2481#discussion_r940030151


##########
fineract-provider/src/main/resources/application.properties:
##########
@@ -43,6 +43,11 @@ fineract.mode.batch-manager-enabled=${FINERACT_MODE_BATCH_MANAGER_ENABLED:true}
 fineract.correlation.enabled=${FINERACT_LOGGING_HTTP_CORRELATION_ID_ENABLED:false}
 fineract.correlation.header-name=${FINERACT_LOGGING_HTTP_CORRELATION_ID_HEADER_NAME:X-Correlation-ID}
 
+fineract.partitioned-job.job-properties[0].job-name=LOAN_COB
+fineract.partitioned-job.job-properties[0].chunk-size=${LOAN_COB_CHUNK_SIZE:100}

Review Comment:
   Two things:
   
   - can't we shorten the property prefix from `fineract.partitioned-job.job-properties` to just `fineract.partitioned-jobs`; seems a bit redundant to nest the list as the only attribute in yet another nested class (see my comment above)
   - we should prefix the environment variables properly to indicate they are introduced by Fineract. Instead of `LOAN_COB_PARTITION_SIZE` I'd suggest `FINERACT_PARTIONED_JOB_PARTITION_SIZE` which is closer to the property name; we had already a cleanup in the past to remove inconsistent variable names, would be great if we could stick with this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org