You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/04/01 19:59:05 UTC

[GitHub] [tvm] shingjan commented on a change in pull request #10874: [BugFix] Fix PopenWorker Memory Leak

shingjan commented on a change in pull request #10874:
URL: https://github.com/apache/tvm/pull/10874#discussion_r840882085



##########
File path: python/tvm/exec/popen_worker.py
##########
@@ -69,6 +79,7 @@ def _cancel_run(status):
         lock.release()
 
     while True:
+        reader = get_reader()

Review comment:
       I am a little concerned by the fact that we are creating file descriptor each time in an infinite loop. If this is a memory leak occurred within a subprocess, would this [issue](https://bugs.python.org/issue12650) more relevant?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org