You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/05/04 11:53:43 UTC
[GitHub] [arrow] raulcd opened a new pull request, #13064: ARROW-16436: [C++][Python] Datasets should not ignore CSV autogenerate_column_names
raulcd opened a new pull request, #13064:
URL: https://github.com/apache/arrow/pull/13064
The added test failed previously because the `autogenerate_column_names` was ignored:
```
E pyarrow.lib.ArrowInvalid: Error creating dataset. Could not read schema from '/tmp/pytest-of/pytest-15/test_csv_format_options_genera1/test.csv': Could not open CSV input source '/tmp/pytest-of/pytest-15/test_csv_format_options_genera1/test.csv': Invalid: CSV file contained multiple columns named 1. Is this a 'csv' file?
```
Use the same approach we use on `GenerateColumnNames` here https://github.com/apache/arrow/blob/master/cpp/src/arrow/csv/reader.cc#L637-L646
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou closed pull request #13064: ARROW-16436: [C++][Python] Datasets should not ignore CSV autogenerate_column_names
Posted by GitBox <gi...@apache.org>.
pitrou closed pull request #13064: ARROW-16436: [C++][Python] Datasets should not ignore CSV autogenerate_column_names
URL: https://github.com/apache/arrow/pull/13064
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #13064: ARROW-16436: [C++][Python] Datasets should not ignore CSV autogenerate_column_names
Posted by GitBox <gi...@apache.org>.
pitrou commented on PR #13064:
URL: https://github.com/apache/arrow/pull/13064#issuecomment-1117337795
CI failures seem unexpected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #13064: ARROW-16436: [C++][Python] Datasets should not ignore CSV autogenerate_column_names
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13064:
URL: https://github.com/apache/arrow/pull/13064#issuecomment-1117222389
https://issues.apache.org/jira/browse/ARROW-16436
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #13064: ARROW-16436: [C++][Python] Datasets should not ignore CSV autogenerate_column_names
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #13064:
URL: https://github.com/apache/arrow/pull/13064#issuecomment-1120378577
Benchmark runs are scheduled for baseline = 893faa741f34ee450070503566dafb7291e24d9f and contender = 37c3bd00f812513fe22179ae87573893c741af51. 37c3bd00f812513fe22179ae87573893c741af51 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/210626ba1faf4bf5af912596f110a341...4083f6fd36f743259880cbdb0566df42/)
[Finished :arrow_down:0.62% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/39d0fc6c235d4730bb846486d32219f1...abfa8e6a9ee44e9bb2b36ac19ffc3891/)
[Finished :arrow_down:0.36% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/a7cc3bcf62cf4f419de94bd15841ec28...b77084dd77e9427b9b46dd272cc97382/)
[Finished :arrow_down:0.32% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/c941a5a3212f4d22b62ddbdeeff60b41...e16f253c020b4b10b9b563e331e40046/)
Buildkite builds:
[Finished] [`37c3bd00` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/697)
[Finished] [`37c3bd00` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/694)
[Finished] [`37c3bd00` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/683)
[Finished] [`37c3bd00` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/699)
[Finished] [`893faa74` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/696)
[Finished] [`893faa74` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/693)
[Finished] [`893faa74` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/682)
[Finished] [`893faa74` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/698)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org