You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/03/05 09:02:55 UTC

[GitHub] [rocketmq-client-go] jerry-tao opened a new pull request #613: [ISSUE #568] Update lastPullTime use atomic.Value

jerry-tao opened a new pull request #613:
URL: https://github.com/apache/rocketmq-client-go/pull/613


    [ISSUE #568] Update lastPullTime use atomic.Value as same with lastConsumeTime and lastLockTime
   
   ## What is the purpose of the change
   
    [ISSUE #568] Update lastPullTime use atomic.Value as same with lastConsumeTime and lastLockTime
   
   ## Brief changelog
   
    [ISSUE #568] Update lastPullTime use atomic.Value as same with lastConsumeTime and lastLockTime
   
   ## Verifying this change
   
   ```
   
   func main() {
   	var nameSrv string
   	var group string
   	var topic string
   	c, _ := rocketmq.NewPushConsumer(
   		consumer.WithNameServer([]string{nameSrv}),
   		consumer.WithConsumerModel(consumer.Clustering),
   		consumer.WithGroupName(group),
   	)
   	_ = c.Subscribe(topic, consumer.MessageSelector{}, func(ctx context.Context, msgs ...*primitive.MessageExt) (consumer.ConsumeResult, error) {
   		fmt.Printf("subscribe callback: %v \n", msgs)
   		return consumer.ConsumeSuccess, nil
   	})
   	c.Start()
   	n := make(chan os.Signal, 1)
   	signal.Notify(n, syscall.SIGHUP, syscall.SIGQUIT, syscall.SIGTERM, syscall.SIGINT, syscall.SIGSTOP)
   	<-n
   
   }
   
   ```
   
   ```
   go run -race consumer.go
   ```
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq-client-go] codecov-io edited a comment on pull request #613: [ISSUE #568] Update lastPullTime use atomic.Value

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #613:
URL: https://github.com/apache/rocketmq-client-go/pull/613#issuecomment-791276370


   # [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/613?src=pr&el=h1) Report
   > Merging [#613](https://codecov.io/gh/apache/rocketmq-client-go/pull/613?src=pr&el=desc) (08638a1) into [master](https://codecov.io/gh/apache/rocketmq-client-go/commit/6cd31818c52408d69f3209d0d62af33f0451125e?el=desc) (6cd3181) will **decrease** coverage by `0.01%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/rocketmq-client-go/pull/613/graphs/tree.svg?width=650&height=150&src=pr&token=CiV9ofPkG3)](https://codecov.io/gh/apache/rocketmq-client-go/pull/613?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #613      +/-   ##
   ==========================================
   - Coverage   24.46%   24.45%   -0.02%     
   ==========================================
     Files          48       48              
     Lines        5047     5051       +4     
   ==========================================
     Hits         1235     1235              
   - Misses       3609     3613       +4     
     Partials      203      203              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/rocketmq-client-go/pull/613?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [consumer/process\_queue.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/613/diff?src=pr&el=tree#diff-Y29uc3VtZXIvcHJvY2Vzc19xdWV1ZS5nbw==) | `0.00% <0.00%> (ø)` | |
   | [consumer/push\_consumer.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/613/diff?src=pr&el=tree#diff-Y29uc3VtZXIvcHVzaF9jb25zdW1lci5nbw==) | `11.38% <0.00%> (ø)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/613?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/613?src=pr&el=footer). Last update [6cd3181...08638a1](https://codecov.io/gh/apache/rocketmq-client-go/pull/613?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq-client-go] ShannonDing merged pull request #613: [ISSUE #568] Update lastPullTime use atomic.Value

Posted by GitBox <gi...@apache.org>.
ShannonDing merged pull request #613:
URL: https://github.com/apache/rocketmq-client-go/pull/613


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq-client-go] codecov-io commented on pull request #613: [ISSUE #568] Update lastPullTime use atomic.Value

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #613:
URL: https://github.com/apache/rocketmq-client-go/pull/613#issuecomment-791276370


   # [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/613?src=pr&el=h1) Report
   > Merging [#613](https://codecov.io/gh/apache/rocketmq-client-go/pull/613?src=pr&el=desc) (08638a1) into [master](https://codecov.io/gh/apache/rocketmq-client-go/commit/6cd31818c52408d69f3209d0d62af33f0451125e?el=desc) (6cd3181) will **decrease** coverage by `0.01%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/rocketmq-client-go/pull/613/graphs/tree.svg?width=650&height=150&src=pr&token=CiV9ofPkG3)](https://codecov.io/gh/apache/rocketmq-client-go/pull/613?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #613      +/-   ##
   ==========================================
   - Coverage   24.46%   24.45%   -0.02%     
   ==========================================
     Files          48       48              
     Lines        5047     5051       +4     
   ==========================================
     Hits         1235     1235              
   - Misses       3609     3613       +4     
     Partials      203      203              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/rocketmq-client-go/pull/613?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [consumer/process\_queue.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/613/diff?src=pr&el=tree#diff-Y29uc3VtZXIvcHJvY2Vzc19xdWV1ZS5nbw==) | `0.00% <0.00%> (ø)` | |
   | [consumer/push\_consumer.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/613/diff?src=pr&el=tree#diff-Y29uc3VtZXIvcHVzaF9jb25zdW1lci5nbw==) | `11.38% <0.00%> (ø)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/613?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/613?src=pr&el=footer). Last update [6cd3181...08638a1](https://codecov.io/gh/apache/rocketmq-client-go/pull/613?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org