You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/08/27 13:37:32 UTC
[GitHub] [doris] dataroaring opened a new pull request, #12124: [fix](checksum) checksum should respect DELETE_SIGN column
dataroaring opened a new pull request, #12124:
URL: https://github.com/apache/doris/pull/12124
If checksum does not respect DELETE_SIGN column, then is 2 replicas'
compaction status is not same, then they may generate different checksums
probabaly.
BTW: We change checksum to vectorized engine.
# Proposed changes
Issue Number: close #xxx
## Problem summary
Describe your changes.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] closed pull request #12124: [fix](checksum) checksum should respect DELETE_SIGN column
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #12124: [fix](checksum) checksum should respect DELETE_SIGN column
URL: https://github.com/apache/doris/pull/12124
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #12124: [fix](checksum) checksum should respect DELETE_SIGN column
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #12124:
URL: https://github.com/apache/doris/pull/12124#issuecomment-1449117640
We're closing this PR because it hasn't been updated in a while.
This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and feel free a maintainer to remove the Stale tag!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman commented on a diff in pull request #12124: [fix](checksum) checksum should respect DELETE_SIGN column
Posted by GitBox <gi...@apache.org>.
morningman commented on code in PR #12124:
URL: https://github.com/apache/doris/pull/12124#discussion_r956585665
##########
be/src/olap/task/engine_checksum_task.cpp:
##########
@@ -54,71 +55,58 @@ Status EngineChecksumTask::_compute_checksum() {
return Status::OLAPInternalError(OLAP_ERR_TABLE_NOT_FOUND);
}
- TupleReader reader;
- TabletReader::ReaderParams reader_params;
- reader_params.tablet = tablet;
- reader_params.reader_type = READER_CHECKSUM;
- reader_params.version = Version(0, _version);
-
- {
- std::shared_lock rdlock(tablet->get_header_lock());
- const RowsetSharedPtr message = tablet->rowset_with_max_version();
- if (message == nullptr) {
- LOG(FATAL) << "fail to get latest version. tablet_id=" << _tablet_id;
- return Status::OLAPInternalError(OLAP_ERR_WRITE_PROTOBUF_ERROR);
- }
-
- Status acquire_reader_st =
- tablet->capture_rs_readers(reader_params.version, &reader_params.rs_readers);
- if (acquire_reader_st != Status::OK()) {
- LOG(WARNING) << "fail to init reader. tablet=" << tablet->full_name()
- << "res=" << acquire_reader_st;
- return acquire_reader_st;
- }
+ std::vector<RowsetSharedPtr> input_rowsets;
+ Version version(0, _version);
+ Status acquire_reader_st = tablet->capture_consistent_rowsets(version, &input_rowsets);
+ if (acquire_reader_st != Status::OK()) {
+ LOG(WARNING) << "fail to captute consistent rowsets. tablet=" << tablet->full_name()
+ << "res=" << acquire_reader_st;
+ return acquire_reader_st;
}
- for (size_t i = 0; i < tablet->tablet_schema()->num_columns(); ++i) {
- reader_params.return_columns.push_back(i);
- }
+ vectorized::BlockReader reader;
+ TabletReader::ReaderParams reader_params;
+ vectorized::Block block;
+ RETURN_NOT_OK(TabletReader::init_reader_params_and_create_block(
+ tablet, READER_CHECKSUM, input_rowsets, &reader_params, &block));
res = reader.init(reader_params);
if (!res.ok()) {
LOG(WARNING) << "initiate reader fail. res = " << res;
return res;
}
+ LOG(INFO) << "yyq columns " << reader_params.return_columns.size();
RowCursor row;
- std::unique_ptr<MemPool> mem_pool(new MemPool());
- std::unique_ptr<ObjectPool> agg_object_pool(new ObjectPool());
- res = row.init(tablet->tablet_schema(), reader_params.return_columns);
+ res = row.init(reader_params.tablet_schema, reader_params.return_columns);
Review Comment:
This row is no longer used?
##########
be/src/olap/task/engine_checksum_task.cpp:
##########
@@ -54,71 +55,58 @@ Status EngineChecksumTask::_compute_checksum() {
return Status::OLAPInternalError(OLAP_ERR_TABLE_NOT_FOUND);
}
- TupleReader reader;
- TabletReader::ReaderParams reader_params;
- reader_params.tablet = tablet;
- reader_params.reader_type = READER_CHECKSUM;
- reader_params.version = Version(0, _version);
-
- {
- std::shared_lock rdlock(tablet->get_header_lock());
- const RowsetSharedPtr message = tablet->rowset_with_max_version();
- if (message == nullptr) {
- LOG(FATAL) << "fail to get latest version. tablet_id=" << _tablet_id;
- return Status::OLAPInternalError(OLAP_ERR_WRITE_PROTOBUF_ERROR);
- }
-
- Status acquire_reader_st =
- tablet->capture_rs_readers(reader_params.version, &reader_params.rs_readers);
- if (acquire_reader_st != Status::OK()) {
- LOG(WARNING) << "fail to init reader. tablet=" << tablet->full_name()
- << "res=" << acquire_reader_st;
- return acquire_reader_st;
- }
+ std::vector<RowsetSharedPtr> input_rowsets;
+ Version version(0, _version);
+ Status acquire_reader_st = tablet->capture_consistent_rowsets(version, &input_rowsets);
+ if (acquire_reader_st != Status::OK()) {
+ LOG(WARNING) << "fail to captute consistent rowsets. tablet=" << tablet->full_name()
+ << "res=" << acquire_reader_st;
+ return acquire_reader_st;
}
- for (size_t i = 0; i < tablet->tablet_schema()->num_columns(); ++i) {
- reader_params.return_columns.push_back(i);
- }
+ vectorized::BlockReader reader;
+ TabletReader::ReaderParams reader_params;
+ vectorized::Block block;
+ RETURN_NOT_OK(TabletReader::init_reader_params_and_create_block(
+ tablet, READER_CHECKSUM, input_rowsets, &reader_params, &block));
res = reader.init(reader_params);
if (!res.ok()) {
LOG(WARNING) << "initiate reader fail. res = " << res;
return res;
}
+ LOG(INFO) << "yyq columns " << reader_params.return_columns.size();
Review Comment:
remove debug log
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org