[GitHub] xrmx commented on a change in pull request #3441: config: allow choosing separator character and encoding for csv writing

[gi...@git.apache.org]

xrmx commented on a change in pull request #3441: config: allow choosing separator character and encoding for csv writing
URL: https://github.com/apache/incubator-superset/pull/3441#discussion_r138013528
 
 

 ##########
 File path: superset/config.py
 ##########
 @@ -172,6 +172,9 @@
 ENABLE_CORS = False
 CORS_OPTIONS = {}
 
+# CSV Options
+CSV_SEP = ','
 
 Review comment:
   Since CSV has a ton of options and pandas does not support dialects i think a CSV_EXPORT dict would be more future proof:
   
   ```
   CSV_EXPORT = {
       'SEPARATOR': ',',
       'ENCODING': 'utf-8',
   }
   ```
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services