You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by weiqingy <gi...@git.apache.org> on 2016/10/17 22:35:11 UTC
[GitHub] spark pull request #15522: [MINOR][DOC] Add more built-in sources in sql-pro...
GitHub user weiqingy opened a pull request:
https://github.com/apache/spark/pull/15522
[MINOR][DOC] Add more built-in sources in sql-programming-guide.md
## What changes were proposed in this pull request?
Add more built-in sources in sql-programming-guide.md.
## How was this patch tested?
Manually.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/weiqingy/spark dsDoc
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/15522.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #15522
----
commit a43e1d9b8c3cb0fb1dc0c6a6ed09db80edccd7d0
Author: Weiqing Yang <ya...@gmail.com>
Date: 2016-10-17T22:34:31Z
[MINOR][DOC] Add more built-in sources in sql-programming-guide.md
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #15522: [MINOR][DOC] Add more built-in sources in sql-pro...
Posted by weiqingy <gi...@git.apache.org>.
Github user weiqingy commented on a diff in the pull request:
https://github.com/apache/spark/pull/15522#discussion_r83941926
--- Diff: docs/sql-programming-guide.md ---
@@ -422,8 +422,8 @@ In the simplest form, the default data source (`parquet` unless otherwise config
You can also manually specify the data source that will be used along with any extra options
that you would like to pass to the data source. Data sources are specified by their fully qualified
name (i.e., `org.apache.spark.sql.parquet`), but for built-in sources you can also use their short
--- End diff --
Thanks for the comment. I am wondering if we could make another jira/PR for that? I prefer not to mix the documentation with code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #15522: [MINOR][DOC] Add more built-in sources in sql-programmin...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15522
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #15522: [MINOR][DOC] Add more built-in sources in sql-programmin...
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/15522
Merging in master/branch-2.0. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #15522: [MINOR][DOC] Add more built-in sources in sql-pro...
Posted by weiqingy <gi...@git.apache.org>.
Github user weiqingy commented on a diff in the pull request:
https://github.com/apache/spark/pull/15522#discussion_r83772075
--- Diff: docs/sql-programming-guide.md ---
@@ -422,7 +422,7 @@ In the simplest form, the default data source (`parquet` unless otherwise config
You can also manually specify the data source that will be used along with any extra options
that you would like to pass to the data source. Data sources are specified by their fully qualified
name (i.e., `org.apache.spark.sql.parquet`), but for built-in sources you can also use their short
-names (`json`, `parquet`, `jdbc`). DataFrames loaded from any data source type can be converted into other types
+names (`json`, `parquet`, `jdbc`, `orc`, `libsvm`, `csv`). DataFrames loaded from any data source type can be converted into other types
--- End diff --
Yes. Done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #15522: [MINOR][DOC] Add more built-in sources in sql-pro...
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15522#discussion_r83770406
--- Diff: docs/sql-programming-guide.md ---
@@ -422,7 +422,7 @@ In the simplest form, the default data source (`parquet` unless otherwise config
You can also manually specify the data source that will be used along with any extra options
that you would like to pass to the data source. Data sources are specified by their fully qualified
name (i.e., `org.apache.spark.sql.parquet`), but for built-in sources you can also use their short
-names (`json`, `parquet`, `jdbc`). DataFrames loaded from any data source type can be converted into other types
+names (`json`, `parquet`, `jdbc`, `orc`, `libsvm`, `csv`). DataFrames loaded from any data source type can be converted into other types
--- End diff --
maybe line break it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #15522: [MINOR][DOC] Add more built-in sources in sql-pro...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/15522
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #15522: [MINOR][DOC] Add more built-in sources in sql-pro...
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15522#discussion_r83773809
--- Diff: docs/sql-programming-guide.md ---
@@ -422,8 +422,8 @@ In the simplest form, the default data source (`parquet` unless otherwise config
You can also manually specify the data source that will be used along with any extra options
that you would like to pass to the data source. Data sources are specified by their fully qualified
name (i.e., `org.apache.spark.sql.parquet`), but for built-in sources you can also use their short
-names (`json`, `parquet`, `jdbc`). DataFrames loaded from any data source type can be converted into other types
-using this syntax.
+names (`json`, `parquet`, `jdbc`, `orc`, `libsvm`, `csv`). DataFrames loaded from any data source
--- End diff --
Maybe we should add `text` as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org