[jira] [Commented] (PHOENIX-5615) Index read repair should delete all the cells of an invalid unverified row

["Hadoop QA (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-5615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16994771#comment-16994771 ] 

Hadoop QA commented on PHOENIX-5615:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12988690/PHOENIX-5615.4.x-HBase-1.5.001.patch
  against 4.x-HBase-1.5 branch at commit 964dd80f20ab8649af7672314f4127b73c0280b7.
  ATTACHMENT ID: 12988690

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than 100:
    +        props.put(QueryServices.GLOBAL_INDEX_ROW_AGE_THRESHOLD_TO_DELETE_MS_ATTRIB, Long.toString(0));
+            conn.createStatement().execute("upsert into " + dataTableName + " (id, val2, val3) values ('a', 'abcc', 'abccc')");
+            // all the columns of the unverified index row that was generated due to doing only one phase write above

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/3188//testReport/
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/3188//console

This message is automatically generated.

> Index read repair should delete all the cells of an invalid unverified row
> --------------------------------------------------------------------------
>
>                 Key: PHOENIX-5615
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5615
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 5.0.0, 4.14.3
>            Reporter: Kadir OZDEMIR
>            Assignee: Kadir OZDEMIR
>            Priority: Critical
>         Attachments: PHOENIX-5615.4.x-HBase-1.5.001.patch, PHOENIX-5615.master.001.patch
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> In the current implementation, the index read repair deletes only the cells that are returned by the scan initiated by the Phoenix client instead of deleting all the cells of an invalid unverified row.
> The read repair deletes cells (i.e., a specific version of a row) only when if an index row is overwritten but the corresponding data table row overwrite fails. This leaves the the index row in the unverified status. Then the read repair detects this unverified row when it is scanned and needs to delete the cells of this unverified version of the row. However, the read repair (i.e., GlobalIndexChecker) puts the delete markers for only the cells returned by the scan. If the scan does not return all the cells of the row, then only a subset of the cells of the row will be deleted. The remaining cells will not be removed and can be returned by the scans initiated later. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)