[GitHub] [incubator-superset] villebro commented on a change in pull request #7048: feat: add Dremio connector support

[GitBox <gi...@apache.org>]

villebro commented on a change in pull request #7048: feat: add Dremio connector support
URL: https://github.com/apache/incubator-superset/pull/7048#discussion_r275717308
 
 

 ##########
 File path: superset/sql_parse.py
 ##########
 @@ -35,7 +35,10 @@ def __init__(self, sql_statement):
         self._table_names = set()
         self._alias_names = set()
         self._limit = None
-
+        # Start Dremio Support
+        self.sql = self.sql.replace('[','"')
+        self.sql = self.sql.replace(']','"')
+        # End Dremio Support
 
 Review comment:
   This should not be here, and as stated above any engine specifics should be moved to `db_engine_specs.py`.  It appears that the dialect that is rendering queries is incorrectly using square brackets where they should be double quotes? To me this would indicate that you've specified an incorrect dialect in your SQLAlchemy URI (e.g. `oracle+cx_oracle://` means oracle dialect with cx_oracle connector), which is causing the incorrect column quotes to be used.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org