You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maka.apache.org by "Sun-GLiang (via GitHub)" <gi...@apache.org> on 2026/08/27 03:46:13 UTC

Re: [PR] fix(desktop): make proxy credential updates explicit and Host-owned [maka]

Sun-GLiang commented on PR #3704:
URL: https://github.com/apache/maka/pull/3704#issuecomment-5434105031

   I have updated the PR title and charter to match the change that is actually being reviewed.
   
   The title is now:
   
   > `fix(desktop): make proxy credential updates explicit and Host-owned`
   
   The PR description now presents this as a proxy-credential lifecycle migration rather than an input-mask-only fix. It separates the review into three explicit contracts:
   
   1. legacy Settings cleanup and schema-v1 credential transfer;
   2. Host-owned policy/vault CAS, publication ordering, and partial-outcome reporting;
   3. Renderer-local draft, commit/cancel/reveal behavior, and proxy-only Copy removal.
   
   I have not split the branch at this point. These contracts are independently testable, but the current implementation delivers them as one compatibility boundary. Splitting them would require a temporary dual-shape compatibility layer or restoring part of the unsafe representation during the intermediate merges:
   
   - Removing `password` from ordinary Settings requires both the read-only `passwordConfigured` projection and a write-only credential mutation.
   - The Renderer draft depends on that explicit Host mutation; otherwise an intermediate version must retain either the sentinel or the previous split-write path.
   - The Host operation must validate the policy revision and credential generation in one lane so disabling authentication wins over an older replacement, as required by #3696.
   - Once the Settings shape changes, schema-v1 transfer needs an adapter and persisted legacy Settings need cleanup so compatibility paths cannot retain or reintroduce the removed secret field.
   - The Runtime Host epoch moves with this boundary because an older peer can split policy and credential writes against different bases.
   
   The revised description does not claim an all-or-nothing storage transaction. It states the implemented contract directly: shared preflight, ordered publication, and `commit_outcome_unknown` when a durable failure occurs after only part of the compound operation has committed.
   
   The verification section is now organized around the invariant-bearing coverage for each review boundary: minimal migration and credential-only transfer cases, Host two-client/CAS and durable failure cuts, Renderer draft concurrency/failure cases, and one offline authenticated-proxy E2E. I have not moved or pruned tests while the review-unit decision remains open.
   
   Please re-evaluate the review unit under the revised title and charter. If maintainers still require a physical split after considering these compatibility dependencies, the fallback will be ordered stacked PRs rather than treating the three contracts as unrelated changes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org