[GitHub] HeartSaVioR edited a comment on issue #23776: [SPARK-26650][core] Demote noisy HBase-related log message.

[GitBox <gi...@apache.org>]

HeartSaVioR edited a comment on issue #23776: [SPARK-26650][core] Demote noisy HBase-related log message.
URL: https://github.com/apache/spark/pull/23776#issuecomment-463425208
 
 
   Yeah and previously I have to request customer to turn on debug log and rerun query to get such information, hence I proposed to make the log level be consistent. Please see #23418. 
   
   This patch suggests to roll back the change: when we want to roll back the log level, adding comment like `it is intentionally set to debug to avoid being noisy for non-HBase related query` would help avoiding to fixing level back and forth.
   
   > Putting this in a separate module is not just something that should be as separate change, but also means we'd have an opinion about what version of HBase Spark is built against.
   
   Please correct me if I'm missing here: if my understanding is right, once current approach doesn't deal with HBase version, putting this in a separate module also doesn't need to deal with HBase version (we will still rely on reflection even in that case). End users just need to dynamically link the new package if they use HBase with Kerberos enabled.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org