You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@impala.apache.org by "Lars Volker (Code Review)" <ge...@cloudera.org> on 2016/03/02 20:38:31 UTC
[Impala-CR](cdh5-2.5.0_5.7.0) IMPALA-TODO: Fix detection of is_cached, is_remote
Lars Volker has uploaded a new change for review.
http://gerrit.cloudera.org:8080/2412
Change subject: IMPALA-TODO: Fix detection of is_cached, is_remote
......................................................................
IMPALA-TODO: Fix detection of is_cached, is_remote
The scheduler incorrectly sets is_cached and is_remote during replica
selection. This change fixes the code by only setting the variables if
a better replica is selected.
Change-Id: I5e406c15aa465e379d9ed0f979a5d8c5aed3e8a6
---
M be/src/scheduling/simple-scheduler.cc
1 file changed, 3 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/12/2412/1
--
To view, visit http://gerrit.cloudera.org:8080/2412
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5e406c15aa465e379d9ed0f979a5d8c5aed3e8a6
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.5.0_5.7.0
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
[Impala-CR](cdh5-2.5.0_5.7.0) IMPALA-TODO: Fix detection of is_cached, is_remote
Posted by "Silvius Rus (Code Review)" <ge...@cloudera.org>.
Silvius Rus has posted comments on this change.
Change subject: IMPALA-TODO: Fix detection of is_cached, is_remote
......................................................................
Patch Set 1: Code-Review+2
Approved by gatekeeper.
--
To view, visit http://gerrit.cloudera.org:8080/2412
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5e406c15aa465e379d9ed0f979a5d8c5aed3e8a6
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.5.0_5.7.0
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <ma...@cloudera.com>
Gerrit-Reviewer: Silvius Rus <sr...@cloudera.com>
Gerrit-HasComments: No
[Impala-CR](cdh5-2.5.0_5.7.0) IMPALA-3122: Fix detection of is_cached, is_remote
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Hello Marcel Kornacker, Silvius Rus,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/2412
to look at the new patch set (#2).
Change subject: IMPALA-3122: Fix detection of is_cached, is_remote
......................................................................
IMPALA-3122: Fix detection of is_cached, is_remote
The scheduler incorrectly sets is_cached and is_remote during replica
selection. This change fixes the code by only setting the variables if
a better replica is selected.
Change-Id: I5e406c15aa465e379d9ed0f979a5d8c5aed3e8a6
---
M be/src/scheduling/simple-scheduler.cc
1 file changed, 3 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/12/2412/2
--
To view, visit http://gerrit.cloudera.org:8080/2412
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5e406c15aa465e379d9ed0f979a5d8c5aed3e8a6
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.5.0_5.7.0
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <ma...@cloudera.com>
Gerrit-Reviewer: Silvius Rus <sr...@cloudera.com>
[Impala-CR](cdh5-2.5.0_5.7.0) IMPALA-TODO: Fix detection of is_cached, is_remote
Posted by "Marcel Kornacker (Code Review)" <ge...@cloudera.org>.
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-TODO: Fix detection of is_cached, is_remote
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/2412
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5e406c15aa465e379d9ed0f979a5d8c5aed3e8a6
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.5.0_5.7.0
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <ma...@cloudera.com>
Gerrit-HasComments: No
[Impala-CR](cdh5-2.5.0_5.7.0) IMPALA-3122: Fix detection of is_cached, is_remote
Posted by "Internal Jenkins (Code Review)" <ge...@cloudera.org>.
Internal Jenkins has submitted this change and it was merged.
Change subject: IMPALA-3122: Fix detection of is_cached, is_remote
......................................................................
IMPALA-3122: Fix detection of is_cached, is_remote
The scheduler incorrectly sets is_cached and is_remote during replica
selection. This change fixes the code by only setting the variables if
a better replica is selected.
Change-Id: I5e406c15aa465e379d9ed0f979a5d8c5aed3e8a6
Reviewed-on: http://gerrit.cloudera.org:8080/2412
Reviewed-by: Lars Volker <lv...@cloudera.com>
Tested-by: Internal Jenkins
---
M be/src/scheduling/simple-scheduler.cc
1 file changed, 3 insertions(+), 6 deletions(-)
Approvals:
Lars Volker: Looks good to me, approved
Internal Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/2412
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5e406c15aa465e379d9ed0f979a5d8c5aed3e8a6
Gerrit-PatchSet: 3
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.5.0_5.7.0
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <ma...@cloudera.com>
Gerrit-Reviewer: Silvius Rus <sr...@cloudera.com>
[Impala-CR](cdh5-2.5.0_5.7.0) IMPALA-3122: Fix detection of is_cached, is_remote
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change.
Change subject: IMPALA-3122: Fix detection of is_cached, is_remote
......................................................................
Patch Set 2: Code-Review+2
Included Jira number in commit message.
+2 from Marcel and Silvius (gatekeeper).
--
To view, visit http://gerrit.cloudera.org:8080/2412
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5e406c15aa465e379d9ed0f979a5d8c5aed3e8a6
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.5.0_5.7.0
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <ma...@cloudera.com>
Gerrit-Reviewer: Silvius Rus <sr...@cloudera.com>
Gerrit-HasComments: No