You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/08/05 07:16:10 UTC

[GitHub] [arrow] pitrou commented on a change in pull request #10882: ARROW-13567: [C++] ConvertOptions::Defaults leaves `timestamp_parsers` uninitialized

pitrou commented on a change in pull request #10882:
URL: https://github.com/apache/arrow/pull/10882#discussion_r683190818



##########
File path: cpp/src/arrow/csv/options.cc
##########
@@ -43,6 +43,7 @@ ConvertOptions ConvertOptions::Defaults() {
                          "NULL", "NaN",  "n/a",      "nan",     "null"};
   options.true_values = {"1", "True", "TRUE", "true"};
   options.false_values = {"0", "False", "FALSE", "false"};
+  options.timestamp_parsers = {};

Review comment:
       Why is this necessary? `std::vector` is initialized to an empty vector by default.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org