You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "yp969803 (via GitHub)" <gi...@apache.org> on 2024/01/29 19:43:53 UTC
[PR] [ISSUE #7466] Added fast failure in adminBrokerThreadPoolQueue (#7466) [rocketmq]
yp969803 opened a new pull request, #7798:
URL: https://github.com/apache/rocketmq/pull/7798
<!-- Please make sure the target branch is right. In most case, the target branch should be `develop`. -->
### Which Issue(s) This PR Fixes
<!-- Please ensure that the related issue has already been created, and [link this pull request to that issue using keywords](<https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword>) to ensure automatic closure. -->
Fixes #7466
### Brief Description
<!-- Write a brief description for your pull request to help the maintainer understand the reasons behind your changes. -->
Added fast failure in adminBrokerThreadPoolQueue
### How Did You Test This Change?
mvn test
<!-- In order to ensure the code quality of Apache RocketMQ, we expect every pull request to have undergone thorough testing. -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #7466] Added fast failure in adminBrokerThreadPoolQueue (#7466) [rocketmq]
Posted by "RongtongJin (via GitHub)" <gi...@apache.org>.
RongtongJin merged PR #7798:
URL: https://github.com/apache/rocketmq/pull/7798
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #7466] Added fast failure in adminBrokerThreadPoolQueue (#7466) [rocketmq]
Posted by "guyinyou (via GitHub)" <gi...@apache.org>.
guyinyou commented on PR #7798:
URL: https://github.com/apache/rocketmq/pull/7798#issuecomment-1956006658
consumerManagerThreadPoolQueue also need fast failure, could you please add it ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #7466] Added fast failure in adminBrokerThreadPoolQueue (#7466) [rocketmq]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #7798:
URL: https://github.com/apache/rocketmq/pull/7798#issuecomment-1915476833
## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/7798?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: `1 lines` in your changes are missing coverage. Please review.
> Comparison is base [(`1242a58`)](https://app.codecov.io/gh/apache/rocketmq/commit/1242a5873df2b20e914ad13e1d46df500df932b9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 0.00% compared to head [(`606c113`)](https://app.codecov.io/gh/apache/rocketmq/pull/7798?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 42.94%.
> Report is 12 commits behind head on develop.
| [Files](https://app.codecov.io/gh/apache/rocketmq/pull/7798?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../java/org/apache/rocketmq/common/BrokerConfig.java](https://app.codecov.io/gh/apache/rocketmq/pull/7798?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vQnJva2VyQ29uZmlnLmphdmE=) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/7798?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## develop #7798 +/- ##
==============================================
+ Coverage 0 42.94% +42.94%
- Complexity 0 9896 +9896
==============================================
Files 0 1190 +1190
Lines 0 85936 +85936
Branches 0 11070 +11070
==============================================
+ Hits 0 36901 +36901
- Misses 0 44460 +44460
- Partials 0 4575 +4575
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/rocketmq/pull/7798?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #7466] Added fast failure in adminBrokerThreadPoolQueue (#7466) [rocketmq]
Posted by "yp969803 (via GitHub)" <gi...@apache.org>.
yp969803 commented on PR #7798:
URL: https://github.com/apache/rocketmq/pull/7798#issuecomment-1915458188
@weihubeats @RongtongJin can you verify this pr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org