[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #3414: Fix jdbc getIndexInfo method and NullPointerException on oracle

[GitBox <gi...@apache.org>]

terrymanu commented on a change in pull request #3414: Fix jdbc getIndexInfo method and NullPointerException on oracle
URL: https://github.com/apache/incubator-shardingsphere/pull/3414#discussion_r340919420
 
 

 ##########
 File path: sharding-core/sharding-core-execute/src/main/java/org/apache/shardingsphere/core/execute/metadata/TableMetaDataLoader.java
 ##########
 @@ -199,7 +199,7 @@ private boolean isTableExist(final Connection connection, final String catalog,
     
     private Collection<String> getLogicIndexes(final Connection connection, final String catalog, final String actualTableName) throws SQLException {
         Collection<String> result = new HashSet<>();
-        try (ResultSet resultSet = connection.getMetaData().getIndexInfo(catalog, catalog, actualTableName, false, false)) {
+        try (ResultSet resultSet = connection.getMetaData().getIndexInfo(catalog, null, actualTableName, false, false)) {
 
 Review comment:
   Any performance issue here if use `null` to instead of catalog name if database is not Oracle? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services