You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Igor Vaynberg (JIRA)" <ji...@apache.org> on 2010/08/26 01:50:24 UTC

[jira] Resolved: (WICKET-2214) Form tag in ModalWindow html code causes nested html forms when ModalWindow is used with panel that contain forms

     [ https://issues.apache.org/jira/browse/WICKET-2214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Igor Vaynberg resolved WICKET-2214.
-----------------------------------

      Assignee: Igor Vaynberg  (was: Matej Knopp)
    Resolution: Invalid

you will not end up with double form tags in your hierarchy. like the javadoc says if you use content panels that contain forms then put the modal itself into a form, which will cause your content forms to be rendered as <divs> since now they will be considered inner forms by wicket.

the markup the modal generates is added under the body element, not where it is added in the markup, so you will never have double form tags.

> Form tag in ModalWindow html code causes nested html forms when ModalWindow is used with panel that contain forms
> -----------------------------------------------------------------------------------------------------------------
>
>                 Key: WICKET-2214
>                 URL: https://issues.apache.org/jira/browse/WICKET-2214
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-extensions
>    Affects Versions: 1.3.5, 1.3.6, 1.4-RC2
>            Reporter: Jor
>            Assignee: Igor Vaynberg
>         Attachments: modal.js.patch
>
>
> There is an extra form tag in modal window html code (modal.js -> Wicket.Window.getMarkup function), it causes problems when ModalWindow is used with panel that contain forms. 
> I haven't found any use for that form tag as it cannot be referenced from java code (it has no wicket id) and it only causes problems by creating nested form tags (outter form from modal html with no wicket id and inner form from panel with wicket id) that some browsers cant handle and its againts W3C html specification.
> I had to replace it with div tag to get my panel working.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.