You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/01/18 14:47:23 UTC

[GitHub] [superset] agatapst edited a comment on pull request #12519: fix(native-filters): Reset column field for removed dataset

agatapst edited a comment on pull request #12519:
URL: https://github.com/apache/superset/pull/12519#issuecomment-762295572


   @junlincc yes, actually @adam-stasiak asked me about that spinner and at first I thought about making separate issue - but if this PR is still not merge, let's improve it in this PR. 
   Below I am attaching screenshot when there is something wrong with filter (i.e. dataset was removed). There is a text instead of spinner. Any suggestions about the copy are welcomed. 🙂 
   <img width="308" alt="error_filter" src="https://user-images.githubusercontent.com/47450693/104929284-f9c65c80-59a3-11eb-99ad-adef2cdb14c7.png">
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org