You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@nutch.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/10/10 22:01:00 UTC
[jira] [Commented] (NUTCH-1678) Remove dependency on org.apache.oro
[ https://issues.apache.org/jira/browse/NUTCH-1678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16645600#comment-16645600 ]
ASF GitHub Bot commented on NUTCH-1678:
---------------------------------------
sebastian-nagel opened a new pull request #390: NUTCH-1678 Remove dependency on org.apache.oro
URL: https://github.com/apache/nutch/pull/390
(cf. NUTCH-2192)
- replace oro with java.util.regex classes in OutlinkExtractor, plugins parse-js and index-more
- extend unit tests of parse-js
- correct pointer to Java regex syntax (instead of "Perl5")
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> Remove dependency on org.apache.oro
> -----------------------------------
>
> Key: NUTCH-1678
> URL: https://issues.apache.org/jira/browse/NUTCH-1678
> Project: Nutch
> Issue Type: Improvement
> Components: parser
> Affects Versions: 2.2
> Reporter: James Sullivan
> Priority: Minor
> Labels: newbie, patch
> Fix For: 2.5
>
> Attachments: 2.x.patch
>
>
> org.apache.oro has been archived for three years and it may be good to remove the dependency as Java has had built in regexes for quite some time now. There don't seem to have been any specific Perl5 functionality needed in the regexes so unless there are specific threading or performance reasons for continuing to use oro it may be time to lose the dependency. Attached patch needs to be checked thoroughly as I am rusty with Java and the unit tests are sparse.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)