[GitHub] [iceberg] jackye1995 commented on a diff in pull request #7417: Views: Fix SQL view representation field name

["jackye1995 (via GitHub)" <gi...@apache.org>]

jackye1995 commented on code in PR #7417:
URL: https://github.com/apache/iceberg/pull/7417#discussion_r1175704309


##########
core/src/main/java/org/apache/iceberg/view/SQLViewRepresentationParser.java:
##########
@@ -35,7 +35,7 @@ class SQLViewRepresentationParser {
   private static final String DEFAULT_CATALOG = "default-catalog";
   private static final String DEFAULT_NAMESPACE = "default-namespace";
   private static final String FIELD_ALIASES = "field-aliases";
-  private static final String FIELD_COMMENTS = "field-comments";
+  private static final String FIELD_DOCS = "field-docs";

Review Comment:
   I guess `docs` would have some consistency with `NestedField` in `Schema` that has a `doc` field. When using SQL we also refer to that as comment, e.g. in Hive
   
   ```
   ALTER TABLE test_change CHANGE a1 a1 INT COMMENT 'this is column a1';
   ```
   
   So I am not too concerned with the naming choice here. 
   
   But even if we go with `docs`, should we use `doc` to be more consistent?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org