You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2020/08/02 15:23:40 UTC
[GitHub] [maven-archetype] acanda opened a new pull request #56: [ARCHETYPE-605] Allow .gitignore file in archetype resources
acanda opened a new pull request #56:
URL: https://github.com/apache/maven-archetype/pull/56
This change allows to create archetypes with files like .gitignore
that are excluded by default. It adds the parameter
"addDefaultExcludes" to the jar mojo. The parameter can be set to
"false" to allow including default files like .gitignore.
The default is "true" (exclude default files) so the plugin behaves
the same as before when the parameter is not set. The parameter is
named and behaves the same as the one in the plugin
"maven-resources-plugin" which usually also needs to be set when
someone wants to include one of the files excluded by default.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-archetype] cchacin commented on pull request #56: [ARCHETYPE-605] Allow .gitignore file in archetype resources
Posted by GitBox <gi...@apache.org>.
cchacin commented on pull request #56:
URL: https://github.com/apache/maven-archetype/pull/56#issuecomment-687659939
Hi @acanda
Sorry, I wasn't clear enough with my comment, my comment is not related to you fix:
I have a project that creates an archetype and is using `v3.1.2` to generate files that contain `.gitignore` and `.gitattributes` files without any issue, but after I bumped the version to `3.2.0` those 2 files were not longer generated and my archetype tests were failing: https://github.com/cchacin/MicroGen/pull/287
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-archetype] cchacin commented on pull request #56: [ARCHETYPE-605] Allow .gitignore file in archetype resources
Posted by GitBox <gi...@apache.org>.
cchacin commented on pull request #56:
URL: https://github.com/apache/maven-archetype/pull/56#issuecomment-685084026
Hi @acanda
Thanks for this PR, I'm wondering why this wasn't failing in `v3.1.2`? I have a build that was passing until the upgrade to `v3.2.0`:
https://github.com/cchacin/MicroGen/pull/287
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-archetype] acanda commented on pull request #56: [ARCHETYPE-605] Allow .gitignore file in archetype resources
Posted by GitBox <gi...@apache.org>.
acanda commented on pull request #56:
URL: https://github.com/apache/maven-archetype/pull/56#issuecomment-690105230
Hi @cchacin
I don't know why it worked for your project with `v3.1.2`, sorry.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-archetype] acanda edited a comment on pull request #56: [ARCHETYPE-605] Allow .gitignore file in archetype resources
Posted by GitBox <gi...@apache.org>.
acanda edited a comment on pull request #56:
URL: https://github.com/apache/maven-archetype/pull/56#issuecomment-690105230
Hi @cchacin
I don't know why it worked for your project with `v3.1.2`, sorry. I don't see any changes bewteen `v3.1.2` and `v3.2.0` that would explain this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-archetype] acanda closed pull request #56: [ARCHETYPE-605] Allow .gitignore file in archetype resources
Posted by GitBox <gi...@apache.org>.
acanda closed pull request #56:
URL: https://github.com/apache/maven-archetype/pull/56
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-archetype] acanda edited a comment on pull request #56: [ARCHETYPE-605] Allow .gitignore file in archetype resources
Posted by GitBox <gi...@apache.org>.
acanda edited a comment on pull request #56:
URL: https://github.com/apache/maven-archetype/pull/56#issuecomment-690105230
Hi @cchacin
I don't know why it worked for your project with `v3.1.2`, sorry. I don't see any changes between `v3.1.2` and `v3.2.0` that would explain this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-archetype] acanda commented on pull request #56: [ARCHETYPE-605] Allow .gitignore file in archetype resources
Posted by GitBox <gi...@apache.org>.
acanda commented on pull request #56:
URL: https://github.com/apache/maven-archetype/pull/56#issuecomment-685665037
Hi @cchacin
I'm not sure what you mean. This PR hasn't been merged so far and is neither part of `v3.1.2` nor `v3.2.0`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-archetype] hboutemy commented on pull request #56: [ARCHETYPE-605] Allow .gitignore file in archetype resources
Posted by GitBox <gi...@apache.org>.
hboutemy commented on pull request #56:
URL: https://github.com/apache/maven-archetype/pull/56#issuecomment-991864908
isn't it fixed by #59 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-archetype] ketoor commented on pull request #56: [ARCHETYPE-605] Allow .gitignore file in archetype resources
Posted by GitBox <gi...@apache.org>.
ketoor commented on pull request #56:
URL: https://github.com/apache/maven-archetype/pull/56#issuecomment-697274147
Hi @cchacin
`v.3.2.0` brings plexus-archiver in [[ARCHETYPE-590] make archetype:jar reproductible](https://github.com/apache/maven-archetype/blob/4c403f7b0148f7dc5fd4e17434943b6530da36ad/maven-archetype-plugin/pom.xml#L77). In our opinion this is the reason, why .gitignore is ignored by maven-archetype-plugin
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-archetype] acanda commented on pull request #56: [ARCHETYPE-605] Allow .gitignore file in archetype resources
Posted by GitBox <gi...@apache.org>.
acanda commented on pull request #56:
URL: https://github.com/apache/maven-archetype/pull/56#issuecomment-991872621
Yes, this is fixed by #59. Someone else submitted the same fix so I'm closing this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org