You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2020/12/23 09:12:06 UTC

[GitHub] [hive] pkumarsinha commented on a change in pull request #1759: HIVE-24502 : Store table level regular expression used during dump fo…

pkumarsinha commented on a change in pull request #1759:
URL: https://github.com/apache/hive/pull/1759#discussion_r547838835



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplDumpTask.java
##########
@@ -607,9 +606,7 @@ private Long incrementalDump(Path dumpRoot, DumpMetaData dmd, Path cmRoot, Hive
     dmd.setDump(DumpType.INCREMENTAL, work.eventFrom, lastReplId, cmRoot, executionId);
     // If repl policy is changed (oldReplScope is set), then pass the current replication policy,
     // so that REPL LOAD would drop the tables which are not included in current policy.
-    if (work.oldReplScope != null) {
-      dmd.setReplScope(work.replScope);
-    }
+    dmd.setReplScope(work.replScope);

Review comment:
       Earlier current ReplicationScope was being passed for load to consume and figure out if  it need to drop extra tables. For which it makes a call to metastore to get all  tables and filter the names by applying the expression in ReplicationScope. With this change, this comparison will happen all the times.  While this will still work, it will introduce a new cost to get all tables and compare against the  load. Can we maintain two  expressions or one expression and one flag to convey if there have  been a change in the  expression or not?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org