You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by ja...@apache.org on 2019/04/13 17:36:16 UTC
[cordova-ios] branch janpio-594_deployment created (now 6e8d114)
This is an automated email from the ASF dual-hosted git repository.
janpio pushed a change to branch janpio-594_deployment
in repository https://gitbox.apache.org/repos/asf/cordova-ios.git.
at 6e8d114 prefix log from simulator to make it recognizable
This branch includes the following new commits:
new 7f51eab remove wrong comment about default emulator
new 558224a add logging about deployment
new fbcbf99 add comment back, minus wrong default
new 9cf91b2 quote target string
new 8266237 log simulator start command
new 6e8d114 prefix log from simulator to make it recognizable
The 6 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[cordova-ios] 05/06: log simulator start command
Posted by ja...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
janpio pushed a commit to branch janpio-594_deployment
in repository https://gitbox.apache.org/repos/asf/cordova-ios.git
commit 82662378896f1cfd1c17286e7b1672c8c3694353
Author: Jan Piotrowski <pi...@gmail.com>
AuthorDate: Sat Apr 13 19:35:44 2019 +0200
log simulator start command
---
bin/templates/scripts/cordova/lib/run.js | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/bin/templates/scripts/cordova/lib/run.js b/bin/templates/scripts/cordova/lib/run.js
index 950176a..1bc8c16 100644
--- a/bin/templates/scripts/cordova/lib/run.js
+++ b/bin/templates/scripts/cordova/lib/run.js
@@ -202,9 +202,13 @@ function startSim (appPath, target) {
return iossimLaunch(appPath, 'com.apple.CoreSimulator.SimDeviceType.' + target, logPath, '--exit');
}
-function iossimLaunch (app_path, devicetypeid, log, exit) {
+function iossimLaunch (appPath, devicetypeid, log, exit) {
var f = path.resolve(path.dirname(require.resolve('ios-sim')), 'bin', 'ios-sim');
- var proc = cp.spawn(f, ['launch', app_path, '--devicetypeid', devicetypeid, '--log', log, exit]);
+
+ var params = ['launch', appPath, '--devicetypeid', devicetypeid, '--log', log, exit];
+ console.log("$ " + f + params.join(' '));
+ var proc = cp.spawn(f, params);
+
proc.stdout.on('data', (data) => {
console.log(data.toString());
});
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[cordova-ios] 02/06: add logging about deployment
Posted by ja...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
janpio pushed a commit to branch janpio-594_deployment
in repository https://gitbox.apache.org/repos/asf/cordova-ios.git
commit 558224ac43627af1a1624023dc104180583be8a3
Author: Jan Piotrowski <pi...@gmail.com>
AuthorDate: Sat Apr 13 19:34:52 2019 +0200
add logging about deployment
---
bin/templates/scripts/cordova/lib/run.js | 2 ++
1 file changed, 2 insertions(+)
diff --git a/bin/templates/scripts/cordova/lib/run.js b/bin/templates/scripts/cordova/lib/run.js
index 7fe271e..39d097c 100644
--- a/bin/templates/scripts/cordova/lib/run.js
+++ b/bin/templates/scripts/cordova/lib/run.js
@@ -159,6 +159,7 @@ function checkDeviceConnected () {
* @return {Promise} Resolves when deploy succeeds otherwise rejects
*/
function deployToDevice (appPath, target, extraArgs) {
+ events.emit('log', 'Deploying to device');
// Deploying to device...
if (target) {
return superspawn.spawn('ios-deploy', ['--justlaunch', '-d', '-b', appPath, '-i', target].concat(extraArgs), { printCommand: true, stdio: 'inherit' });
@@ -174,6 +175,7 @@ function deployToDevice (appPath, target, extraArgs) {
* @return {Promise} Resolves when deploy succeeds otherwise rejects
*/
function deployToSim (appPath, target) {
+ events.emit('log', 'Deploying to simulator');
if (!target) {
return require('./list-emulator-images').run()
.then(function (emulators) {
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[cordova-ios] 04/06: quote target string
Posted by ja...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
janpio pushed a commit to branch janpio-594_deployment
in repository https://gitbox.apache.org/repos/asf/cordova-ios.git
commit 9cf91b29de36b565ac3972f82927ab556345b5c7
Author: Jan Piotrowski <pi...@gmail.com>
AuthorDate: Sat Apr 13 19:35:16 2019 +0200
quote target string
---
bin/templates/scripts/cordova/lib/run.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/bin/templates/scripts/cordova/lib/run.js b/bin/templates/scripts/cordova/lib/run.js
index c37cebf..950176a 100644
--- a/bin/templates/scripts/cordova/lib/run.js
+++ b/bin/templates/scripts/cordova/lib/run.js
@@ -188,7 +188,7 @@ function deployToSim (appPath, target) {
target = emulator;
}
});
- events.emit('log', 'No target specified for emulator. Deploying to ' + target + ' simulator');
+ events.emit('log', 'No target specified for emulator. Deploying to "' + target + '" simulator');
return startSim(appPath, target);
});
} else {
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[cordova-ios] 03/06: add comment back, minus wrong default
Posted by ja...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
janpio pushed a commit to branch janpio-594_deployment
in repository https://gitbox.apache.org/repos/asf/cordova-ios.git
commit fbcbf99c397161cdd82e8faf9ddd4a29678a8c97
Author: Jan Piotrowski <pi...@gmail.com>
AuthorDate: Sat Apr 13 19:35:06 2019 +0200
add comment back, minus wrong default
---
bin/templates/scripts/cordova/lib/run.js | 1 +
1 file changed, 1 insertion(+)
diff --git a/bin/templates/scripts/cordova/lib/run.js b/bin/templates/scripts/cordova/lib/run.js
index 39d097c..c37cebf 100644
--- a/bin/templates/scripts/cordova/lib/run.js
+++ b/bin/templates/scripts/cordova/lib/run.js
@@ -177,6 +177,7 @@ function deployToDevice (appPath, target, extraArgs) {
function deployToSim (appPath, target) {
events.emit('log', 'Deploying to simulator');
if (!target) {
+ // Select target device for emulator
return require('./list-emulator-images').run()
.then(function (emulators) {
if (emulators.length > 0) {
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[cordova-ios] 01/06: remove wrong comment about default emulator
Posted by ja...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
janpio pushed a commit to branch janpio-594_deployment
in repository https://gitbox.apache.org/repos/asf/cordova-ios.git
commit 7f51eab0d6b14141c534d206b993fcd68468c5a8
Author: Jan Piotrowski <pi...@gmail.com>
AuthorDate: Sat Apr 13 19:34:19 2019 +0200
remove wrong comment about default emulator
---
bin/templates/scripts/cordova/lib/run.js | 1 -
1 file changed, 1 deletion(-)
diff --git a/bin/templates/scripts/cordova/lib/run.js b/bin/templates/scripts/cordova/lib/run.js
index f9e5761..7fe271e 100644
--- a/bin/templates/scripts/cordova/lib/run.js
+++ b/bin/templates/scripts/cordova/lib/run.js
@@ -174,7 +174,6 @@ function deployToDevice (appPath, target, extraArgs) {
* @return {Promise} Resolves when deploy succeeds otherwise rejects
*/
function deployToSim (appPath, target) {
- // Select target device for emulator. Default is 'iPhone-6'
if (!target) {
return require('./list-emulator-images').run()
.then(function (emulators) {
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[cordova-ios] 06/06: prefix log from simulator to make it
recognizable
Posted by ja...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
janpio pushed a commit to branch janpio-594_deployment
in repository https://gitbox.apache.org/repos/asf/cordova-ios.git
commit 6e8d114050595fbdceb3357ce3d2f32dde9bb9bc
Author: Jan Piotrowski <pi...@gmail.com>
AuthorDate: Sat Apr 13 19:36:02 2019 +0200
prefix log from simulator to make it recognizable
---
bin/templates/scripts/cordova/lib/run.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/bin/templates/scripts/cordova/lib/run.js b/bin/templates/scripts/cordova/lib/run.js
index 1bc8c16..792e0bf 100644
--- a/bin/templates/scripts/cordova/lib/run.js
+++ b/bin/templates/scripts/cordova/lib/run.js
@@ -210,7 +210,7 @@ function iossimLaunch (appPath, devicetypeid, log, exit) {
var proc = cp.spawn(f, params);
proc.stdout.on('data', (data) => {
- console.log(data.toString());
+ console.log("Data from simulator: " + data.toString());
});
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org