You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Jothi Padmanabhan (JIRA)" <ji...@apache.org> on 2009/04/21 06:09:47 UTC
[jira] Created: (HADOOP-5709) Remove the additional synchronization
in MapTask.MapOutputBuffer.Buffer.write
Remove the additional synchronization in MapTask.MapOutputBuffer.Buffer.write
-----------------------------------------------------------------------------
Key: HADOOP-5709
URL: https://issues.apache.org/jira/browse/HADOOP-5709
Project: Hadoop Core
Issue Type: Bug
Reporter: Jothi Padmanabhan
Assignee: Jothi Padmanabhan
Priority: Minor
As part of HADOOP-5661, a synchronization was introduced to address a false positive warning. While this does not have any impact on functionality and possibly on performance either, it would be better to remove this synchronization and just suppress the warning from a code maintenance point of view.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5709) Remove the additional synchronization
in MapTask.MapOutputBuffer.Buffer.write
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5709?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Douglas updated HADOOP-5709:
----------------------------------
Resolution: Fixed
Fix Version/s: 0.21.0
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
+1
I committed this. Thanks, Jothi
> Remove the additional synchronization in MapTask.MapOutputBuffer.Buffer.write
> -----------------------------------------------------------------------------
>
> Key: HADOOP-5709
> URL: https://issues.apache.org/jira/browse/HADOOP-5709
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Jothi Padmanabhan
> Assignee: Jothi Padmanabhan
> Priority: Minor
> Fix For: 0.21.0
>
> Attachments: hadoop-5709.patch
>
>
> As part of HADOOP-5661, a synchronization was introduced to address a false positive warning. While this does not have any impact on functionality and possibly on performance either, it would be better to remove this synchronization and just suppress the warning from a code maintenance point of view.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5709) Remove the additional synchronization
in MapTask.MapOutputBuffer.Buffer.write
Posted by "Jothi Padmanabhan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5709?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jothi Padmanabhan updated HADOOP-5709:
--------------------------------------
Status: Patch Available (was: Open)
> Remove the additional synchronization in MapTask.MapOutputBuffer.Buffer.write
> -----------------------------------------------------------------------------
>
> Key: HADOOP-5709
> URL: https://issues.apache.org/jira/browse/HADOOP-5709
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Jothi Padmanabhan
> Assignee: Jothi Padmanabhan
> Priority: Minor
> Attachments: hadoop-5709.patch
>
>
> As part of HADOOP-5661, a synchronization was introduced to address a false positive warning. While this does not have any impact on functionality and possibly on performance either, it would be better to remove this synchronization and just suppress the warning from a code maintenance point of view.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5709) Remove the additional
synchronization in MapTask.MapOutputBuffer.Buffer.write
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12702760#action_12702760 ]
Hudson commented on HADOOP-5709:
--------------------------------
Integrated in Hadoop-trunk #817 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/817/])
. Remove redundant synchronization added in HADOOP-5661. Contributed by Jothi Padmanabhan.
> Remove the additional synchronization in MapTask.MapOutputBuffer.Buffer.write
> -----------------------------------------------------------------------------
>
> Key: HADOOP-5709
> URL: https://issues.apache.org/jira/browse/HADOOP-5709
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Jothi Padmanabhan
> Assignee: Jothi Padmanabhan
> Priority: Minor
> Fix For: 0.21.0
>
> Attachments: hadoop-5709.patch
>
>
> As part of HADOOP-5661, a synchronization was introduced to address a false positive warning. While this does not have any impact on functionality and possibly on performance either, it would be better to remove this synchronization and just suppress the warning from a code maintenance point of view.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5709) Remove the additional
synchronization in MapTask.MapOutputBuffer.Buffer.write
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12701941#action_12701941 ]
Hadoop QA commented on HADOOP-5709:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12406008/hadoop-5709.patch
against trunk revision 767699.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 Eclipse classpath. The patch retains Eclipse classpath integrity.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/232/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/232/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/232/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/232/console
This message is automatically generated.
> Remove the additional synchronization in MapTask.MapOutputBuffer.Buffer.write
> -----------------------------------------------------------------------------
>
> Key: HADOOP-5709
> URL: https://issues.apache.org/jira/browse/HADOOP-5709
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Jothi Padmanabhan
> Assignee: Jothi Padmanabhan
> Priority: Minor
> Attachments: hadoop-5709.patch
>
>
> As part of HADOOP-5661, a synchronization was introduced to address a false positive warning. While this does not have any impact on functionality and possibly on performance either, it would be better to remove this synchronization and just suppress the warning from a code maintenance point of view.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5709) Remove the additional synchronization
in MapTask.MapOutputBuffer.Buffer.write
Posted by "Jothi Padmanabhan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5709?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jothi Padmanabhan updated HADOOP-5709:
--------------------------------------
Attachment: hadoop-5709.patch
Straight forward patch
> Remove the additional synchronization in MapTask.MapOutputBuffer.Buffer.write
> -----------------------------------------------------------------------------
>
> Key: HADOOP-5709
> URL: https://issues.apache.org/jira/browse/HADOOP-5709
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Jothi Padmanabhan
> Assignee: Jothi Padmanabhan
> Priority: Minor
> Attachments: hadoop-5709.patch
>
>
> As part of HADOOP-5661, a synchronization was introduced to address a false positive warning. While this does not have any impact on functionality and possibly on performance either, it would be better to remove this synchronization and just suppress the warning from a code maintenance point of view.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.