You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/01/23 08:12:37 UTC
[GitHub] [arrow] jorgecarleitao opened a new pull request #9298: Aligned Date DataType with specification.
jorgecarleitao opened a new pull request #9298:
URL: https://github.com/apache/arrow/pull/9298
The arrow spec states that `Date32` represents a date in number of days, and `Date64` represents a date in milliseconds.
However, our current implementation allows `Date32(Milliseconds)` and `Date64(Days)`.
This PR fixes this by removing the `DateUnit` altogether, i.e. `Date32(_) -> Date32` and `Date64(_) -> Date64`.
Please note that this has a major backward incompatibility to all code that uses this datatype. Unfortunately, there is no way to solve this out of spec without an incompatible change. :(
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #9298: ARROW-11355: [Rust] Aligned Date DataType with specification.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9298:
URL: https://github.com/apache/arrow/pull/9298#issuecomment-765887237
https://issues.apache.org/jira/browse/ARROW-11355
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #9298: Aligned Date DataType with specification.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9298:
URL: https://github.com/apache/arrow/pull/9298#issuecomment-765887029
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW
Then could you also rename pull request title in the following format?
ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorgecarleitao closed pull request #9298: ARROW-11355: [Rust] Aligned Date DataType with specification.
Posted by GitBox <gi...@apache.org>.
jorgecarleitao closed pull request #9298:
URL: https://github.com/apache/arrow/pull/9298
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] codecov-io edited a comment on pull request #9298: ARROW-11355: [Rust] Aligned Date DataType with specification.
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9298:
URL: https://github.com/apache/arrow/pull/9298#issuecomment-765890484
# [Codecov](https://codecov.io/gh/apache/arrow/pull/9298?src=pr&el=h1) Report
> Merging [#9298](https://codecov.io/gh/apache/arrow/pull/9298?src=pr&el=desc) (7da2e92) into [master](https://codecov.io/gh/apache/arrow/commit/437c8c944acb3479b76804f041f5f8cbce309fa7?el=desc) (437c8c9) will **decrease** coverage by `0.00%`.
> The diff coverage is `61.24%`.
[](https://codecov.io/gh/apache/arrow/pull/9298?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9298 +/- ##
==========================================
- Coverage 81.88% 81.88% -0.01%
==========================================
Files 215 215
Lines 52988 52974 -14
==========================================
- Hits 43391 43378 -13
+ Misses 9597 9596 -1
```
| [Impacted Files](https://codecov.io/gh/apache/arrow/pull/9298?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [rust/arrow/src/array/builder.rs](https://codecov.io/gh/apache/arrow/pull/9298/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvYnVpbGRlci5ycw==) | `85.10% <0.00%> (ø)` | |
| [rust/arrow/src/array/equal/mod.rs](https://codecov.io/gh/apache/arrow/pull/9298/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvZXF1YWwvbW9kLnJz) | `92.92% <0.00%> (ø)` | |
| [rust/arrow/src/array/ord.rs](https://codecov.io/gh/apache/arrow/pull/9298/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvb3JkLnJz) | `61.42% <0.00%> (ø)` | |
| [rust/arrow/src/array/transform/mod.rs](https://codecov.io/gh/apache/arrow/pull/9298/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvdHJhbnNmb3JtL21vZC5ycw==) | `92.92% <0.00%> (ø)` | |
| [rust/arrow/src/compute/kernels/sort.rs](https://codecov.io/gh/apache/arrow/pull/9298/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvY29tcHV0ZS9rZXJuZWxzL3NvcnQucnM=) | `93.56% <0.00%> (ø)` | |
| [rust/arrow/src/csv/writer.rs](https://codecov.io/gh/apache/arrow/pull/9298/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvY3N2L3dyaXRlci5ycw==) | `78.82% <0.00%> (ø)` | |
| [rust/arrow/src/ipc/reader.rs](https://codecov.io/gh/apache/arrow/pull/9298/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvaXBjL3JlYWRlci5ycw==) | `84.56% <ø> (ø)` | |
| [rust/benchmarks/src/bin/tpch.rs](https://codecov.io/gh/apache/arrow/pull/9298/diff?src=pr&el=tree#diff-cnVzdC9iZW5jaG1hcmtzL3NyYy9iaW4vdHBjaC5ycw==) | `6.97% <0.00%> (ø)` | |
| [rust/datafusion/src/scalar.rs](https://codecov.io/gh/apache/arrow/pull/9298/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9zY2FsYXIucnM=) | `58.96% <0.00%> (ø)` | |
| [rust/integration-testing/src/lib.rs](https://codecov.io/gh/apache/arrow/pull/9298/diff?src=pr&el=tree#diff-cnVzdC9pbnRlZ3JhdGlvbi10ZXN0aW5nL3NyYy9saWIucnM=) | `0.00% <ø> (ø)` | |
| ... and [19 more](https://codecov.io/gh/apache/arrow/pull/9298/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/9298?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/9298?src=pr&el=footer). Last update [437c8c9...7da2e92](https://codecov.io/gh/apache/arrow/pull/9298?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb commented on pull request #9298: ARROW-11355: [Rust] Aligned Date DataType with specification.
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #9298:
URL: https://github.com/apache/arrow/pull/9298#issuecomment-768643558
Any last comments before we merge this one?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] removed a comment on pull request #9298: ARROW-11355: [Rust] Aligned Date DataType with specification.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] removed a comment on pull request #9298:
URL: https://github.com/apache/arrow/pull/9298#issuecomment-765887029
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW
Then could you also rename pull request title in the following format?
ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] maxburke commented on pull request #9298: ARROW-11355: [Rust] Aligned Date DataType with specification.
Posted by GitBox <gi...@apache.org>.
maxburke commented on pull request #9298:
URL: https://github.com/apache/arrow/pull/9298#issuecomment-766135476
@alamb for what it's worth we don't use the Date32 or Date64 types, so we're good with this 👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] codecov-io commented on pull request #9298: ARROW-11355: [Rust] Aligned Date DataType with specification.
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #9298:
URL: https://github.com/apache/arrow/pull/9298#issuecomment-765890484
# [Codecov](https://codecov.io/gh/apache/arrow/pull/9298?src=pr&el=h1) Report
> Merging [#9298](https://codecov.io/gh/apache/arrow/pull/9298?src=pr&el=desc) (f4d9ca2) into [master](https://codecov.io/gh/apache/arrow/commit/251ecac002d4b229cc1322fb75354cb11fc75868?el=desc) (251ecac) will **decrease** coverage by `0.00%`.
> The diff coverage is `61.83%`.
[](https://codecov.io/gh/apache/arrow/pull/9298?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9298 +/- ##
==========================================
- Coverage 81.87% 81.86% -0.01%
==========================================
Files 215 215
Lines 53013 52999 -14
==========================================
- Hits 43403 43389 -14
Misses 9610 9610
```
| [Impacted Files](https://codecov.io/gh/apache/arrow/pull/9298?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [rust/arrow/src/array/builder.rs](https://codecov.io/gh/apache/arrow/pull/9298/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvYnVpbGRlci5ycw==) | `85.10% <0.00%> (ø)` | |
| [rust/arrow/src/array/equal/mod.rs](https://codecov.io/gh/apache/arrow/pull/9298/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvZXF1YWwvbW9kLnJz) | `92.92% <0.00%> (ø)` | |
| [rust/arrow/src/array/ord.rs](https://codecov.io/gh/apache/arrow/pull/9298/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvb3JkLnJz) | `61.42% <0.00%> (ø)` | |
| [rust/arrow/src/array/transform/mod.rs](https://codecov.io/gh/apache/arrow/pull/9298/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvdHJhbnNmb3JtL21vZC5ycw==) | `92.92% <0.00%> (ø)` | |
| [rust/arrow/src/compute/kernels/sort.rs](https://codecov.io/gh/apache/arrow/pull/9298/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvY29tcHV0ZS9rZXJuZWxzL3NvcnQucnM=) | `93.56% <0.00%> (ø)` | |
| [rust/arrow/src/csv/writer.rs](https://codecov.io/gh/apache/arrow/pull/9298/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvY3N2L3dyaXRlci5ycw==) | `78.82% <0.00%> (ø)` | |
| [rust/arrow/src/ipc/reader.rs](https://codecov.io/gh/apache/arrow/pull/9298/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvaXBjL3JlYWRlci5ycw==) | `84.56% <ø> (ø)` | |
| [rust/benchmarks/src/bin/tpch.rs](https://codecov.io/gh/apache/arrow/pull/9298/diff?src=pr&el=tree#diff-cnVzdC9iZW5jaG1hcmtzL3NyYy9iaW4vdHBjaC5ycw==) | `6.97% <0.00%> (ø)` | |
| [rust/datafusion/src/scalar.rs](https://codecov.io/gh/apache/arrow/pull/9298/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9zY2FsYXIucnM=) | `58.96% <0.00%> (ø)` | |
| [rust/integration-testing/src/lib.rs](https://codecov.io/gh/apache/arrow/pull/9298/diff?src=pr&el=tree#diff-cnVzdC9pbnRlZ3JhdGlvbi10ZXN0aW5nL3NyYy9saWIucnM=) | `0.00% <ø> (ø)` | |
| ... and [18 more](https://codecov.io/gh/apache/arrow/pull/9298/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/9298?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/9298?src=pr&el=footer). Last update [b44a4ad...f4d9ca2](https://codecov.io/gh/apache/arrow/pull/9298?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb commented on pull request #9298: ARROW-11355: [Rust] Aligned Date DataType with specification.
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #9298:
URL: https://github.com/apache/arrow/pull/9298#issuecomment-765910208
I wonder how this would affect @maxburke and his usecase overly negatively
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] codecov-io edited a comment on pull request #9298: ARROW-11355: [Rust] Aligned Date DataType with specification.
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9298:
URL: https://github.com/apache/arrow/pull/9298#issuecomment-765890484
# [Codecov](https://codecov.io/gh/apache/arrow/pull/9298?src=pr&el=h1) Report
> Merging [#9298](https://codecov.io/gh/apache/arrow/pull/9298?src=pr&el=desc) (7da2e92) into [master](https://codecov.io/gh/apache/arrow/commit/437c8c944acb3479b76804f041f5f8cbce309fa7?el=desc) (437c8c9) will **decrease** coverage by `0.00%`.
> The diff coverage is `61.24%`.
[](https://codecov.io/gh/apache/arrow/pull/9298?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9298 +/- ##
==========================================
- Coverage 81.88% 81.88% -0.01%
==========================================
Files 215 215
Lines 52988 52974 -14
==========================================
- Hits 43391 43378 -13
+ Misses 9597 9596 -1
```
| [Impacted Files](https://codecov.io/gh/apache/arrow/pull/9298?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [rust/arrow/src/array/builder.rs](https://codecov.io/gh/apache/arrow/pull/9298/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvYnVpbGRlci5ycw==) | `85.10% <0.00%> (ø)` | |
| [rust/arrow/src/array/equal/mod.rs](https://codecov.io/gh/apache/arrow/pull/9298/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvZXF1YWwvbW9kLnJz) | `92.92% <0.00%> (ø)` | |
| [rust/arrow/src/array/ord.rs](https://codecov.io/gh/apache/arrow/pull/9298/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvb3JkLnJz) | `61.42% <0.00%> (ø)` | |
| [rust/arrow/src/array/transform/mod.rs](https://codecov.io/gh/apache/arrow/pull/9298/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvdHJhbnNmb3JtL21vZC5ycw==) | `92.92% <0.00%> (ø)` | |
| [rust/arrow/src/compute/kernels/sort.rs](https://codecov.io/gh/apache/arrow/pull/9298/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvY29tcHV0ZS9rZXJuZWxzL3NvcnQucnM=) | `93.56% <0.00%> (ø)` | |
| [rust/arrow/src/csv/writer.rs](https://codecov.io/gh/apache/arrow/pull/9298/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvY3N2L3dyaXRlci5ycw==) | `78.82% <0.00%> (ø)` | |
| [rust/arrow/src/ipc/reader.rs](https://codecov.io/gh/apache/arrow/pull/9298/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvaXBjL3JlYWRlci5ycw==) | `84.56% <ø> (ø)` | |
| [rust/benchmarks/src/bin/tpch.rs](https://codecov.io/gh/apache/arrow/pull/9298/diff?src=pr&el=tree#diff-cnVzdC9iZW5jaG1hcmtzL3NyYy9iaW4vdHBjaC5ycw==) | `6.97% <0.00%> (ø)` | |
| [rust/datafusion/src/scalar.rs](https://codecov.io/gh/apache/arrow/pull/9298/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9zY2FsYXIucnM=) | `58.96% <0.00%> (ø)` | |
| [rust/integration-testing/src/lib.rs](https://codecov.io/gh/apache/arrow/pull/9298/diff?src=pr&el=tree#diff-cnVzdC9pbnRlZ3JhdGlvbi10ZXN0aW5nL3NyYy9saWIucnM=) | `0.00% <ø> (ø)` | |
| ... and [19 more](https://codecov.io/gh/apache/arrow/pull/9298/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/9298?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/9298?src=pr&el=footer). Last update [437c8c9...7da2e92](https://codecov.io/gh/apache/arrow/pull/9298?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org