You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Farhan Khan <fa...@freestoneinfotech.com> on 2022/02/01 05:11:26 UTC

Review Request 73824: ATLAS-4544 : Disallow continuous clicking of refresh button for Basic search.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73824/
-----------------------------------------------------------

Review request for atlas and Prasad Pawar.


Bugs: ATLAS-4544
    https://issues.apache.org/jira/browse/ATLAS-4544


Repository: atlas


Description
-------

It is noticed that user is able to continuously click the refresh button, which leads to "Invalid expression" error messages occurring. It would be better to block this scenario by adding a delay between each click.


Diffs
-----

  dashboardv2/public/js/views/search/SearchLayoutView.js 714e47bf8 
  dashboardv3/public/js/templates/search/SearchDefaultLayoutView_tmpl.html cbac4eb1f 
  dashboardv3/public/js/views/search/SearchDefaultLayoutView.js 23dc560e6 


Diff: https://reviews.apache.org/r/73824/diff/1/


Testing
-------

Implemented and tested on both UI's.


Thanks,

Farhan Khan

Re: Review Request 73824: ATLAS-4544 : Disallow continuous clicking of refresh button for Basic search.

Posted by Prasad Pawar <pr...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73824/#review224010
-----------------------------------------------------------


Ship it!




Ship It!

- Prasad Pawar


On Feb. 1, 2022, 5:11 a.m., Farhan Khan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73824/
> -----------------------------------------------------------
> 
> (Updated Feb. 1, 2022, 5:11 a.m.)
> 
> 
> Review request for atlas and Prasad Pawar.
> 
> 
> Bugs: ATLAS-4544
>     https://issues.apache.org/jira/browse/ATLAS-4544
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> It is noticed that user is able to continuously click the refresh button, which leads to "Invalid expression" error messages occurring. It would be better to block this scenario by adding a delay between each click.
> 
> 
> Diffs
> -----
> 
>   dashboardv2/public/js/views/search/SearchLayoutView.js 714e47bf8 
>   dashboardv3/public/js/templates/search/SearchDefaultLayoutView_tmpl.html cbac4eb1f 
>   dashboardv3/public/js/views/search/SearchDefaultLayoutView.js 23dc560e6 
> 
> 
> Diff: https://reviews.apache.org/r/73824/diff/1/
> 
> 
> Testing
> -------
> 
> Implemented and tested on both UI's.
> 
> 
> Thanks,
> 
> Farhan Khan
> 
>