You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by sebb <se...@gmail.com> on 2009/08/03 17:57:27 UTC
[JEXL] Handling of deprecated items in 2.0
There are some classes and methods which are now deprecated in 2.0.
However, the deprecated items are still used by much of the test code.
Seems to me that the test cases ought not to use deprecated classes
and methods unless the test is actually for testing the item.
Any views on this?
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [JEXL] Handling of deprecated items in 2.0
Posted by Henrib <hb...@gmail.com>.
Rahul Akolkar wrote:
>
> On Mon, Aug 3, 2009 at 1:30 PM, Henrib<hb...@gmail.com> wrote:
>>
>>
>> The tests use the ExpressionFactory & ScriptFactory a lot indeed; using a
>> static JexlEngine in those test classes should be equivalent.
>> I can refactor these if this helps and I'm not stepping on anyone's toes.
> <snip/>
>
> That'd be great.
>
> -Rahul
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
>
Created JEXL-68 & patch.
--
View this message in context: http://www.nabble.com/-JEXL--Handling-of-deprecated-items-in-2.0-tp24793279p24798153.html
Sent from the Commons - Dev mailing list archive at Nabble.com.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [JEXL] Handling of deprecated items in 2.0
Posted by Rahul Akolkar <ra...@gmail.com>.
On Mon, Aug 3, 2009 at 1:30 PM, Henrib<hb...@gmail.com> wrote:
>
>
> The tests use the ExpressionFactory & ScriptFactory a lot indeed; using a
> static JexlEngine in those test classes should be equivalent.
> I can refactor these if this helps and I'm not stepping on anyone's toes.
<snip/>
That'd be great.
-Rahul
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [JEXL] Handling of deprecated items in 2.0
Posted by Henrib <hb...@gmail.com>.
The tests use the ExpressionFactory & ScriptFactory a lot indeed; using a
static JexlEngine in those test classes should be equivalent.
I can refactor these if this helps and I'm not stepping on anyone's toes.
--
View this message in context: http://www.nabble.com/-JEXL--Handling-of-deprecated-items-in-2.0-tp24793279p24794864.html
Sent from the Commons - Dev mailing list archive at Nabble.com.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [JEXL] Handling of deprecated items in 2.0
Posted by Rahul Akolkar <ra...@gmail.com>.
On Tue, Aug 4, 2009 at 11:42 AM, sebb<se...@gmail.com> wrote:
> On 04/08/2009, sebb <se...@gmail.com> wrote:
>> On 03/08/2009, Rahul Akolkar <ra...@gmail.com> wrote:
>> > On Mon, Aug 3, 2009 at 11:57 AM, sebb<se...@gmail.com> wrote:
>> > > There are some classes and methods which are now deprecated in 2.0.
>> > >
>> > > However, the deprecated items are still used by much of the test code.
>> > >
>> > > Seems to me that the test cases ought not to use deprecated classes
>> > > and methods unless the test is actually for testing the item.
>> > >
>> > > Any views on this?
>> > >
>> >
>> > <snip/>
>> >
>> > Sure makes sense to remove usage in tests. One step further, given
>> > that a major release is one of the few occassions we can actually do
>> > this, we can look at removing some deprecated methods and classes
>> > altogether if it helps clean things up and gets us a cleaner,
>> > unambiguous API as a result.
>>
>>
>> +1
>
> There are now no references to the deprecated classes and methods in
> any of the code.
>
> I removed the deprecated stuff from the workspace, and "mvn clean
> test" works OK.
>
> So I think we could consider dropping the two classes:
>
> ExpressionFactory
> ScriptFactory
>
<snip/>
Yes, I'm OK with this since it helps the API -- with a prominent note
in RELEASE-NOTES.txt (which we should prepare towards to 2.0 anyway).
> and removing the methods:
>
> JexlEngine.getDefault()
<snap/>
JexlEngine is @since 2.0 so once the two classes above disappear, this
serves no useful purpose and can be promptly removed.
> and
> Info.getTemplateName()
>
<snip/>
Yup, this can go as well.
-Rahul
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [JEXL] Handling of deprecated items in 2.0
Posted by sebb <se...@gmail.com>.
On 04/08/2009, sebb <se...@gmail.com> wrote:
> On 03/08/2009, Rahul Akolkar <ra...@gmail.com> wrote:
> > On Mon, Aug 3, 2009 at 11:57 AM, sebb<se...@gmail.com> wrote:
> > > There are some classes and methods which are now deprecated in 2.0.
> > >
> > > However, the deprecated items are still used by much of the test code.
> > >
> > > Seems to me that the test cases ought not to use deprecated classes
> > > and methods unless the test is actually for testing the item.
> > >
> > > Any views on this?
> > >
> >
> > <snip/>
> >
> > Sure makes sense to remove usage in tests. One step further, given
> > that a major release is one of the few occassions we can actually do
> > this, we can look at removing some deprecated methods and classes
> > altogether if it helps clean things up and gets us a cleaner,
> > unambiguous API as a result.
>
>
> +1
There are now no references to the deprecated classes and methods in
any of the code.
I removed the deprecated stuff from the workspace, and "mvn clean
test" works OK.
So I think we could consider dropping the two classes:
ExpressionFactory
ScriptFactory
and removing the methods:
JexlEngine.getDefault()
and
Info.getTemplateName()
>
> >
> > -Rahul
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > For additional commands, e-mail: dev-help@commons.apache.org
> >
> >
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [JEXL] Handling of deprecated items in 2.0
Posted by sebb <se...@gmail.com>.
On 03/08/2009, Rahul Akolkar <ra...@gmail.com> wrote:
> On Mon, Aug 3, 2009 at 11:57 AM, sebb<se...@gmail.com> wrote:
> > There are some classes and methods which are now deprecated in 2.0.
> >
> > However, the deprecated items are still used by much of the test code.
> >
> > Seems to me that the test cases ought not to use deprecated classes
> > and methods unless the test is actually for testing the item.
> >
> > Any views on this?
> >
>
> <snip/>
>
> Sure makes sense to remove usage in tests. One step further, given
> that a major release is one of the few occassions we can actually do
> this, we can look at removing some deprecated methods and classes
> altogether if it helps clean things up and gets us a cleaner,
> unambiguous API as a result.
+1
>
> -Rahul
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [JEXL] Handling of deprecated items in 2.0
Posted by Rahul Akolkar <ra...@gmail.com>.
On Mon, Aug 3, 2009 at 11:57 AM, sebb<se...@gmail.com> wrote:
> There are some classes and methods which are now deprecated in 2.0.
>
> However, the deprecated items are still used by much of the test code.
>
> Seems to me that the test cases ought not to use deprecated classes
> and methods unless the test is actually for testing the item.
>
> Any views on this?
>
<snip/>
Sure makes sense to remove usage in tests. One step further, given
that a major release is one of the few occassions we can actually do
this, we can look at removing some deprecated methods and classes
altogether if it helps clean things up and gets us a cleaner,
unambiguous API as a result.
-Rahul
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org