You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Abraham Elmahrek <ab...@cloudera.com> on 2015/02/19 00:13:29 UTC
Review Request 31163: SQOOP-1978: SQOOP-1978: Sqoop2: Command line
support
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31163/
-----------------------------------------------------------
Review request for Sqoop and Jarek Cecho.
Bugs: SQOOP-1978
https://issues.apache.org/jira/browse/SQOOP-1978
Repository: sqoop-sqoop2
Description
-------
commit 3a863cec531aa30880fca866794a397729f2b69f
Author: Abraham Elmahrek <ab...@apache.org>
Date: Fri Feb 13 09:46:41 2015 -0800
SQOOP-1978: Sqoop2: Command line support
:100644 100644 1ef2418... a16ba5b... M shell/src/main/java/org/apache/sqoop/shell/CreateCommand.java
:000000 100644 0000000... 10d06b5... A shell/src/main/java/org/apache/sqoop/shell/CreateRoleFunction.java
:100644 100644 26e2bf6... 4b66505... M shell/src/main/java/org/apache/sqoop/shell/DeleteCommand.java
:000000 100644 0000000... d3c9f4d... A shell/src/main/java/org/apache/sqoop/shell/DeleteRoleFunction.java
:000000 100644 0000000... b4b77b0... A shell/src/main/java/org/apache/sqoop/shell/GrantCommand.java
:000000 100644 0000000... a473628... A shell/src/main/java/org/apache/sqoop/shell/GrantPrivilegeFunction.java
:000000 100644 0000000... 9dfe90f... A shell/src/main/java/org/apache/sqoop/shell/GrantRoleFunction.java
:000000 100644 0000000... 0cb30e4... A shell/src/main/java/org/apache/sqoop/shell/RevokeCommand.java
:000000 100644 0000000... 16c6bf9... A shell/src/main/java/org/apache/sqoop/shell/RevokePrivilegeFunction.java
:000000 100644 0000000... cf69faa... A shell/src/main/java/org/apache/sqoop/shell/RevokeRoleFunction.java
:100644 100644 cbd34f5... fdb7a5b... M shell/src/main/java/org/apache/sqoop/shell/SqoopCommand.java
:100644 100644 2e87965... e319839... M shell/src/main/java/org/apache/sqoop/shell/SqoopShell.java
:100644 100644 46f2b7f... 8133bd6... M shell/src/main/java/org/apache/sqoop/shell/core/Constants.java
:100644 100644 9c88235... ca64dae... M shell/src/main/resources/shell-resource.properties
Diffs
-----
shell/pom.xml 0288d0d
shell/src/main/java/org/apache/sqoop/shell/CreateCommand.java 1ef2418
shell/src/main/java/org/apache/sqoop/shell/CreateRoleFunction.java PRE-CREATION
shell/src/main/java/org/apache/sqoop/shell/DeleteCommand.java 26e2bf6
shell/src/main/java/org/apache/sqoop/shell/DeleteRoleFunction.java PRE-CREATION
shell/src/main/java/org/apache/sqoop/shell/GrantCommand.java PRE-CREATION
shell/src/main/java/org/apache/sqoop/shell/GrantPrivilegeFunction.java PRE-CREATION
shell/src/main/java/org/apache/sqoop/shell/GrantRoleFunction.java PRE-CREATION
shell/src/main/java/org/apache/sqoop/shell/RevokeCommand.java PRE-CREATION
shell/src/main/java/org/apache/sqoop/shell/RevokePrivilegeFunction.java PRE-CREATION
shell/src/main/java/org/apache/sqoop/shell/RevokeRoleFunction.java PRE-CREATION
shell/src/main/java/org/apache/sqoop/shell/SetOptionFunction.java 3f5f570
shell/src/main/java/org/apache/sqoop/shell/SqoopCommand.java cbd34f5
shell/src/main/java/org/apache/sqoop/shell/SqoopShell.java 2e87965
shell/src/main/java/org/apache/sqoop/shell/core/Constants.java 46f2b7f
shell/src/main/java/org/apache/sqoop/shell/core/ShellError.java 7140232
shell/src/main/java/org/apache/sqoop/shell/utils/OptionsUtils.java PRE-CREATION
shell/src/main/resources/shell-resource.properties 9c88235
shell/src/test/java/org/apache/sqoop/shell/utils/TestOptionsUtils.java PRE-CREATION
Diff: https://reviews.apache.org/r/31163/diff/
Testing
-------
mvn test
Manually tested with the following commands:
create role -r abe
delete role -r abe
grant role --principal-type user --principal abe -r abe
revoke role --principal-type user --principal abe -r abe
grant privilege --resource-type connector --resource abe -a read --principal abe --principal-type user -g
grant privilege --resource-type connector --resource abe -a read --principal abe --principal-type user
revoke privilege --resource-type connector --resource abe -a read --principal abe --principal-type user -g
revoke privilege --resource-type connector --resource abe -a read --principal abe --principal-type user
You can check the logs for the appropriate server response.
These tests will be better once we have a backend integrated.
Thanks,
Abraham Elmahrek
Re: Review Request 31163: SQOOP-1978: SQOOP-1978: Sqoop2: Command line
support
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31163/#review73243
-----------------------------------------------------------
Ship it!
Ship It!
- Jarek Cecho
On Feb. 20, 2015, 12:09 a.m., Abraham Elmahrek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31163/
> -----------------------------------------------------------
>
> (Updated Feb. 20, 2015, 12:09 a.m.)
>
>
> Review request for Sqoop and Jarek Cecho.
>
>
> Bugs: SQOOP-1978
> https://issues.apache.org/jira/browse/SQOOP-1978
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> commit 3a863cec531aa30880fca866794a397729f2b69f
> Author: Abraham Elmahrek <ab...@apache.org>
> Date: Fri Feb 13 09:46:41 2015 -0800
>
> SQOOP-1978: Sqoop2: Command line support
>
> :100644 100644 1ef2418... a16ba5b... M shell/src/main/java/org/apache/sqoop/shell/CreateCommand.java
> :000000 100644 0000000... 10d06b5... A shell/src/main/java/org/apache/sqoop/shell/CreateRoleFunction.java
> :100644 100644 26e2bf6... 4b66505... M shell/src/main/java/org/apache/sqoop/shell/DeleteCommand.java
> :000000 100644 0000000... d3c9f4d... A shell/src/main/java/org/apache/sqoop/shell/DeleteRoleFunction.java
> :000000 100644 0000000... b4b77b0... A shell/src/main/java/org/apache/sqoop/shell/GrantCommand.java
> :000000 100644 0000000... a473628... A shell/src/main/java/org/apache/sqoop/shell/GrantPrivilegeFunction.java
> :000000 100644 0000000... 9dfe90f... A shell/src/main/java/org/apache/sqoop/shell/GrantRoleFunction.java
> :000000 100644 0000000... 0cb30e4... A shell/src/main/java/org/apache/sqoop/shell/RevokeCommand.java
> :000000 100644 0000000... 16c6bf9... A shell/src/main/java/org/apache/sqoop/shell/RevokePrivilegeFunction.java
> :000000 100644 0000000... cf69faa... A shell/src/main/java/org/apache/sqoop/shell/RevokeRoleFunction.java
> :100644 100644 cbd34f5... fdb7a5b... M shell/src/main/java/org/apache/sqoop/shell/SqoopCommand.java
> :100644 100644 2e87965... e319839... M shell/src/main/java/org/apache/sqoop/shell/SqoopShell.java
> :100644 100644 46f2b7f... 8133bd6... M shell/src/main/java/org/apache/sqoop/shell/core/Constants.java
> :100644 100644 9c88235... ca64dae... M shell/src/main/resources/shell-resource.properties
>
>
> Diffs
> -----
>
> shell/src/main/java/org/apache/sqoop/shell/CreateCommand.java 1ef2418
> shell/src/main/java/org/apache/sqoop/shell/CreateRoleFunction.java PRE-CREATION
> shell/src/main/java/org/apache/sqoop/shell/DeleteCommand.java 26e2bf6
> shell/src/main/java/org/apache/sqoop/shell/DeleteRoleFunction.java PRE-CREATION
> shell/src/main/java/org/apache/sqoop/shell/GrantCommand.java PRE-CREATION
> shell/src/main/java/org/apache/sqoop/shell/GrantPrivilegeFunction.java PRE-CREATION
> shell/src/main/java/org/apache/sqoop/shell/GrantRoleFunction.java PRE-CREATION
> shell/src/main/java/org/apache/sqoop/shell/RevokeCommand.java PRE-CREATION
> shell/src/main/java/org/apache/sqoop/shell/RevokePrivilegeFunction.java PRE-CREATION
> shell/src/main/java/org/apache/sqoop/shell/RevokeRoleFunction.java PRE-CREATION
> shell/src/main/java/org/apache/sqoop/shell/SqoopCommand.java cbd34f5
> shell/src/main/java/org/apache/sqoop/shell/SqoopShell.java 2e87965
> shell/src/main/java/org/apache/sqoop/shell/core/Constants.java 482ddd9
> shell/src/main/resources/shell-resource.properties a462184
>
> Diff: https://reviews.apache.org/r/31163/diff/
>
>
> Testing
> -------
>
> mvn test
>
> Manually tested with the following commands:
>
> create role -r abe
> delete role -r abe
> grant role --principal-type user --principal abe -r abe
> revoke role --principal-type user --principal abe -r abe
> grant privilege --resource-type connector --resource abe -a read --principal abe --principal-type user -g
> grant privilege --resource-type connector --resource abe -a read --principal abe --principal-type user
> revoke privilege --resource-type connector --resource abe -a read --principal abe --principal-type user -g
> revoke privilege --resource-type connector --resource abe -a read --principal abe --principal-type user
>
> You can check the logs for the appropriate server response.
>
> These tests will be better once we have a backend integrated.
>
>
> Thanks,
>
> Abraham Elmahrek
>
>
Re: Review Request 31163: SQOOP-1978: SQOOP-1978: Sqoop2: Command line
support
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31163/
-----------------------------------------------------------
(Updated Feb. 20, 2015, 12:09 a.m.)
Review request for Sqoop and Jarek Cecho.
Bugs: SQOOP-1978
https://issues.apache.org/jira/browse/SQOOP-1978
Repository: sqoop-sqoop2
Description
-------
commit 3a863cec531aa30880fca866794a397729f2b69f
Author: Abraham Elmahrek <ab...@apache.org>
Date: Fri Feb 13 09:46:41 2015 -0800
SQOOP-1978: Sqoop2: Command line support
:100644 100644 1ef2418... a16ba5b... M shell/src/main/java/org/apache/sqoop/shell/CreateCommand.java
:000000 100644 0000000... 10d06b5... A shell/src/main/java/org/apache/sqoop/shell/CreateRoleFunction.java
:100644 100644 26e2bf6... 4b66505... M shell/src/main/java/org/apache/sqoop/shell/DeleteCommand.java
:000000 100644 0000000... d3c9f4d... A shell/src/main/java/org/apache/sqoop/shell/DeleteRoleFunction.java
:000000 100644 0000000... b4b77b0... A shell/src/main/java/org/apache/sqoop/shell/GrantCommand.java
:000000 100644 0000000... a473628... A shell/src/main/java/org/apache/sqoop/shell/GrantPrivilegeFunction.java
:000000 100644 0000000... 9dfe90f... A shell/src/main/java/org/apache/sqoop/shell/GrantRoleFunction.java
:000000 100644 0000000... 0cb30e4... A shell/src/main/java/org/apache/sqoop/shell/RevokeCommand.java
:000000 100644 0000000... 16c6bf9... A shell/src/main/java/org/apache/sqoop/shell/RevokePrivilegeFunction.java
:000000 100644 0000000... cf69faa... A shell/src/main/java/org/apache/sqoop/shell/RevokeRoleFunction.java
:100644 100644 cbd34f5... fdb7a5b... M shell/src/main/java/org/apache/sqoop/shell/SqoopCommand.java
:100644 100644 2e87965... e319839... M shell/src/main/java/org/apache/sqoop/shell/SqoopShell.java
:100644 100644 46f2b7f... 8133bd6... M shell/src/main/java/org/apache/sqoop/shell/core/Constants.java
:100644 100644 9c88235... ca64dae... M shell/src/main/resources/shell-resource.properties
Diffs (updated)
-----
shell/src/main/java/org/apache/sqoop/shell/CreateCommand.java 1ef2418
shell/src/main/java/org/apache/sqoop/shell/CreateRoleFunction.java PRE-CREATION
shell/src/main/java/org/apache/sqoop/shell/DeleteCommand.java 26e2bf6
shell/src/main/java/org/apache/sqoop/shell/DeleteRoleFunction.java PRE-CREATION
shell/src/main/java/org/apache/sqoop/shell/GrantCommand.java PRE-CREATION
shell/src/main/java/org/apache/sqoop/shell/GrantPrivilegeFunction.java PRE-CREATION
shell/src/main/java/org/apache/sqoop/shell/GrantRoleFunction.java PRE-CREATION
shell/src/main/java/org/apache/sqoop/shell/RevokeCommand.java PRE-CREATION
shell/src/main/java/org/apache/sqoop/shell/RevokePrivilegeFunction.java PRE-CREATION
shell/src/main/java/org/apache/sqoop/shell/RevokeRoleFunction.java PRE-CREATION
shell/src/main/java/org/apache/sqoop/shell/SqoopCommand.java cbd34f5
shell/src/main/java/org/apache/sqoop/shell/SqoopShell.java 2e87965
shell/src/main/java/org/apache/sqoop/shell/core/Constants.java 482ddd9
shell/src/main/resources/shell-resource.properties a462184
Diff: https://reviews.apache.org/r/31163/diff/
Testing
-------
mvn test
Manually tested with the following commands:
create role -r abe
delete role -r abe
grant role --principal-type user --principal abe -r abe
revoke role --principal-type user --principal abe -r abe
grant privilege --resource-type connector --resource abe -a read --principal abe --principal-type user -g
grant privilege --resource-type connector --resource abe -a read --principal abe --principal-type user
revoke privilege --resource-type connector --resource abe -a read --principal abe --principal-type user -g
revoke privilege --resource-type connector --resource abe -a read --principal abe --principal-type user
You can check the logs for the appropriate server response.
These tests will be better once we have a backend integrated.
Thanks,
Abraham Elmahrek
Re: Review Request 31163: SQOOP-1978: SQOOP-1978: Sqoop2: Command line
support
Posted by Abraham Elmahrek <ab...@cloudera.com>.
> On Feb. 19, 2015, 11:24 p.m., Jarek Cecho wrote:
> > shell/src/main/java/org/apache/sqoop/shell/CreateRoleFunction.java, line 49
> > <https://reviews.apache.org/r/31163/diff/2/?file=868421#file868421line49>
> >
> > Are we expecting that createRole() will thrown an exception on failure (for example when given role already exists)?
Expected!
- Abraham
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31163/#review73161
-----------------------------------------------------------
On Feb. 18, 2015, 11:21 p.m., Abraham Elmahrek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31163/
> -----------------------------------------------------------
>
> (Updated Feb. 18, 2015, 11:21 p.m.)
>
>
> Review request for Sqoop and Jarek Cecho.
>
>
> Bugs: SQOOP-1978
> https://issues.apache.org/jira/browse/SQOOP-1978
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> commit 3a863cec531aa30880fca866794a397729f2b69f
> Author: Abraham Elmahrek <ab...@apache.org>
> Date: Fri Feb 13 09:46:41 2015 -0800
>
> SQOOP-1978: Sqoop2: Command line support
>
> :100644 100644 1ef2418... a16ba5b... M shell/src/main/java/org/apache/sqoop/shell/CreateCommand.java
> :000000 100644 0000000... 10d06b5... A shell/src/main/java/org/apache/sqoop/shell/CreateRoleFunction.java
> :100644 100644 26e2bf6... 4b66505... M shell/src/main/java/org/apache/sqoop/shell/DeleteCommand.java
> :000000 100644 0000000... d3c9f4d... A shell/src/main/java/org/apache/sqoop/shell/DeleteRoleFunction.java
> :000000 100644 0000000... b4b77b0... A shell/src/main/java/org/apache/sqoop/shell/GrantCommand.java
> :000000 100644 0000000... a473628... A shell/src/main/java/org/apache/sqoop/shell/GrantPrivilegeFunction.java
> :000000 100644 0000000... 9dfe90f... A shell/src/main/java/org/apache/sqoop/shell/GrantRoleFunction.java
> :000000 100644 0000000... 0cb30e4... A shell/src/main/java/org/apache/sqoop/shell/RevokeCommand.java
> :000000 100644 0000000... 16c6bf9... A shell/src/main/java/org/apache/sqoop/shell/RevokePrivilegeFunction.java
> :000000 100644 0000000... cf69faa... A shell/src/main/java/org/apache/sqoop/shell/RevokeRoleFunction.java
> :100644 100644 cbd34f5... fdb7a5b... M shell/src/main/java/org/apache/sqoop/shell/SqoopCommand.java
> :100644 100644 2e87965... e319839... M shell/src/main/java/org/apache/sqoop/shell/SqoopShell.java
> :100644 100644 46f2b7f... 8133bd6... M shell/src/main/java/org/apache/sqoop/shell/core/Constants.java
> :100644 100644 9c88235... ca64dae... M shell/src/main/resources/shell-resource.properties
>
>
> Diffs
> -----
>
> shell/src/main/java/org/apache/sqoop/shell/CreateCommand.java 1ef2418
> shell/src/main/java/org/apache/sqoop/shell/CreateRoleFunction.java PRE-CREATION
> shell/src/main/java/org/apache/sqoop/shell/DeleteCommand.java 26e2bf6
> shell/src/main/java/org/apache/sqoop/shell/DeleteRoleFunction.java PRE-CREATION
> shell/src/main/java/org/apache/sqoop/shell/GrantCommand.java PRE-CREATION
> shell/src/main/java/org/apache/sqoop/shell/GrantPrivilegeFunction.java PRE-CREATION
> shell/src/main/java/org/apache/sqoop/shell/GrantRoleFunction.java PRE-CREATION
> shell/src/main/java/org/apache/sqoop/shell/RevokeCommand.java PRE-CREATION
> shell/src/main/java/org/apache/sqoop/shell/RevokePrivilegeFunction.java PRE-CREATION
> shell/src/main/java/org/apache/sqoop/shell/RevokeRoleFunction.java PRE-CREATION
> shell/src/main/java/org/apache/sqoop/shell/SqoopCommand.java cbd34f5
> shell/src/main/java/org/apache/sqoop/shell/SqoopShell.java 2e87965
> shell/src/main/java/org/apache/sqoop/shell/core/Constants.java 46f2b7f
> shell/src/main/resources/shell-resource.properties 9c88235
>
> Diff: https://reviews.apache.org/r/31163/diff/
>
>
> Testing
> -------
>
> mvn test
>
> Manually tested with the following commands:
>
> create role -r abe
> delete role -r abe
> grant role --principal-type user --principal abe -r abe
> revoke role --principal-type user --principal abe -r abe
> grant privilege --resource-type connector --resource abe -a read --principal abe --principal-type user -g
> grant privilege --resource-type connector --resource abe -a read --principal abe --principal-type user
> revoke privilege --resource-type connector --resource abe -a read --principal abe --principal-type user -g
> revoke privilege --resource-type connector --resource abe -a read --principal abe --principal-type user
>
> You can check the logs for the appropriate server response.
>
> These tests will be better once we have a backend integrated.
>
>
> Thanks,
>
> Abraham Elmahrek
>
>
Re: Review Request 31163: SQOOP-1978: SQOOP-1978: Sqoop2: Command line
support
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31163/#review73161
-----------------------------------------------------------
Good stuff Abe, just two nits/questions:
shell/src/main/java/org/apache/sqoop/shell/CreateRoleFunction.java
<https://reviews.apache.org/r/31163/#comment119392>
Are we expecting that createRole() will thrown an exception on failure (for example when given role already exists)?
shell/src/main/java/org/apache/sqoop/shell/GrantPrivilegeFunction.java
<https://reviews.apache.org/r/31163/#comment119393>
Nit: Shouldn't the "with grant" be stored in the resource files as well? We've put all displayed texts there, right?
Jarcec
- Jarek Cecho
On Feb. 18, 2015, 11:21 p.m., Abraham Elmahrek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31163/
> -----------------------------------------------------------
>
> (Updated Feb. 18, 2015, 11:21 p.m.)
>
>
> Review request for Sqoop and Jarek Cecho.
>
>
> Bugs: SQOOP-1978
> https://issues.apache.org/jira/browse/SQOOP-1978
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> commit 3a863cec531aa30880fca866794a397729f2b69f
> Author: Abraham Elmahrek <ab...@apache.org>
> Date: Fri Feb 13 09:46:41 2015 -0800
>
> SQOOP-1978: Sqoop2: Command line support
>
> :100644 100644 1ef2418... a16ba5b... M shell/src/main/java/org/apache/sqoop/shell/CreateCommand.java
> :000000 100644 0000000... 10d06b5... A shell/src/main/java/org/apache/sqoop/shell/CreateRoleFunction.java
> :100644 100644 26e2bf6... 4b66505... M shell/src/main/java/org/apache/sqoop/shell/DeleteCommand.java
> :000000 100644 0000000... d3c9f4d... A shell/src/main/java/org/apache/sqoop/shell/DeleteRoleFunction.java
> :000000 100644 0000000... b4b77b0... A shell/src/main/java/org/apache/sqoop/shell/GrantCommand.java
> :000000 100644 0000000... a473628... A shell/src/main/java/org/apache/sqoop/shell/GrantPrivilegeFunction.java
> :000000 100644 0000000... 9dfe90f... A shell/src/main/java/org/apache/sqoop/shell/GrantRoleFunction.java
> :000000 100644 0000000... 0cb30e4... A shell/src/main/java/org/apache/sqoop/shell/RevokeCommand.java
> :000000 100644 0000000... 16c6bf9... A shell/src/main/java/org/apache/sqoop/shell/RevokePrivilegeFunction.java
> :000000 100644 0000000... cf69faa... A shell/src/main/java/org/apache/sqoop/shell/RevokeRoleFunction.java
> :100644 100644 cbd34f5... fdb7a5b... M shell/src/main/java/org/apache/sqoop/shell/SqoopCommand.java
> :100644 100644 2e87965... e319839... M shell/src/main/java/org/apache/sqoop/shell/SqoopShell.java
> :100644 100644 46f2b7f... 8133bd6... M shell/src/main/java/org/apache/sqoop/shell/core/Constants.java
> :100644 100644 9c88235... ca64dae... M shell/src/main/resources/shell-resource.properties
>
>
> Diffs
> -----
>
> shell/src/main/java/org/apache/sqoop/shell/CreateCommand.java 1ef2418
> shell/src/main/java/org/apache/sqoop/shell/CreateRoleFunction.java PRE-CREATION
> shell/src/main/java/org/apache/sqoop/shell/DeleteCommand.java 26e2bf6
> shell/src/main/java/org/apache/sqoop/shell/DeleteRoleFunction.java PRE-CREATION
> shell/src/main/java/org/apache/sqoop/shell/GrantCommand.java PRE-CREATION
> shell/src/main/java/org/apache/sqoop/shell/GrantPrivilegeFunction.java PRE-CREATION
> shell/src/main/java/org/apache/sqoop/shell/GrantRoleFunction.java PRE-CREATION
> shell/src/main/java/org/apache/sqoop/shell/RevokeCommand.java PRE-CREATION
> shell/src/main/java/org/apache/sqoop/shell/RevokePrivilegeFunction.java PRE-CREATION
> shell/src/main/java/org/apache/sqoop/shell/RevokeRoleFunction.java PRE-CREATION
> shell/src/main/java/org/apache/sqoop/shell/SqoopCommand.java cbd34f5
> shell/src/main/java/org/apache/sqoop/shell/SqoopShell.java 2e87965
> shell/src/main/java/org/apache/sqoop/shell/core/Constants.java 46f2b7f
> shell/src/main/resources/shell-resource.properties 9c88235
>
> Diff: https://reviews.apache.org/r/31163/diff/
>
>
> Testing
> -------
>
> mvn test
>
> Manually tested with the following commands:
>
> create role -r abe
> delete role -r abe
> grant role --principal-type user --principal abe -r abe
> revoke role --principal-type user --principal abe -r abe
> grant privilege --resource-type connector --resource abe -a read --principal abe --principal-type user -g
> grant privilege --resource-type connector --resource abe -a read --principal abe --principal-type user
> revoke privilege --resource-type connector --resource abe -a read --principal abe --principal-type user -g
> revoke privilege --resource-type connector --resource abe -a read --principal abe --principal-type user
>
> You can check the logs for the appropriate server response.
>
> These tests will be better once we have a backend integrated.
>
>
> Thanks,
>
> Abraham Elmahrek
>
>
Re: Review Request 31163: SQOOP-1978: SQOOP-1978: Sqoop2: Command line
support
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31163/
-----------------------------------------------------------
(Updated Feb. 18, 2015, 11:21 p.m.)
Review request for Sqoop and Jarek Cecho.
Bugs: SQOOP-1978
https://issues.apache.org/jira/browse/SQOOP-1978
Repository: sqoop-sqoop2
Description
-------
commit 3a863cec531aa30880fca866794a397729f2b69f
Author: Abraham Elmahrek <ab...@apache.org>
Date: Fri Feb 13 09:46:41 2015 -0800
SQOOP-1978: Sqoop2: Command line support
:100644 100644 1ef2418... a16ba5b... M shell/src/main/java/org/apache/sqoop/shell/CreateCommand.java
:000000 100644 0000000... 10d06b5... A shell/src/main/java/org/apache/sqoop/shell/CreateRoleFunction.java
:100644 100644 26e2bf6... 4b66505... M shell/src/main/java/org/apache/sqoop/shell/DeleteCommand.java
:000000 100644 0000000... d3c9f4d... A shell/src/main/java/org/apache/sqoop/shell/DeleteRoleFunction.java
:000000 100644 0000000... b4b77b0... A shell/src/main/java/org/apache/sqoop/shell/GrantCommand.java
:000000 100644 0000000... a473628... A shell/src/main/java/org/apache/sqoop/shell/GrantPrivilegeFunction.java
:000000 100644 0000000... 9dfe90f... A shell/src/main/java/org/apache/sqoop/shell/GrantRoleFunction.java
:000000 100644 0000000... 0cb30e4... A shell/src/main/java/org/apache/sqoop/shell/RevokeCommand.java
:000000 100644 0000000... 16c6bf9... A shell/src/main/java/org/apache/sqoop/shell/RevokePrivilegeFunction.java
:000000 100644 0000000... cf69faa... A shell/src/main/java/org/apache/sqoop/shell/RevokeRoleFunction.java
:100644 100644 cbd34f5... fdb7a5b... M shell/src/main/java/org/apache/sqoop/shell/SqoopCommand.java
:100644 100644 2e87965... e319839... M shell/src/main/java/org/apache/sqoop/shell/SqoopShell.java
:100644 100644 46f2b7f... 8133bd6... M shell/src/main/java/org/apache/sqoop/shell/core/Constants.java
:100644 100644 9c88235... ca64dae... M shell/src/main/resources/shell-resource.properties
Diffs (updated)
-----
shell/src/main/java/org/apache/sqoop/shell/CreateCommand.java 1ef2418
shell/src/main/java/org/apache/sqoop/shell/CreateRoleFunction.java PRE-CREATION
shell/src/main/java/org/apache/sqoop/shell/DeleteCommand.java 26e2bf6
shell/src/main/java/org/apache/sqoop/shell/DeleteRoleFunction.java PRE-CREATION
shell/src/main/java/org/apache/sqoop/shell/GrantCommand.java PRE-CREATION
shell/src/main/java/org/apache/sqoop/shell/GrantPrivilegeFunction.java PRE-CREATION
shell/src/main/java/org/apache/sqoop/shell/GrantRoleFunction.java PRE-CREATION
shell/src/main/java/org/apache/sqoop/shell/RevokeCommand.java PRE-CREATION
shell/src/main/java/org/apache/sqoop/shell/RevokePrivilegeFunction.java PRE-CREATION
shell/src/main/java/org/apache/sqoop/shell/RevokeRoleFunction.java PRE-CREATION
shell/src/main/java/org/apache/sqoop/shell/SqoopCommand.java cbd34f5
shell/src/main/java/org/apache/sqoop/shell/SqoopShell.java 2e87965
shell/src/main/java/org/apache/sqoop/shell/core/Constants.java 46f2b7f
shell/src/main/resources/shell-resource.properties 9c88235
Diff: https://reviews.apache.org/r/31163/diff/
Testing
-------
mvn test
Manually tested with the following commands:
create role -r abe
delete role -r abe
grant role --principal-type user --principal abe -r abe
revoke role --principal-type user --principal abe -r abe
grant privilege --resource-type connector --resource abe -a read --principal abe --principal-type user -g
grant privilege --resource-type connector --resource abe -a read --principal abe --principal-type user
revoke privilege --resource-type connector --resource abe -a read --principal abe --principal-type user -g
revoke privilege --resource-type connector --resource abe -a read --principal abe --principal-type user
You can check the logs for the appropriate server response.
These tests will be better once we have a backend integrated.
Thanks,
Abraham Elmahrek