You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2022/06/02 22:48:40 UTC
[GitHub] [geode] gesterzhou opened a new pull request, #7766: [DRAFT] GEODE-10350: volunteerForPrimary should proceed when being elector or…
gesterzhou opened a new pull request, #7766:
URL: https://github.com/apache/geode/pull/7766
… knowing elector
<!-- Thank you for submitting a contribution to Apache Geode. -->
<!-- In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
-->
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
<!-- Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] jchen21 commented on a diff in pull request #7766: [DRAFT] GEODE-10350: volunteerForPrimary should proceed when being elector or…
Posted by GitBox <gi...@apache.org>.
jchen21 commented on code in PR #7766:
URL: https://github.com/apache/geode/pull/7766#discussion_r888470774
##########
geode-core/src/main/java/org/apache/geode/internal/cache/BucketAdvisor.java:
##########
@@ -990,7 +990,7 @@ public boolean isHosting() {
*/
public void volunteerForPrimary() {
InternalDistributedMember elector = primaryElector;
- if (elector != null && regionAdvisor.hasPartitionedRegion(elector)) {
+ if (elector != null && !regionAdvisor.hasPartitionedRegion(elector)) {
Review Comment:
Are you going to rename `hasPartitionedRegion`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] metatype closed pull request #7766: [DRAFT] GEODE-10350: volunteerForPrimary should proceed when being elector or…
Posted by GitBox <gi...@apache.org>.
metatype closed pull request #7766: [DRAFT] GEODE-10350: volunteerForPrimary should proceed when being elector or…
URL: https://github.com/apache/geode/pull/7766
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org