You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2018/02/18 04:53:50 UTC
Review Request 65703: Removed the unnecessary tmp dir during packaging
docker build.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65703/
-----------------------------------------------------------
Review request for mesos and Benjamin Bannier.
Repository: mesos
Description
-------
On Jenkins, we observed that tmp dirs are cleaned up quite frequently.
Since the build process will take about 30min, it's highly likely that
the tmp dir used in the script is cleaned up when we try to use it.
This patch removed the need for the tmp dir in the script.
Diffs
-----
support/packaging/centos/build-docker-image.sh 6965cc079e417cefa97520347830a05154cbd8af
Diff: https://reviews.apache.org/r/65703/diff/1/
Testing
-------
Verified on CI
https://builds.apache.org/view/M-R/view/Mesos/job/Mesos-Mini/17/console
Thanks,
Jie Yu
Re: Review Request 65703: Removed the unnecessary tmp dir during
packaging docker build.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65703/#review197733
-----------------------------------------------------------
Fix it, then Ship it!
support/packaging/centos/build-docker-image.sh
Lines 27-30 (original), 25-27 (patched)
<https://reviews.apache.org/r/65703/#comment277986>
Not yours, but I find it pretty hard to follow around where this directory got created. This could be simpler if we used `support/atexit.sh`.
support/packaging/centos/build-docker-image.sh
Lines 60 (patched)
<https://reviews.apache.org/r/65703/#comment277985>
Not originally yours, but let's quote this.
- Benjamin Bannier
On Feb. 18, 2018, 5:53 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65703/
> -----------------------------------------------------------
>
> (Updated Feb. 18, 2018, 5:53 a.m.)
>
>
> Review request for mesos and Benjamin Bannier.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> On Jenkins, we observed that tmp dirs are cleaned up quite frequently.
> Since the build process will take about 30min, it's highly likely that
> the tmp dir used in the script is cleaned up when we try to use it.
>
> This patch removed the need for the tmp dir in the script.
>
>
> Diffs
> -----
>
> support/packaging/centos/build-docker-image.sh 6965cc079e417cefa97520347830a05154cbd8af
>
>
> Diff: https://reviews.apache.org/r/65703/diff/1/
>
>
> Testing
> -------
>
> Verified on CI
> https://builds.apache.org/view/M-R/view/Mesos/job/Mesos-Mini/17/console
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 65703: Removed the unnecessary tmp dir during
packaging docker build.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65703/#review197725
-----------------------------------------------------------
PASS: Mesos patch 65703 was successfully built and tested.
Reviews applied: `['65703']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65703
- Mesos Reviewbot Windows
On Feb. 18, 2018, 4:53 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65703/
> -----------------------------------------------------------
>
> (Updated Feb. 18, 2018, 4:53 a.m.)
>
>
> Review request for mesos and Benjamin Bannier.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> On Jenkins, we observed that tmp dirs are cleaned up quite frequently.
> Since the build process will take about 30min, it's highly likely that
> the tmp dir used in the script is cleaned up when we try to use it.
>
> This patch removed the need for the tmp dir in the script.
>
>
> Diffs
> -----
>
> support/packaging/centos/build-docker-image.sh 6965cc079e417cefa97520347830a05154cbd8af
>
>
> Diff: https://reviews.apache.org/r/65703/diff/1/
>
>
> Testing
> -------
>
> Verified on CI
> https://builds.apache.org/view/M-R/view/Mesos/job/Mesos-Mini/17/console
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 65703: Removed the unnecessary tmp dir during
packaging docker build.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65703/#review197728
-----------------------------------------------------------
Patch looks great!
Reviews applied: [65703]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Feb. 18, 2018, 4:53 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65703/
> -----------------------------------------------------------
>
> (Updated Feb. 18, 2018, 4:53 a.m.)
>
>
> Review request for mesos and Benjamin Bannier.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> On Jenkins, we observed that tmp dirs are cleaned up quite frequently.
> Since the build process will take about 30min, it's highly likely that
> the tmp dir used in the script is cleaned up when we try to use it.
>
> This patch removed the need for the tmp dir in the script.
>
>
> Diffs
> -----
>
> support/packaging/centos/build-docker-image.sh 6965cc079e417cefa97520347830a05154cbd8af
>
>
> Diff: https://reviews.apache.org/r/65703/diff/1/
>
>
> Testing
> -------
>
> Verified on CI
> https://builds.apache.org/view/M-R/view/Mesos/job/Mesos-Mini/17/console
>
>
> Thanks,
>
> Jie Yu
>
>