[GitHub] [nifi] jtstorck opened a new pull request #3547: NIFI-5254 Update Groovy dependecies to version 2.5.4

[GitBox <gi...@apache.org>]

jtstorck opened a new pull request #3547: NIFI-5254 Update Groovy dependecies to version 2.5.4
URL: https://github.com/apache/nifi/pull/3547
 
 
   Updated pom files regarding groovy dependencies.  groovy-all was changed to a pom type dependency, replaced that dependency with the specific groovy submodule dependencies.
   Added Groovy Bintray as a plugin repository in root pom
   Upgraded spock-core to version 1.3-groovy-2.5 and added exclusion of groovy dependencies to force spock to use the version from dependencyManagement
   Updated groovy-eclipse-batch to use the groovy.version property to determine the version
   Updated groovy-eclipse-compiler to 3.4.0-01
   Updated maven-compiler-plugin to use maven.compiler.source and maven.compiler.target properties for source and target configuration properties
   Removed configuration and dependencies sections from nifi-toolkit-admin and nifi-toolkit-encrypt-config maven-compiler-plugin configurations so that the configuration from the root pom's maven-compiler-plugin is inherited
   Removed dependencyManagement from nifi-jetty module, version of groovy modules will be inherited from root pom
   Removed maven-compiler-plugin configuration from nifi-toolkit-api so that the configuration from the root pom's maven-compiler-plugin is inherited
   Updated spock-core dependencyManagement to 1.3-groovy-2.5
   Fixed AESSensitivePropertyProviderTest issue with Groovy creating KEY_256_HEX slice of the wrong size due to BigDecimal being used as the result of the division; using intdiv to force an integer result creates the correctly sized array
   Resolved deprecation errors during Groovy compile for bouncycastle, Extension should be used in place of X509Extension
   Added groovy-json test dependency to nifi-web-security
   Removed maven-compiler-plugin configuration from nifi-lookup-services, nifi-mock-record-utils, and nifi-web-utils so that the configuration from the root pom's maven-compiler-plugin is inherited
   Updated root pom pluginManagement to specify version 3.8.0 of maven-compiler-plugin
   Added maven-compiler-plugin config to nifi-toolkit-admin and nifi-toolkit-encrypt-config to use groovy-eclipse-compiler during the compile phase so that the groovy-based tools are compiled
   Addressed deprecated CliBuilder and OptionAccessor usage in nifi-toolkit-encrypt-config, those classes were moved from groovy.util to groovy.cli.commons
   Removed getInner() usage from nifi-toolkit-encrypt-config, method no longer exists causing the tests to crash
   Updated CryptographicHashAttributeTest to use java.time classes instead of java.util.Date
   
   ----
   **NOTE:**
   An issue occurs with Groovy 2.5.7 (with spock-core:1.2-groovy-2.5 and 1.3-groovy-2.5):
   
   ```
   java.lang.IllegalAccessError: Update to non-static final field MySpec.field attempted from a different method ($spock_initializeFields) than the initializer method <init>
   	at MySpec.$spock_initializeFields(MySpec.groovy:##)
   ```
   
   The test passes when Groovy 2.5.4 is used.  Until the issue with Groovy 2.5.7 is resolved, this PR will use 2.5.4
   
   ----
   
   Thank you for submitting a contribution to Apache NiFi.
   
   Please provide a short description of the PR here:
   
   #### Description of PR
   
   _Enables X functionality; fixes bug NIFI-YYYY._
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [x] Is there a JIRA ticket associated with this PR? Is it referenced 
        in the commit message?
   
   - [x] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
   
   - [x] Has your PR been rebased against the latest commit within the target branch (typically `master`)?
   
   - [x] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._
   
   ### For code changes:
   - [x] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder?
   - [x] Have you written or updated unit tests to verify your changes?
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
   - [ ] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`?
   - [ ] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`?
   - [ ] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties?
   
   ### For documentation related changes:
   - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
   
   ### Note:
   Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services