You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by vladimir-kotikov <gi...@git.apache.org> on 2014/04/07 16:19:54 UTC
[GitHub] cordova-windows pull request: CB-6256 CB-6266 Add support for doma...
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-windows/pull/23
CB-6256 CB-6266 Add support for domain whitelist and start page settings to Windows8
This PR fixes issues https://issues.apache.org/jira/browse/CB-6266 and https://issues.apache.org/jira/browse/CB-6256
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-windows CB-6256
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-windows/pull/23.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #23
----
commit c4dabc9fd8f177ce2e59eefc77c5a9a26eb0362b
Author: Vladimir Kotikov <v-...@microsoft.com>
Date: 2014-04-07T08:59:43Z
CB-6256 CB-6266 Add support for domain whitelist and start page settings to Windows8
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-windows pull request: CB-6256 CB-6266 Add support for doma...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-windows/pull/23
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-windows pull request: CB-6256 CB-6266 Add support for doma...
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-windows/pull/23#issuecomment-41207048
Hi @vladimir-kotikov
I have added a comment in Jira here :
https://issues.apache.org/jira/browse/CB-6266?focusedCommentId=13978791&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13978791
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-windows pull request: CB-6256 CB-6266 Add support for doma...
Posted by vladimir-kotikov <gi...@git.apache.org>.
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-windows/pull/23#issuecomment-39844429
ICLA has been filled
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-windows pull request: CB-6256 CB-6266 Add support for doma...
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-windows/pull/23#issuecomment-39775030
Hi Vladimir,
Thanks for your contributions. I do not see an CLA on file when I look for your name at https://people.apache.org/committer-index.html
You'll need to sign and send it, or show what name you signed under if you have already signed it.
More instructions here:
https://cordova.apache.org/#contribute
Thanks again Vladimir, looking forward to pulling this in, once this is sorted.
Cheers,
Jesse
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---