You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "GeordieMai (Jira)" <ji...@apache.org> on 2020/12/23 06:15:00 UTC
[jira] [Assigned] (KAFKA-10885) Refactor
MemoryRecordsBuilderTest/MemoryRecordsTest to avoid a lot of (unnecessary)
ignored test cases
[ https://issues.apache.org/jira/browse/KAFKA-10885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
GeordieMai reassigned KAFKA-10885:
----------------------------------
Assignee: GeordieMai
> Refactor MemoryRecordsBuilderTest/MemoryRecordsTest to avoid a lot of (unnecessary) ignored test cases
> ------------------------------------------------------------------------------------------------------
>
> Key: KAFKA-10885
> URL: https://issues.apache.org/jira/browse/KAFKA-10885
> Project: Kafka
> Issue Type: Improvement
> Reporter: Chia-Ping Tsai
> Assignee: GeordieMai
> Priority: Major
> Labels: newbie
>
> {quote}
> private void assumeAtLeastV2OrNotZstd(byte magic) {
> assumeTrue(compressionType != CompressionType.ZSTD || magic >= MAGIC_VALUE_V2);
> }
> {quote}
> MemoryRecordsBuilderTest/MemoryRecordsTest use aforementioned method to avoid testing zstd on unsupported magic code. However, it produces some unnecessary ignored test cases. Personally, it could be separated to different test classes for each magic code as we do assign specify magic code to each test cases.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)