You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@zeppelin.apache.org by bz...@apache.org on 2016/07/16 13:06:58 UTC
zeppelin git commit: [Zeppelin - 1174] Cleanup unused methods in repo
layer
Repository: zeppelin
Updated Branches:
refs/heads/master b11b6ec24 -> 2ffdf1ecb
[Zeppelin - 1174] Cleanup unused methods in repo layer
### What is this PR for?
This is to cleanup some unused print methods from repository layer
### What type of PR is it?
Maintenance | Cleanup
### Todos
* [x] - remove unused methods
### What is the Jira issue?
[#1174](https://issues.apache.org/jira/browse/ZEPPELIN-1174)
### How should this be tested?
CI pass
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
Author: Khalid Huseynov <kh...@nflabs.com>
Closes #1183 from khalidhuseynov/repo/clean-unused-methods and squashes the following commits:
0a4e615 [Khalid Huseynov] remove unused functions
Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/2ffdf1ec
Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/2ffdf1ec
Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/2ffdf1ec
Branch: refs/heads/master
Commit: 2ffdf1ecb5715c7a017faafba09a46a5c6d472f7
Parents: b11b6ec
Author: Khalid Huseynov <kh...@nflabs.com>
Authored: Thu Jul 14 14:55:54 2016 +0900
Committer: Alexander Bezzubov <bz...@apache.org>
Committed: Sat Jul 16 22:06:41 2016 +0900
----------------------------------------------------------------------
.../notebook/repo/NotebookRepoSync.java | 39 +-------------------
1 file changed, 2 insertions(+), 37 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/zeppelin/blob/2ffdf1ec/zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/repo/NotebookRepoSync.java
----------------------------------------------------------------------
diff --git a/zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/repo/NotebookRepoSync.java b/zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/repo/NotebookRepoSync.java
index b396da0..ab53f5f 100644
--- a/zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/repo/NotebookRepoSync.java
+++ b/zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/repo/NotebookRepoSync.java
@@ -310,41 +310,6 @@ public class NotebookRepoSync implements NotebookRepo {
return latest;
}
- @SuppressWarnings("unused")
- private void printParagraphs(Note note) {
- LOG.info("Note name : " + note.getName());
- LOG.info("Note ID : " + note.id());
- for (Paragraph p : note.getParagraphs()) {
- printParagraph(p);
- }
- }
-
- private void printParagraph(Paragraph paragraph) {
- LOG.info("Date created : " + paragraph.getDateCreated());
- LOG.info("Date started : " + paragraph.getDateStarted());
- LOG.info("Date finished : " + paragraph.getDateFinished());
- LOG.info("Paragraph ID : " + paragraph.getId());
- LOG.info("Paragraph title : " + paragraph.getTitle());
- }
-
- @SuppressWarnings("unused")
- private void printNoteInfos(List <NoteInfo> notes) {
- LOG.info("The following is a list of note infos");
- for (NoteInfo note : notes) {
- printNoteInfo(note);
- }
- }
-
- private void printNoteInfo(NoteInfo note) {
- LOG.info("Note info of notebook with name : " + note.getName());
- LOG.info("ID : " + note.getId());
- Map<String, Object> configs = note.getConfig();
- for (Map.Entry<String, Object> entry : configs.entrySet()) {
- LOG.info("Config Key = " + entry.getKey() + " , Value = " +
- entry.getValue().toString() + "of class " + entry.getClass());
- }
- }
-
@Override
public void close() {
LOG.info("Closing all notebook storages");
@@ -367,9 +332,9 @@ public class NotebookRepoSync implements NotebookRepo {
try {
allRepoCheckpoints.add(getRepo(i).checkpoint(noteId, checkpointMsg, subject));
} catch (IOException e) {
- LOG.warn("Couldn't checkpoint in {} storage with index {} for note {}",
+ LOG.warn("Couldn't checkpoint in {} storage with index {} for note {}",
getRepo(i).getClass().toString(), i, noteId);
- errorMessage += "Error on storage class " + getRepo(i).getClass().toString() +
+ errorMessage += "Error on storage class " + getRepo(i).getClass().toString() +
" with index " + i + " : " + e.getMessage() + "\n";
errorCount++;
}