You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/04/03 15:22:51 UTC
[GitHub] [camel-quarkus] jamesnetherton opened a new pull request #1031: Fix
intermittent failure of messaging tests
jamesnetherton opened a new pull request #1031: Fix intermittent failure of messaging tests
URL: https://github.com/apache/camel-quarkus/pull/1031
Fixes #1023
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] jamesnetherton commented on a change in pull
request #1031: Fix intermittent failure of messaging tests
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on a change in pull request #1031: Fix intermittent failure of messaging tests
URL: https://github.com/apache/camel-quarkus/pull/1031#discussion_r403119283
##########
File path: integration-tests/messaging/src/test/java/org/apache/camel/quarkus/component/messaging/it/ActiveMQTestResource.java
##########
@@ -43,6 +45,13 @@
try {
container = new GenericContainer(ACTIVEMQ_IMAGE)
.withExposedPorts(ACTIVEMQ_PORT)
+ .withLogConsumer(new Consumer<OutputFrame>() {
+ @Override
+ public void accept(OutputFrame outputFrame) {
+ System.out.println(outputFrame.getUtf8String());
Review comment:
Works ok. Everything gets prefixed with `STDOUT:`, so at least it's clear what's coming from the container and what isn't.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] jamesnetherton commented on a change in pull
request #1031: Fix intermittent failure of messaging tests
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on a change in pull request #1031: Fix intermittent failure of messaging tests
URL: https://github.com/apache/camel-quarkus/pull/1031#discussion_r403115836
##########
File path: integration-tests/messaging/src/test/java/org/apache/camel/quarkus/component/messaging/it/ActiveMQTestResource.java
##########
@@ -43,6 +45,13 @@
try {
container = new GenericContainer(ACTIVEMQ_IMAGE)
.withExposedPorts(ACTIVEMQ_PORT)
+ .withLogConsumer(new Consumer<OutputFrame>() {
+ @Override
+ public void accept(OutputFrame outputFrame) {
+ System.out.println(outputFrame.getUtf8String());
Review comment:
Latest commit uses `Slf4jLogConsumer` :+1:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on a change in pull request
#1031: Fix intermittent failure of messaging tests
Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on a change in pull request #1031: Fix intermittent failure of messaging tests
URL: https://github.com/apache/camel-quarkus/pull/1031#discussion_r403100242
##########
File path: integration-tests/messaging/src/test/java/org/apache/camel/quarkus/component/messaging/it/ActiveMQTestResource.java
##########
@@ -43,6 +45,13 @@
try {
container = new GenericContainer(ACTIVEMQ_IMAGE)
.withExposedPorts(ACTIVEMQ_PORT)
+ .withLogConsumer(new Consumer<OutputFrame>() {
+ @Override
+ public void accept(OutputFrame outputFrame) {
+ System.out.println(outputFrame.getUtf8String());
Review comment:
I meant [this one](https://github.com/testcontainers/testcontainers-java/blob/master/core/src/main/java/org/testcontainers/containers/output/Slf4jLogConsumer.java) that should properly handle the output frame.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on a change in pull request
#1031: Fix intermittent failure of messaging tests
Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on a change in pull request #1031: Fix intermittent failure of messaging tests
URL: https://github.com/apache/camel-quarkus/pull/1031#discussion_r403116393
##########
File path: integration-tests/messaging/src/test/java/org/apache/camel/quarkus/component/messaging/it/ActiveMQTestResource.java
##########
@@ -43,6 +45,13 @@
try {
container = new GenericContainer(ACTIVEMQ_IMAGE)
.withExposedPorts(ACTIVEMQ_PORT)
+ .withLogConsumer(new Consumer<OutputFrame>() {
+ @Override
+ public void accept(OutputFrame outputFrame) {
+ System.out.println(outputFrame.getUtf8String());
Review comment:
does it work as advertised ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] jamesnetherton merged pull request #1031: Fix
intermittent failure of messaging tests
Posted by GitBox <gi...@apache.org>.
jamesnetherton merged pull request #1031: Fix intermittent failure of messaging tests
URL: https://github.com/apache/camel-quarkus/pull/1031
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] jamesnetherton commented on a change in pull
request #1031: Fix intermittent failure of messaging tests
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on a change in pull request #1031: Fix intermittent failure of messaging tests
URL: https://github.com/apache/camel-quarkus/pull/1031#discussion_r403098098
##########
File path: integration-tests/messaging/src/test/java/org/apache/camel/quarkus/component/messaging/it/ActiveMQTestResource.java
##########
@@ -43,6 +45,13 @@
try {
container = new GenericContainer(ACTIVEMQ_IMAGE)
.withExposedPorts(ACTIVEMQ_PORT)
+ .withLogConsumer(new Consumer<OutputFrame>() {
+ @Override
+ public void accept(OutputFrame outputFrame) {
+ System.out.println(outputFrame.getUtf8String());
Review comment:
Yeah but most of the content coming back from the container is already log formatted. So it gets messy if you wrap it in more formatting. Hence I just write it as-is.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on a change in pull request
#1031: Fix intermittent failure of messaging tests
Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on a change in pull request #1031: Fix intermittent failure of messaging tests
URL: https://github.com/apache/camel-quarkus/pull/1031#discussion_r403095004
##########
File path: integration-tests/messaging/src/test/java/org/apache/camel/quarkus/component/messaging/it/ActiveMQTestResource.java
##########
@@ -43,6 +45,13 @@
try {
container = new GenericContainer(ACTIVEMQ_IMAGE)
.withExposedPorts(ACTIVEMQ_PORT)
+ .withLogConsumer(new Consumer<OutputFrame>() {
+ @Override
+ public void accept(OutputFrame outputFrame) {
+ System.out.println(outputFrame.getUtf8String());
Review comment:
Maybe this should be replaced by slf4j ? (I think there is a facility from testcontainers)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on a change in pull request
#1031: Fix intermittent failure of messaging tests
Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on a change in pull request #1031: Fix intermittent failure of messaging tests
URL: https://github.com/apache/camel-quarkus/pull/1031#discussion_r403121230
##########
File path: integration-tests/messaging/src/test/java/org/apache/camel/quarkus/component/messaging/it/ActiveMQTestResource.java
##########
@@ -43,6 +45,13 @@
try {
container = new GenericContainer(ACTIVEMQ_IMAGE)
.withExposedPorts(ACTIVEMQ_PORT)
+ .withLogConsumer(new Consumer<OutputFrame>() {
+ @Override
+ public void accept(OutputFrame outputFrame) {
+ System.out.println(outputFrame.getUtf8String());
Review comment:
Ah yeah, that issue ... I think I did implement my own version some time ago, maybe I'll copy over this repo, if only I could remember where it it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on a change in pull request
#1031: Fix intermittent failure of messaging tests
Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on a change in pull request #1031: Fix intermittent failure of messaging tests
URL: https://github.com/apache/camel-quarkus/pull/1031#discussion_r403095004
##########
File path: integration-tests/messaging/src/test/java/org/apache/camel/quarkus/component/messaging/it/ActiveMQTestResource.java
##########
@@ -43,6 +45,13 @@
try {
container = new GenericContainer(ACTIVEMQ_IMAGE)
.withExposedPorts(ACTIVEMQ_PORT)
+ .withLogConsumer(new Consumer<OutputFrame>() {
+ @Override
+ public void accept(OutputFrame outputFrame) {
+ System.out.println(outputFrame.getUtf8String());
Review comment:
Maybe this should be replaced by slf4j ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on a change in pull request
#1031: Fix intermittent failure of messaging tests
Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on a change in pull request #1031: Fix intermittent failure of messaging tests
URL: https://github.com/apache/camel-quarkus/pull/1031#discussion_r403102288
##########
File path: integration-tests/messaging/src/test/java/org/apache/camel/quarkus/component/messaging/it/ActiveMQTestResource.java
##########
@@ -43,6 +45,13 @@
try {
container = new GenericContainer(ACTIVEMQ_IMAGE)
.withExposedPorts(ACTIVEMQ_PORT)
+ .withLogConsumer(new Consumer<OutputFrame>() {
+ @Override
+ public void accept(OutputFrame outputFrame) {
+ System.out.println(outputFrame.getUtf8String());
Review comment:
> I can remove the logging altogether if you'd prefer. It's just useful for debugging if we hit issues.
No worries we can keep it, was just wondering if we can make it gogin to the logger so we can control it from properties, but not a huge issue
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] jamesnetherton commented on a change in pull
request #1031: Fix intermittent failure of messaging tests
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on a change in pull request #1031: Fix intermittent failure of messaging tests
URL: https://github.com/apache/camel-quarkus/pull/1031#discussion_r403098962
##########
File path: integration-tests/messaging/src/test/java/org/apache/camel/quarkus/component/messaging/it/ActiveMQTestResource.java
##########
@@ -43,6 +45,13 @@
try {
container = new GenericContainer(ACTIVEMQ_IMAGE)
.withExposedPorts(ACTIVEMQ_PORT)
+ .withLogConsumer(new Consumer<OutputFrame>() {
+ @Override
+ public void accept(OutputFrame outputFrame) {
+ System.out.println(outputFrame.getUtf8String());
Review comment:
I can remove the logging altogether if you'd prefer. It's just useful for debugging if we hit issues.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services