You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2018/11/07 09:45:18 UTC

[GitHub] twalthr commented on a change in pull request #7034: [FLINK-10805] Fix failing end-to-end tests

twalthr commented on a change in pull request #7034: [FLINK-10805] Fix failing end-to-end tests
URL: https://github.com/apache/flink/pull/7034#discussion_r231438175
 
 

 ##########
 File path: flink-end-to-end-tests/test-scripts/test_sql_client.sh
 ##########
 @@ -360,13 +362,14 @@ check_result_hash "SQL Client Kafka" $RESULT "0a1bf8bf716069b7269f575f87a802c0"
 
 echo "Executing SQL: Values -> Elasticsearch (upsert)"
 
-read -r -d '' SQL_STATEMENT_3 << EOF
 
 Review comment:
   yes, I think he already executed the test with set -e enabled. which we should do in the future.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services