You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/03/02 18:47:21 UTC
[GitHub] [incubator-shardingsphere] kimmking opened a new pull request
#4574: fix issue#4573
kimmking opened a new pull request #4574: fix issue#4573
URL: https://github.com/apache/incubator-shardingsphere/pull/4574
Fixes #4573 & #4306 .
Changes proposed in this pull request:
- Change generated keys to ascending order in two cases.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] codecov-io commented on issue #4574: fix
issue#4573
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4574: fix issue#4573
URL: https://github.com/apache/incubator-shardingsphere/pull/4574#issuecomment-593577596
# [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4574?src=pr&el=h1) Report
> Merging [#4574](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4574?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/b5f754d829062f6431642df22b3cfcf58e52b35d?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4574?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4574 +/- ##
========================================
Coverage 54.8% 54.8%
Complexity 327 327
========================================
Files 967 967
Lines 18019 18019
Branches 3406 3406
========================================
Hits 9875 9875
Misses 7509 7509
Partials 635 635
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4574?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...keygen/GeneratedKeyInsertValuesTokenGenerator.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4574/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLXJld3JpdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nL3Jld3JpdGUvdG9rZW4vZ2VuZXJhdG9yL2ltcGwva2V5Z2VuL0dlbmVyYXRlZEtleUluc2VydFZhbHVlc1Rva2VuR2VuZXJhdG9yLmphdmE=) | `90% <100%> (ø)` | `1 <0> (ø)` | :arrow_down: |
| [...rdingGeneratedKeyInsertValueParameterRewriter.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4574/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLXJld3JpdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nL3Jld3JpdGUvcGFyYW1ldGVyL2ltcGwvU2hhcmRpbmdHZW5lcmF0ZWRLZXlJbnNlcnRWYWx1ZVBhcmFtZXRlclJld3JpdGVyLmphdmE=) | `93.75% <100%> (ø)` | `1 <0> (ø)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4574?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4574?src=pr&el=footer). Last update [b5f754d...ea58d88](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4574?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] kimmking closed pull request #4574: fix
issue#4573
Posted by GitBox <gi...@apache.org>.
kimmking closed pull request #4574: fix issue#4573
URL: https://github.com/apache/incubator-shardingsphere/pull/4574
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] kimmking commented on issue #4574: fix
issue#4573
Posted by GitBox <gi...@apache.org>.
kimmking commented on issue #4574: fix issue#4573
URL: https://github.com/apache/incubator-shardingsphere/pull/4574#issuecomment-595020621
Closed it util an investigation completed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #4574: fix
issue#4573
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #4574: fix issue#4573
URL: https://github.com/apache/incubator-shardingsphere/pull/4574#issuecomment-593575878
## Pull Request Test Coverage Report for [Build 55](https://coveralls.io/builds/29081215)
* **2** of **2** **(100.0%)** changed or added relevant lines in **2** files are covered.
* **2** unchanged lines in **1** file lost coverage.
* Overall coverage increased (+**0.01%**) to **58.405%**
---
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java](https://coveralls.io/builds/29081215/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Futil%2FIpUtils.java#L72) | 2 | 80.0% |
<!-- | **Total:** | **2** | | -->
| Totals | [](https://coveralls.io/builds/29081215) |
| :-- | --: |
| Change from base [Build 9964](https://coveralls.io/builds/29071225): | 0.01% |
| Covered Lines: | 10524 |
| Relevant Lines: | 18019 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue
#4574: fix issue#4573
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #4574: fix issue#4573
URL: https://github.com/apache/incubator-shardingsphere/pull/4574#issuecomment-593575878
## Pull Request Test Coverage Report for [Build 9969](https://coveralls.io/builds/29081526)
* **2** of **2** **(100.0%)** changed or added relevant lines in **2** files are covered.
* No unchanged relevant lines lost coverage.
* Overall coverage remained the same at **58.394%**
---
| Totals | [](https://coveralls.io/builds/29081526) |
| :-- | --: |
| Change from base [Build 9964](https://coveralls.io/builds/29071225): | 0.0% |
| Covered Lines: | 10522 |
| Relevant Lines: | 18019 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services