You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2020/07/14 01:49:36 UTC

[GitHub] [servicecomb-java-chassis] cmkcmk181 opened a new pull request #1882: 1.支持json嵌套 2.支持yaml及properties格式

cmkcmk181 opened a new pull request #1882:
URL: https://github.com/apache/servicecomb-java-chassis/pull/1882


   Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
    - [ ] Each commit in the pull request should have a meaningful subject line and body.
    - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue.
    - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
    - [ ] Run `mvn clean install -Pit` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   ---
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] liubao68 commented on a change in pull request #1882: 1.支持json嵌套 2.支持yaml及properties格式

Posted by GitBox <gi...@apache.org>.
liubao68 commented on a change in pull request #1882:
URL: https://github.com/apache/servicecomb-java-chassis/pull/1882#discussion_r454124502



##########
File path: dynamic-config/config-nacos/src/main/java/org/apache/servicecomb/config/nacos/archaius/sources/NacosConfigurationSourceImpl.java
##########
@@ -41,96 +41,96 @@
 import com.netflix.config.WatchedUpdateResult;
 
 public class NacosConfigurationSourceImpl implements ConfigCenterConfigurationSource {
-  private static final Logger LOGGER = LoggerFactory.getLogger(ConfigCenterConfigurationSource.class);
+    private static final Logger LOGGER = LoggerFactory.getLogger(ConfigCenterConfigurationSource.class);

Review comment:
       This project using google code style, maybe you need to add it to your editor. For IDEA and eclipse, this file is in $java-chassis/etc folder.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] liubao68 commented on a change in pull request #1882: 1.支持json嵌套 2.支持yaml及properties格式

Posted by GitBox <gi...@apache.org>.
liubao68 commented on a change in pull request #1882:
URL: https://github.com/apache/servicecomb-java-chassis/pull/1882#discussion_r454129936



##########
File path: dynamic-config/config-nacos/src/main/java/org/apache/servicecomb/config/nacos/archaius/sources/NacosConfigurationSourceImpl.java
##########
@@ -41,96 +41,96 @@
 import com.netflix.config.WatchedUpdateResult;
 
 public class NacosConfigurationSourceImpl implements ConfigCenterConfigurationSource {
-  private static final Logger LOGGER = LoggerFactory.getLogger(ConfigCenterConfigurationSource.class);
+    private static final Logger LOGGER = LoggerFactory.getLogger(ConfigCenterConfigurationSource.class);

Review comment:
       Seems travis CI got some problem. You can first fix code style problem and submit a commit direct to this PR, the CI will be retriggerd . 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] liubao68 commented on pull request #1882: [SCB-2041]nacos module support json/yaml/properties format

Posted by GitBox <gi...@apache.org>.
liubao68 commented on pull request #1882:
URL: https://github.com/apache/servicecomb-java-chassis/pull/1882#issuecomment-670404335


   Fixed in https://github.com/apache/servicecomb-java-chassis/pull/1911


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] liubao68 commented on a change in pull request #1882: 1.支持json嵌套 2.支持yaml及properties格式

Posted by GitBox <gi...@apache.org>.
liubao68 commented on a change in pull request #1882:
URL: https://github.com/apache/servicecomb-java-chassis/pull/1882#discussion_r454129936



##########
File path: dynamic-config/config-nacos/src/main/java/org/apache/servicecomb/config/nacos/archaius/sources/NacosConfigurationSourceImpl.java
##########
@@ -41,96 +41,96 @@
 import com.netflix.config.WatchedUpdateResult;
 
 public class NacosConfigurationSourceImpl implements ConfigCenterConfigurationSource {
-  private static final Logger LOGGER = LoggerFactory.getLogger(ConfigCenterConfigurationSource.class);
+    private static final Logger LOGGER = LoggerFactory.getLogger(ConfigCenterConfigurationSource.class);

Review comment:
       Seems travis CI got some problem. You can first fix code style problem and submit a commit direct to this PR, the CI will be retriggerd .  Because you used the wrong formatter, this makes it a bit more difficult review code in github. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] liubao68 closed pull request #1882: [SCB-2041]nacos module support json/yaml/properties format

Posted by GitBox <gi...@apache.org>.
liubao68 closed pull request #1882:
URL: https://github.com/apache/servicecomb-java-chassis/pull/1882


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org