You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "yuemingming (GitHub)" <gi...@apache.org> on 2019/01/22 11:57:46 UTC
[GitHub] [incubator-dubbo-website] yuemingming opened pull request
#257: fix typos
https://github.com/apache/incubator-dubbo/issues/3308
[ Full content available at: https://github.com/apache/incubator-dubbo-website/pull/257 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo-website] ralf0131 commented on issue #257:
fix typos
Posted by "ralf0131 (GitHub)" <gi...@apache.org>.
> Hey, I understand, I need to modify the .md file in the project instead of modifying the .html file. Do I need to roll back the .html file and submit the .md changes?
@yuemingming Yes, please, or you can close this pr and create another one.
[ Full content available at: https://github.com/apache/incubator-dubbo-website/pull/257 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo-website] lixiaojiee commented on issue
#257: fix typos
Posted by "lixiaojiee (GitHub)" <gi...@apache.org>.
> Sorry, I missed one comment, please do not update the html files, instead, please update the markdown files.
OH~~~ my fault ,I doesn't realize that. @yuemingming the markdown file path is
docs/zh-cn/dev/principals/code-detail.md
> Sorry, I missed one comment, please do not update the html files, instead, please update the markdown files.
Oh~~~,I'm so sorry I don't realize it , @yuemingming would you please fix them again in blow files?
docs/zh-cn/dev/principals/robustness.md
docs/zh-cn/dev/principals/code-detail.md
[ Full content available at: https://github.com/apache/incubator-dubbo-website/pull/257 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo-website] lixiaojiee commented on pull
request #257: fix typos
Posted by "lixiaojiee (GitHub)" <gi...@apache.org>.
```suggestion
<p>目前服务注册中心使用了数据库来保存服务提供者和消费者的信息。注册中心集群不同注册中心也通过数据库来进行同步数据，以感知其它注册中心上提供者的变化。注册中心会在内存中保存一份提供者和消费者数据，数据库不可用时，注册中心独立对外提供服务以保证正常运转，只是拿不到其它注册中心的数据。当数据库恢复时，重试逻辑会将内存中修改的数据写回数据库，并拿到数据库中新数据。</p>
```
[ Full content available at: https://github.com/apache/incubator-dubbo-website/pull/257 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo-website] lixiaojiee commented on pull
request #257: fix typos
Posted by "lixiaojiee (GitHub)" <gi...@apache.org>.
```suggestion
<p>服务消费者从注册中心拿到提供者列表后，会保存提供者列表到内存和磁盘文件中。这样注册中心宕机后消费者可以正常运转，甚至可以在注册中心宕机过程中重启消费者。消费者启动时，发现注册中心不可用，会读取保存在磁盘文件中提供者列表。重试逻辑保证注册中心恢复后，更新信息。</p>
```
[ Full content available at: https://github.com/apache/incubator-dubbo-website/pull/257 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo-website] yuemingming commented on issue
#257: fix typos
Posted by "yuemingming (GitHub)" <gi...@apache.org>.
Hey, I understand, I need to modify the .md file in the project instead of modifying the .xml file. Do I need to roll back the .html file and submit the .md changes?
[ Full content available at: https://github.com/apache/incubator-dubbo-website/pull/257 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo-website] yuemingming commented on issue
#257: fix typos
Posted by "yuemingming (GitHub)" <gi...@apache.org>.
> Sorry, I missed one comment, please do not update the html files, instead, please update the markdown files.
Sorry,I didn't understand the meaning. I did not see the .md file
[ Full content available at: https://github.com/apache/incubator-dubbo-website/pull/257 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo-website] lixiaojiee commented on pull
request #257: fix typos
Posted by "lixiaojiee (GitHub)" <gi...@apache.org>.
```suggestion
<p>这是我最不喜欢看到的异常，尤其在核心框架中，我更愿看到信息详细的参数不合法异常。这也是一个程序应有的健壮性，也是在写每一行代码都应在潜意识中防止的异常。基本上要能确保一次写完的代码，在不测试的情况，都不会出现这两个异常才算合格。</p>
```
[ Full content available at: https://github.com/apache/incubator-dubbo-website/pull/257 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo-website] lixiaojiee commented on pull
request #257: fix typos
Posted by "lixiaojiee (GitHub)" <gi...@apache.org>.
```suggestion
<p>最近一直担心如果 Dubbo 分布式服务框架维护人员增多或变更，会出现质量的下降的问题，我在想，有没有什么规则是需要大家共同遵守的，根据平时写代码时的一些习惯，总结了以下在写代码过程中，尤其是框架代码，要时刻牢记的细节。可能下面要讲的这些，大家都会觉得很简单、很基础，但是要做到时刻牢记。在每一行代码中都考虑这些因素，是需要很大耐心的， 大家经常说，魔鬼在细节中，确实如此。</p>
```
[ Full content available at: https://github.com/apache/incubator-dubbo-website/pull/257 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo-website] yuemingming commented on issue
#257: fix typos
Posted by "yuemingming (GitHub)" <gi...@apache.org>.
Hey, I understand, I need to modify the .md file in the project instead of modifying the .html file. Do I need to roll back the .html file and submit the .md changes?
[ Full content available at: https://github.com/apache/incubator-dubbo-website/pull/257 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo-website] lixiaojiee commented on issue
#257: fix typos
Posted by "lixiaojiee (GitHub)" <gi...@apache.org>.
> Sorry, I missed one comment, please do not update the html files, instead, please update the markdown files.
OH~~~ my fault ,I doesn't realize that. @yuemingming the markdown file path is
docs/zh-cn/dev/principals/code-detail.md
> Sorry, I missed one comment, please do not update the html files, instead, please update the markdown files.
Oh~~~,I'm so sorry I don't realize it , @yuemingming would you please fix them again in blow files?
docs/zh-cn/dev/principals/robustness.md
docs/zh-cn/dev/principals/code-detail.md
**and rollback the previous submission**
[ Full content available at: https://github.com/apache/incubator-dubbo-website/pull/257 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo-website] yuemingming closed pull request
#257: fix typos
Posted by "yuemingming (GitHub)" <gi...@apache.org>.
[ pull request closed by yuemingming ]
[ Full content available at: https://github.com/apache/incubator-dubbo-website/pull/257 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo-website] yuemingming commented on issue
#257: fix typos
Posted by "yuemingming (GitHub)" <gi...@apache.org>.
I will close this pr and create another one.
[ Full content available at: https://github.com/apache/incubator-dubbo-website/pull/257 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org