You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by "vihangk1 (via GitHub)" <gi...@apache.org> on 2023/01/27 01:02:59 UTC
[GitHub] [hive] vihangk1 opened a new pull request, #3989: HIVE-26948: Backport HIVE-21456 to branch-3
vihangk1 opened a new pull request, #3989:
URL: https://github.com/apache/hive/pull/3989
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/Hive/HowToContribute
2. Ensure that you have created an issue on the Hive project JIRA: https://issues.apache.org/jira/projects/HIVE/summary
3. Ensure you have added or run the appropriate tests for your PR:
4. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]HIVE-XXXXX: Your PR title ...'.
5. Be sure to keep the PR description updated to reflect all changes.
6. Please write your PR title to summarize what this PR proposes.
7. If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
This PR backports HIVE-21456 to branch-3. To resolve some conflicts, following changes were done in addition to the original PR when compared to the master branch.
1. pom.xml --> updates the httpcomponents library version to 4.4.13 which is same as in master branch.
2. TestSSL --> All the tests are originally marked as Ignored before this PR. This PR marks individual tests in the suite as Ignored to keep the same behavior as before and then adds a new additional test which works for http metastore client.
### Why are the changes needed?
Backport http transport support for Hive metastore in branch-3 so that users don't have to do a major upgrade to get this improvement.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Backported the tests from the original PR and made sure that they work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] vihangk1 commented on pull request #3989: HIVE-26948: Backport HIVE-21456 to branch-3
Posted by "vihangk1 (via GitHub)" <gi...@apache.org>.
vihangk1 commented on PR #3989:
URL: https://github.com/apache/hive/pull/3989#issuecomment-1424637771
Thanks @amanraj2520. Sorry I was referring to the [previous test run](http://ci.hive.apache.org/blue/organizations/jenkins/hive-precommit/detail/PR-3989/4/tests) for this PR. But the latest one passes that test. I cannot repro `TestRpc` and the [previous precommit run](http://ci.hive.apache.org/blue/organizations/jenkins/hive-precommit/detail/PR-3989/5/tests) on the same commit pass that test. So I think we should mark that test as flaky and disable it. I created https://issues.apache.org/jira/browse/HIVE-27062 sub-task to disable that test to ensure a green build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] vihangk1 commented on pull request #3989: HIVE-26948: Backport HIVE-21456 to branch-3
Posted by "vihangk1 (via GitHub)" <gi...@apache.org>.
vihangk1 commented on PR #3989:
URL: https://github.com/apache/hive/pull/3989#issuecomment-1418328973
Thanks @sourabh912 for the review. The test failure `TestObjectStore` looks like infra issue. I will retrigger the tests to make sure. Confirmed that the test works for me locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] vihangk1 commented on pull request #3989: HIVE-26948: Backport HIVE-21456 to branch-3
Posted by "vihangk1 (via GitHub)" <gi...@apache.org>.
vihangk1 commented on PR #3989:
URL: https://github.com/apache/hive/pull/3989#issuecomment-1407112264
The new failing test is probably due to infra issue. It works for me.
`[INFO] -------------------------------------------------------
[INFO] T E S T S
[INFO] -------------------------------------------------------
[INFO] Running org.apache.hadoop.hive.ql.parse.TestParseDriver
[INFO] Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.709 s - in org.apache.hadoop.hive.ql.parse.TestParseDriver
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 9, Failures: 0, Errors: 0, Skipped: 0`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] amanraj2520 commented on pull request #3989: HIVE-26948: Backport HIVE-21456 to branch-3
Posted by "amanraj2520 (via GitHub)" <gi...@apache.org>.
amanraj2520 commented on PR #3989:
URL: https://github.com/apache/hive/pull/3989#issuecomment-1407229313
Hi @vihangk1 I see this new failures in the latest run testExoticSJSSubQuery
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] amanraj2520 commented on pull request #3989: HIVE-26948: Backport HIVE-21456 to branch-3
Posted by "amanraj2520 (via GitHub)" <gi...@apache.org>.
amanraj2520 commented on PR #3989:
URL: https://github.com/apache/hive/pull/3989#issuecomment-1423610696
@vihangk1 I do not see any failure related to TestObjectStore in the latest run http://ci.hive.apache.org/blue/organizations/jenkins/hive-precommit/detail/PR-3989/6/tests. Do you mean the TestRpc timeout issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] vihangk1 commented on pull request #3989: HIVE-26948: Backport HIVE-21456 to branch-3
Posted by "vihangk1 (via GitHub)" <gi...@apache.org>.
vihangk1 commented on PR #3989:
URL: https://github.com/apache/hive/pull/3989#issuecomment-1406935430
The job says "There are 0 new tests failing, 21 existing failing and 261 skipped." so I think these are all previously failing tests. @amanraj2520 Any idea if these tests are known failures or not? Also, can you review this PR for branch-3?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] vihangk1 commented on pull request #3989: HIVE-26948: Backport HIVE-21456 to branch-3
Posted by "vihangk1 (via GitHub)" <gi...@apache.org>.
vihangk1 commented on PR #3989:
URL: https://github.com/apache/hive/pull/3989#issuecomment-1487967234
Merged this. Thanks for your reviews and comments @sourabh912 @amanraj2520 @zabetak
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] vihangk1 commented on pull request #3989: HIVE-26948: Backport HIVE-21456 to branch-3
Posted by "vihangk1 (via GitHub)" <gi...@apache.org>.
vihangk1 commented on PR #3989:
URL: https://github.com/apache/hive/pull/3989#issuecomment-1407257143
@amanraj2520 I ran the test multiple times locally and it did not fail. Also, looks unrelated to my PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sourabh912 commented on pull request #3989: HIVE-26948: Backport HIVE-21456 to branch-3
Posted by "sourabh912 (via GitHub)" <gi...@apache.org>.
sourabh912 commented on PR #3989:
URL: https://github.com/apache/hive/pull/3989#issuecomment-1418308100
Thanks @vihangk1 for the PR. I took a quick look and it looks good to me. +1 from my side.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] amanraj2520 commented on pull request #3989: HIVE-26948: Backport HIVE-21456 to branch-3
Posted by "amanraj2520 (via GitHub)" <gi...@apache.org>.
amanraj2520 commented on PR #3989:
URL: https://github.com/apache/hive/pull/3989#issuecomment-1407257747
@vihangk1 Then the remaining test failures are because of the existing problems in branch-3 which I am fixing. So we are good as far as the test failures for this PR is concerned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] zabetak commented on pull request #3989: HIVE-26948: Backport HIVE-21456 to branch-3
Posted by "zabetak (via GitHub)" <gi...@apache.org>.
zabetak commented on PR #3989:
URL: https://github.com/apache/hive/pull/3989#issuecomment-1408302382
@vihangk1 I would prefer if @sourabh912 reviews the changes here since he is the author of the original patch; I will +1 if he does!
In terms of process, I would prefer if we don't backport other changes till the build is stabilized; there are many times were failures seem unrelated to a specific PR but in practice they are not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] vihangk1 commented on pull request #3989: HIVE-26948: Backport HIVE-21456 to branch-3
Posted by "vihangk1 (via GitHub)" <gi...@apache.org>.
vihangk1 commented on PR #3989:
URL: https://github.com/apache/hive/pull/3989#issuecomment-1409018555
Thanks @zabetak, I am not sure if @sourabh912 is actively monitoring PRs in Hive, but I can reach out to him. Since this is not really a new code but a backport of the master branch, I feel this is still pretty low risk. Almost all the new code in this PR is under a config flag which is disabled by default. Additionally, @amanraj2520 confirmed that all the tests which are failing are known test failures.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] vihangk1 commented on pull request #3989: HIVE-26948: Backport HIVE-21456 to branch-3
Posted by "vihangk1 (via GitHub)" <gi...@apache.org>.
vihangk1 commented on PR #3989:
URL: https://github.com/apache/hive/pull/3989#issuecomment-1423297542
@amanraj2520 Do you know if the TestObjectStore which fails above with timeout issues is a known issue? I cannot reproduce it locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] vihangk1 merged pull request #3989: HIVE-26948: Backport HIVE-21456 to branch-3
Posted by "vihangk1 (via GitHub)" <gi...@apache.org>.
vihangk1 merged PR #3989:
URL: https://github.com/apache/hive/pull/3989
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org