You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Jonathan Hurley <jh...@hortonworks.com> on 2017/05/09 21:07:16 UTC

Review Request 59112: Repository Resource Providers Should Expose the Repository ID by Default on Minimal Responses

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59112/
-----------------------------------------------------------

Review request for Ambari, Dmitro Lisnichenko and Nate Cole.


Bugs: AMBARI-20971
    https://issues.apache.org/jira/browse/AMBARI-20971


Repository: ambari


Description
-------

There are 3 resource providers which should begin exposed the repository ID by default on all responses, even minimal responses:

- {{RepositoryResourceProvider}}
- {{RespositoryVersionResourceProvider}}
- {{CompatibleRepositoryVersionResourceProvider}}

This will allow anyone querying these endpoints to reference a repository uniquely, instead of by version.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractAuthorizedResourceProvider.java 92a7256 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java a27a5d0 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CompatibleRepositoryVersionResourceProvider.java 98b91b3 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ReadOnlyResourceProvider.java 342983f 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryResourceProvider.java 6665087 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java a0a3666 


Diff: https://reviews.apache.org/r/59112/diff/1/


Testing
-------

PENDING


Thanks,

Jonathan Hurley


Re: Review Request 59112: Repository Resource Providers Should Expose the Repository ID by Default on Minimal Responses

Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59112/#review174464
-----------------------------------------------------------


Ship it!




Ship It!

- Nate Cole


On May 9, 2017, 5:07 p.m., Jonathan Hurley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59112/
> -----------------------------------------------------------
> 
> (Updated May 9, 2017, 5:07 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Nate Cole.
> 
> 
> Bugs: AMBARI-20971
>     https://issues.apache.org/jira/browse/AMBARI-20971
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> There are 3 resource providers which should begin exposed the repository ID by default on all responses, even minimal responses:
> 
> - {{RepositoryResourceProvider}}
> - {{RespositoryVersionResourceProvider}}
> - {{CompatibleRepositoryVersionResourceProvider}}
> 
> This will allow anyone querying these endpoints to reference a repository uniquely, instead of by version.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractAuthorizedResourceProvider.java 92a7256 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java a27a5d0 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CompatibleRepositoryVersionResourceProvider.java 98b91b3 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ReadOnlyResourceProvider.java 342983f 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryResourceProvider.java 6665087 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java a0a3666 
> 
> 
> Diff: https://reviews.apache.org/r/59112/diff/1/
> 
> 
> Testing
> -------
> 
> PENDING
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>


Re: Review Request 59112: Repository Resource Providers Should Expose the Repository ID by Default on Minimal Responses

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59112/#review174446
-----------------------------------------------------------


Ship it!




Ship It!

- Dmitro Lisnichenko


On May 10, 2017, 12:07 a.m., Jonathan Hurley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59112/
> -----------------------------------------------------------
> 
> (Updated May 10, 2017, 12:07 a.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Nate Cole.
> 
> 
> Bugs: AMBARI-20971
>     https://issues.apache.org/jira/browse/AMBARI-20971
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> There are 3 resource providers which should begin exposed the repository ID by default on all responses, even minimal responses:
> 
> - {{RepositoryResourceProvider}}
> - {{RespositoryVersionResourceProvider}}
> - {{CompatibleRepositoryVersionResourceProvider}}
> 
> This will allow anyone querying these endpoints to reference a repository uniquely, instead of by version.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractAuthorizedResourceProvider.java 92a7256 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java a27a5d0 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CompatibleRepositoryVersionResourceProvider.java 98b91b3 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ReadOnlyResourceProvider.java 342983f 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryResourceProvider.java 6665087 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java a0a3666 
> 
> 
> Diff: https://reviews.apache.org/r/59112/diff/1/
> 
> 
> Testing
> -------
> 
> PENDING
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>


Re: Review Request 59112: Repository Resource Providers Should Expose the Repository ID by Default on Minimal Responses

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59112/#review174512
-----------------------------------------------------------


Ship it!




Ship It!

- Alejandro Fernandez


On May 9, 2017, 9:07 p.m., Jonathan Hurley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59112/
> -----------------------------------------------------------
> 
> (Updated May 9, 2017, 9:07 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Nate Cole.
> 
> 
> Bugs: AMBARI-20971
>     https://issues.apache.org/jira/browse/AMBARI-20971
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> There are 3 resource providers which should begin exposed the repository ID by default on all responses, even minimal responses:
> 
> - {{RepositoryResourceProvider}}
> - {{RespositoryVersionResourceProvider}}
> - {{CompatibleRepositoryVersionResourceProvider}}
> 
> This will allow anyone querying these endpoints to reference a repository uniquely, instead of by version.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractAuthorizedResourceProvider.java 92a7256 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java a27a5d0 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CompatibleRepositoryVersionResourceProvider.java 98b91b3 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ReadOnlyResourceProvider.java 342983f 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryResourceProvider.java 6665087 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java a0a3666 
> 
> 
> Diff: https://reviews.apache.org/r/59112/diff/1/
> 
> 
> Testing
> -------
> 
> PENDING
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>