[GitHub] [hadoop] ayushtkn commented on a diff in pull request #5572: HDFS-16981. Support getFileLinkStatus API in WebHDFS

["ayushtkn (via GitHub)" <gi...@apache.org>]

ayushtkn commented on code in PR #5572:
URL: https://github.com/apache/hadoop/pull/5572#discussion_r1173553320


##########
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/TestWebHDFS.java:
##########
@@ -2230,6 +2230,25 @@ public void testLinkTarget() throws Exception {
     }
   }
 
+  @Test
+  public void testFileLinkStatus() throws Exception {
+    final Configuration conf = WebHdfsTestUtil.createConf();
+    cluster = new MiniDFSCluster.Builder(conf).numDataNodes(3).build();

Review Comment:
   Use try with resources  & you don't need 3 datanodes, 1 datanode is enough and that is by default, you can drop `` .numDataNodes(3)``



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org