You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2023/03/05 16:20:35 UTC
[kudu-CR] [codegen] fix build on Ubuntu 22.04
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19582
Change subject: [codegen] fix build on Ubuntu 22.04
......................................................................
[codegen] fix build on Ubuntu 22.04
Change-Id: If65f02b169098afec0d5682a7be6066568420982
---
M src/kudu/codegen/CMakeLists.txt
1 file changed, 41 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/82/19582/1
--
To view, visit http://gerrit.cloudera.org:8080/19582
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If65f02b169098afec0d5682a7be6066568420982
Gerrit-Change-Number: 19582
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
[kudu-CR] [codegen] fix build on Ubuntu 22.04
Posted by "Ashwani Raina (Code Review)" <ge...@cloudera.org>.
Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/19582 )
Change subject: [codegen] fix build on Ubuntu 22.04
......................................................................
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/19582/1/src/kudu/codegen/CMakeLists.txt
File src/kudu/codegen/CMakeLists.txt:
http://gerrit.cloudera.org:8080/#/c/19582/1/src/kudu/codegen/CMakeLists.txt@111
PS1, Line 111: The relevant part of the output looks like the following:
nit: Maybe you could also point that the output is from Ubuntu 22.04.
And similar looking output would be on other flavours as well.
http://gerrit.cloudera.org:8080/#/c/19582/1/src/kudu/codegen/CMakeLists.txt@133
PS1, Line 133: Use only the first two include paths
Is there a remote chance that first paths are not the ones that we are interested in?
I mean is it possible to have an output with include directories in different order ?
e.g. something like this:
+++
# /usr/include
# /usr/local/include
# /usr/include/x86_64-linux-gnu
# /usr/include/c++/11
# /usr/include/x86_64-linux-gnu/c++/11
# /usr/include/c++/11/backward
# /usr/lib/gcc/x86_64-linux-gnu/11/include
+++
In such a case, wouldn't this assumption fail?
http://gerrit.cloudera.org:8080/#/c/19582/1/src/kudu/codegen/CMakeLists.txt@145
PS1, Line 145: PREFIXED_IR_INCLUDES
Not a comment:
This looks like a better idea. Appending include directories to PREFIXED_IR_INCLUDES is certainly a cleaner approach than setting the path in include_directories.
--
To view, visit http://gerrit.cloudera.org:8080/19582
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If65f02b169098afec0d5682a7be6066568420982
Gerrit-Change-Number: 19582
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Mon, 06 Mar 2023 10:31:46 +0000
Gerrit-HasComments: Yes
[kudu-CR] [codegen] fix build on Ubuntu 22.04
Posted by "Ashwani Raina (Code Review)" <ge...@cloudera.org>.
Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/19582 )
Change subject: [codegen] fix build on Ubuntu 22.04
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/19582
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If65f02b169098afec0d5682a7be6066568420982
Gerrit-Change-Number: 19582
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Tue, 07 Mar 2023 15:09:29 +0000
Gerrit-HasComments: No
[kudu-CR] [codegen] fix build on Ubuntu 22.04
Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19582 )
Change subject: [codegen] fix build on Ubuntu 22.04
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/19582
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If65f02b169098afec0d5682a7be6066568420982
Gerrit-Change-Number: 19582
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Fri, 10 Mar 2023 03:47:57 +0000
Gerrit-HasComments: No
[kudu-CR] [codegen] fix build on Ubuntu 22.04
Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19582 )
Change subject: [codegen] fix build on Ubuntu 22.04
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/19582
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If65f02b169098afec0d5682a7be6066568420982
Gerrit-Change-Number: 19582
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Mon, 06 Mar 2023 08:43:44 +0000
Gerrit-HasComments: No
[kudu-CR] [codegen] fix build on Ubuntu 22.04
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19582 )
Change subject: [codegen] fix build on Ubuntu 22.04
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/19582/1//COMMIT_MSG
Commit Message:
PS1:
As for functionality on Ubuntu 22.04, it seems some fixes are necessary to update linker options, otherwise at least libdl isn't linked as necessary, so dlopen could not be resolved in some test binaries.
--
To view, visit http://gerrit.cloudera.org:8080/19582
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If65f02b169098afec0d5682a7be6066568420982
Gerrit-Change-Number: 19582
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Mon, 06 Mar 2023 04:14:14 +0000
Gerrit-HasComments: Yes
[kudu-CR] [codegen] fix build on Ubuntu 22.04
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19582 )
Change subject: [codegen] fix build on Ubuntu 22.04
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/19582/1/src/kudu/codegen/CMakeLists.txt
File src/kudu/codegen/CMakeLists.txt:
http://gerrit.cloudera.org:8080/#/c/19582/1/src/kudu/codegen/CMakeLists.txt@133
PS1, Line 133: Use only the first two include paths
> Is there a remote chance that first paths are not the ones that we are inte
These paths are listed in the 'search path' preference, where paths/locations specific to particular compiler version always come first. By my understanding, there isn't a chance to have something like you mentioned above.
--
To view, visit http://gerrit.cloudera.org:8080/19582
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If65f02b169098afec0d5682a7be6066568420982
Gerrit-Change-Number: 19582
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Mon, 06 Mar 2023 19:39:11 +0000
Gerrit-HasComments: Yes
[kudu-CR] [codegen] fix build on Ubuntu 22.04
Posted by "Wang Xixu (Code Review)" <ge...@cloudera.org>.
Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19582 )
Change subject: [codegen] fix build on Ubuntu 22.04
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/19582
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If65f02b169098afec0d5682a7be6066568420982
Gerrit-Change-Number: 19582
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Wed, 08 Mar 2023 09:18:19 +0000
Gerrit-HasComments: No
[kudu-CR] [codegen] fix build on Ubuntu 22.04
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [codegen] fix build on Ubuntu 22.04
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/19582
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: If65f02b169098afec0d5682a7be6066568420982
Gerrit-Change-Number: 19582
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
[kudu-CR] [codegen] fix build on Ubuntu 22.04
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19582 )
Change subject: [codegen] fix build on Ubuntu 22.04
......................................................................
Patch Set 1: Verified+1
unrelated test failure in DeleteTabletITest.TestLeaderElectionDuringDeleteTablet
--
To view, visit http://gerrit.cloudera.org:8080/19582
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If65f02b169098afec0d5682a7be6066568420982
Gerrit-Change-Number: 19582
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Mon, 06 Mar 2023 04:12:37 +0000
Gerrit-HasComments: No
[kudu-CR] [codegen] fix build on Ubuntu 22.04
Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Yifan Zhang has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19582 )
Change subject: [codegen] fix build on Ubuntu 22.04
......................................................................
[codegen] fix build on Ubuntu 22.04
Change-Id: If65f02b169098afec0d5682a7be6066568420982
Reviewed-on: http://gerrit.cloudera.org:8080/19582
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Ashwani Raina <ar...@cloudera.com>
Reviewed-by: Wang Xixu <14...@qq.com>
Reviewed-by: Yifan Zhang <ch...@163.com>
---
M src/kudu/codegen/CMakeLists.txt
1 file changed, 41 insertions(+), 0 deletions(-)
Approvals:
Alexey Serbin: Verified
Ashwani Raina: Looks good to me, but someone else must approve
Wang Xixu: Looks good to me, but someone else must approve
Yifan Zhang: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/19582
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If65f02b169098afec0d5682a7be6066568420982
Gerrit-Change-Number: 19582
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>