You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "leaves12138 (via GitHub)" <gi...@apache.org> on 2023/08/31 07:49:02 UTC
[GitHub] [incubator-paimon] leaves12138 opened a new pull request, #1929: [test] add wait time for runnable in thread pool
leaves12138 opened a new pull request, #1929:
URL: https://github.com/apache/incubator-paimon/pull/1929
Add wait time for runnable in thread pool, the last runnable may not be stopped by shutdown.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] JingsongLi commented on pull request #1929: [test] add wait time for runnable in thread pool
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on PR #1929:
URL: https://github.com/apache/incubator-paimon/pull/1929#issuecomment-1700901592
> > Thanks @leaves12138 for your contribution.
> > But can you explain what is the problem?
> > > the last runnable may not be stopped by shutdown.
> >
> >
> > So what?
>
> When executorPool called shutdown, maybe there is a runnable thread in thread pool, and have not get some place to handle InterruptedException. Then it will still hold the open output stream. The method `TableTestBase.after` will check if all the output streams are closed. It will throw an assert exception.
I still cannot get it. Are there some cases fail?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] JingsongLi merged pull request #1929: [test] add wait time for runnable in thread pool
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi merged PR #1929:
URL: https://github.com/apache/incubator-paimon/pull/1929
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] leaves12138 commented on pull request #1929: [test] add wait time for runnable in thread pool
Posted by "leaves12138 (via GitHub)" <gi...@apache.org>.
leaves12138 commented on PR #1929:
URL: https://github.com/apache/incubator-paimon/pull/1929#issuecomment-1701226813
> > > Thanks @leaves12138 for your contribution.
> > > But can you explain what is the problem?
> > > > the last runnable may not be stopped by shutdown.
> > >
> > >
> > > So what?
> >
> >
> > When executorPool called shutdown, maybe there is a runnable thread in thread pool, and have not get some place to handle InterruptedException. Then it will still hold the open output stream. The method `TableTestBase.after` will check if all the output streams are closed. It will throw an assert exception.
>
> I still cannot get it. Are there some cases fail?
occasionally,

This may throws en error, because there is still one thread running in thread pool occupied an output stream or input stream
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] JingsongLi commented on pull request #1929: [test] add wait time for runnable in thread pool
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on PR #1929:
URL: https://github.com/apache/incubator-paimon/pull/1929#issuecomment-1700756772
Thanks @leaves12138 for your contribution.
But can you explain what is the problem?
> the last runnable may not be stopped by shutdown.
So what?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] leaves12138 commented on pull request #1929: [test] add wait time for runnable in thread pool
Posted by "leaves12138 (via GitHub)" <gi...@apache.org>.
leaves12138 commented on PR #1929:
URL: https://github.com/apache/incubator-paimon/pull/1929#issuecomment-1700840916
> Thanks @leaves12138 for your contribution.
>
> But can you explain what is the problem?
>
> > the last runnable may not be stopped by shutdown.
>
> So what?
When executorPool called shutdown, maybe there is a runnable thread in thread pool, and have not get some place to handle InterruptedException. Then it will still hold the open output stream. The method `TableTestBase.after` will check if all the output streams are closed. It will throw an assert exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org