You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "IceMimosa (via GitHub)" <gi...@apache.org> on 2023/08/08 03:19:14 UTC
[GitHub] [iotdb] IceMimosa opened a new pull request, #10810: [To Master] Fix the files not being closed after compacting and
IceMimosa opened a new pull request, #10810:
URL: https://github.com/apache/iotdb/pull/10810
## Description
fix #10809
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] xingtanzjr commented on pull request #10810: [To Master] Fix the files not being closed after compacting and deleting
Posted by "xingtanzjr (via GitHub)" <gi...@apache.org>.
xingtanzjr commented on PR #10810:
URL: https://github.com/apache/iotdb/pull/10810#issuecomment-1668985235
Hi @IceMimosa , thanks for reaching out and contributing the PR. Kindly remind that the code should be formatted in order to pass the style check of CI. You can use `mvn spotless::apply` in your local branch and push the changes again.
On the other hand, your fix can solve the problem but the it is not the best way to do resolve the root casue. And we already have another PR https://github.com/apache/iotdb/pull/10688 to fix the same issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou closed pull request #10810: [To Master] Fix the files not being closed after compacting and deleting
Posted by "HTHou (via GitHub)" <gi...@apache.org>.
HTHou closed pull request #10810: [To Master] Fix the files not being closed after compacting and deleting
URL: https://github.com/apache/iotdb/pull/10810
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] IceMimosa commented on pull request #10810: [To Master] Fix the files not being closed after compacting and deleting
Posted by "IceMimosa (via GitHub)" <gi...@apache.org>.
IceMimosa commented on PR #10810:
URL: https://github.com/apache/iotdb/pull/10810#issuecomment-1669042671
@xingtanzjr Thanks for reviewing, this PR will fix `FileReaderManager` reader handles leak after compacting and removing TTL files instead of memory management. If PR #10688 can fix this, you can close this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org