[GitHub] spark pull request #21095: [SPARK-23529][K8s] Support mounting hostPath volu...

[liyinan926 <gi...@git.apache.org>]

Github user liyinan926 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21095#discussion_r185960630
  
    --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesVolumeUtils.scala ---
    @@ -0,0 +1,142 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.spark.deploy.k8s
    +
    +import scala.collection.mutable.HashMap
    +
    +import io.fabric8.kubernetes.api.model._
    +
    +import org.apache.spark.SparkConf
    +import org.apache.spark.deploy.k8s.Config._
    +
    +private[spark] object KubernetesVolumeUtils {
    +
    +  /**
    +   * Given hostPath volume specs, add volume to pod and volume mount to container.
    +   *
    +   * @param pod original specification of the pod
    +   * @param container original specification of the container
    +   * @param sparkConf Spark configuration
    +   * @param prefix the prefix for volume configuration
    +   * @return a tuple of (pod with the volume(s) added, container with mount(s) added)
    +   */
    +  def addVolumes(
    +      pod: Pod,
    +      container: Container,
    +      sparkConf: SparkConf,
    +      prefix : String): (Pod, Container) = {
    +    val hostPathVolumeSpecs = parseHostPathVolumesWithPrefix(sparkConf, prefix)
    +    addHostPathVolumes(pod, container, hostPathVolumeSpecs)
    +  }
    +
    +  /**
    +   * Extract Spark volume configuration properties with a given name prefix.
    +   *
    +   * @param sparkConf Spark configuration
    +   * @param prefix the given property name prefix
    +   * @param volumeTypeKey the given property name prefix
    +   * @return a Map storing with volume name as key and spec as value
    +   */
    +  def parseVolumesWithPrefix(
    +      sparkConf: SparkConf,
    +      prefix: String,
    +      volumeTypeKey: String): Map[String, KubernetesVolumeSpec] = {
    +    val volumes = HashMap[String, KubernetesVolumeSpec]()
    +    val properties = sparkConf.getAllWithPrefix(s"$prefix$volumeTypeKey.").toList
    +    // Extract volume names
    +    properties.foreach {
    +      k =>
    +        val keys = k._1.split("\\.")
    +        if (keys.nonEmpty && !volumes.contains(keys(0))) {
    +          volumes.update(keys(0), KubernetesVolumeSpec.emptySpec())
    +        }
    +    }
    +    // Populate spec
    +    volumes.foreach {
    +      case (name, spec) =>
    --- End diff --
    
    The `case` line should be merged into the previous line according to the Spark code convention, e.g., `volumes.foreach { case (name, spec) =>`. 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org