You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2022/11/13 12:42:04 UTC
[GitHub] [dubbo-go-pixiu] A-Wanderer opened a new pull request, #522: Add GracefulShutdown Signal For Windows
A-Wanderer opened a new pull request, #522:
URL: https://github.com/apache/dubbo-go-pixiu/pull/522
<!-- Thanks for sending a pull request!
-->
**What this PR does**:
**Which issue(s) this PR fixes**:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
-->
Fixes #
**Special notes for your reviewer**:
**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
-->
```release-note
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] sonarcloud[bot] commented on pull request #522: Add GracefulShutdown Signal For Windows
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #522:
URL: https://github.com/apache/dubbo-go-pixiu/pull/522#issuecomment-1321409626
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_dubbo-go-pixiu&pullRequest=522)
[](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=522&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=522&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=522&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=522&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=522&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=522&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go-pixiu&pullRequest=522&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go-pixiu&pullRequest=522&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go-pixiu&pullRequest=522&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=522&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=522&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=522&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu&pullRequest=522) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu&pullRequest=522&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu&pullRequest=522&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] sonarcloud[bot] commented on pull request #522: Add GracefulShutdown Signal For Windows
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #522:
URL: https://github.com/apache/dubbo-go-pixiu/pull/522#issuecomment-1312722122
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_dubbo-go-pixiu&pullRequest=522)
[](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=522&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=522&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=522&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=522&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=522&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=522&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go-pixiu&pullRequest=522&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go-pixiu&pullRequest=522&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go-pixiu&pullRequest=522&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=522&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=522&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=522&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu&pullRequest=522) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu&pullRequest=522&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu&pullRequest=522&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] mark4z commented on pull request #522: Add GracefulShutdown Signal For Windows
Posted by GitBox <gi...@apache.org>.
mark4z commented on PR #522:
URL: https://github.com/apache/dubbo-go-pixiu/pull/522#issuecomment-1319481485
on win10
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter commented on pull request #522: Add GracefulShutdown Signal For Windows
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #522:
URL: https://github.com/apache/dubbo-go-pixiu/pull/522#issuecomment-1312725029
# [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/522?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#522](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/522?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0c76797) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/84affcae0f3d24de022d31f1faffe8630c421d84?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (84affca) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## develop #522 +/- ##
========================================
Coverage 54.68% 54.68%
========================================
Files 666 666
Lines 77865 77865
========================================
+ Hits 42577 42584 +7
+ Misses 31653 31644 -9
- Partials 3635 3637 +2
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/522?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pilot/pkg/config/memory/monitor.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/522/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlsb3QvcGtnL2NvbmZpZy9tZW1vcnkvbW9uaXRvci5nbw==) | `71.79% <0.00%> (-7.70%)` | :arrow_down: |
| [...try/kube/controller/autoserviceexportcontroller.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/522/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlsb3QvcGtnL3NlcnZpY2VyZWdpc3RyeS9rdWJlL2NvbnRyb2xsZXIvYXV0b3NlcnZpY2VleHBvcnRjb250cm9sbGVyLmdv) | `61.11% <0.00%> (-4.17%)` | :arrow_down: |
| [pkg/config/mesh/kubemesh/watcher.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/522/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbmZpZy9tZXNoL2t1YmVtZXNoL3dhdGNoZXIuZ28=) | `67.21% <0.00%> (-3.28%)` | :arrow_down: |
| [security/pkg/nodeagent/sds/sdsservice.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/522/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VjdXJpdHkvcGtnL25vZGVhZ2VudC9zZHMvc2Rzc2VydmljZS5nbw==) | `84.76% <0.00%> (-2.65%)` | :arrow_down: |
| [pkg/istio-agent/xds\_proxy.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/522/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2lzdGlvLWFnZW50L3hkc19wcm94eS5nbw==) | `60.52% <0.00%> (-1.52%)` | :arrow_down: |
| [pilot/pkg/xds/deltaadstest.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/522/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlsb3QvcGtnL3hkcy9kZWx0YWFkc3Rlc3QuZ28=) | `58.51% <0.00%> (-1.49%)` | :arrow_down: |
| [pilot/pkg/xds/discovery.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/522/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlsb3QvcGtnL3hkcy9kaXNjb3ZlcnkuZ28=) | `84.93% <0.00%> (-0.97%)` | :arrow_down: |
| [...g/serviceregistry/kube/controller/endpointslice.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/522/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlsb3QvcGtnL3NlcnZpY2VyZWdpc3RyeS9rdWJlL2NvbnRyb2xsZXIvZW5kcG9pbnRzbGljZS5nbw==) | `73.44% <0.00%> (-0.69%)` | :arrow_down: |
| [pilot/pkg/model/jwks\_resolver.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/522/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlsb3QvcGtnL21vZGVsL2p3a3NfcmVzb2x2ZXIuZ28=) | `79.06% <0.00%> (+0.77%)` | :arrow_up: |
| [pkg/istio-agent/agent.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/522/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2lzdGlvLWFnZW50L2FnZW50Lmdv) | `56.73% <0.00%> (+1.68%)` | :arrow_up: |
| ... and [6 more](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/522/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] mark4z merged pull request #522: Add GracefulShutdown Signal For Windows
Posted by GitBox <gi...@apache.org>.
mark4z merged PR #522:
URL: https://github.com/apache/dubbo-go-pixiu/pull/522
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org