You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/06/18 21:14:10 UTC
[GitHub] [kafka] hachikuji commented on a change in pull request #10900: KAFKA-12967; KRaft broker should forward DescribeQuorum to controller
hachikuji commented on a change in pull request #10900:
URL: https://github.com/apache/kafka/pull/10900#discussion_r654069402
##########
File path: core/src/test/scala/unit/kafka/server/KafkaApisTest.scala
##########
@@ -462,16 +461,55 @@ class KafkaApisTest {
@Test
def testAlterConfigsWithForwarding(): Unit = {
val requestBuilder = new AlterConfigsRequest.Builder(Collections.emptyMap(), false)
- testForwardableAPI(ApiKeys.ALTER_CONFIGS, requestBuilder)
+ testForwardableApi(ApiKeys.ALTER_CONFIGS, requestBuilder)
+ }
+
+ @Test
+ def testDescribeQuorumNotAllowedForZkClusters(): Unit = {
+ val requestData = DescribeQuorumRequest.singletonRequest(KafkaRaftServer.MetadataPartition)
+ val requestBuilder = new DescribeQuorumRequest.Builder(requestData)
+ val request = buildRequest(requestBuilder.build())
+
+ val capturedResponse = expectNoThrottling(request)
+ EasyMock.replay(replicaManager, clientRequestQuotaManager, requestChannel, adminManager, controller)
+ createKafkaApis(enableForwarding = true).handle(request, RequestLocal.withThreadConfinedCaching)
+
+ val response = capturedResponse.getValue.asInstanceOf[DescribeQuorumResponse]
+ assertEquals(Errors.UNKNOWN_SERVER_ERROR, Errors.forCode(response.data.errorCode))
+ }
+
+ @Test
+ def testDescribeQuorumForwardedForKRaftClusters(): Unit = {
+ val requestData = DescribeQuorumRequest.singletonRequest(KafkaRaftServer.MetadataPartition)
+ val requestBuilder = new DescribeQuorumRequest.Builder(requestData)
+ metadataCache = MetadataCache.raftMetadataCache(brokerId)
+
+ testForwardableApi(
+ createKafkaApis(raftSupport = true),
+ ApiKeys.DESCRIBE_QUORUM,
+ requestBuilder
+ )
+ }
Review comment:
Fair question. Let me see if I can add a request test.
##########
File path: core/src/test/scala/unit/kafka/server/KafkaApisTest.scala
##########
@@ -462,16 +461,55 @@ class KafkaApisTest {
@Test
def testAlterConfigsWithForwarding(): Unit = {
val requestBuilder = new AlterConfigsRequest.Builder(Collections.emptyMap(), false)
- testForwardableAPI(ApiKeys.ALTER_CONFIGS, requestBuilder)
+ testForwardableApi(ApiKeys.ALTER_CONFIGS, requestBuilder)
+ }
+
+ @Test
+ def testDescribeQuorumNotAllowedForZkClusters(): Unit = {
+ val requestData = DescribeQuorumRequest.singletonRequest(KafkaRaftServer.MetadataPartition)
+ val requestBuilder = new DescribeQuorumRequest.Builder(requestData)
+ val request = buildRequest(requestBuilder.build())
+
+ val capturedResponse = expectNoThrottling(request)
+ EasyMock.replay(replicaManager, clientRequestQuotaManager, requestChannel, adminManager, controller)
+ createKafkaApis(enableForwarding = true).handle(request, RequestLocal.withThreadConfinedCaching)
+
+ val response = capturedResponse.getValue.asInstanceOf[DescribeQuorumResponse]
+ assertEquals(Errors.UNKNOWN_SERVER_ERROR, Errors.forCode(response.data.errorCode))
+ }
+
+ @Test
+ def testDescribeQuorumForwardedForKRaftClusters(): Unit = {
+ val requestData = DescribeQuorumRequest.singletonRequest(KafkaRaftServer.MetadataPartition)
+ val requestBuilder = new DescribeQuorumRequest.Builder(requestData)
+ metadataCache = MetadataCache.raftMetadataCache(brokerId)
+
+ testForwardableApi(
+ createKafkaApis(raftSupport = true),
+ ApiKeys.DESCRIBE_QUORUM,
+ requestBuilder
+ )
+ }
Review comment:
Added a basic integration test case. Good thing too because it uncovered the need to set the `forwardable` flag in `ApiKeys`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org